ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
26,600 Commits 589 Branches 805 Tags
cdc7ab42b111a4e6aaaac19e86069d996ea11002
Commit Graph

26600 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michał Kępień
cdc7ab42b1 Only log bumped signed serial after a successful secure zone update 
If a raw zone is modified, but the dns_update_signaturesinc() call in
receive_secure_serial() fails, the corresponding secure zone's database
will not be modified, even though by that time a message containing the
bumped signed serial will already have been logged.  This creates
confusion, because a different secure zone version will be served than
the one announced in the logs.  Move the relevant dns_zone_log() call so
that it is only performed if the secure zone's database is modified.

(cherry picked from commit cfbc8e264d)
 2018-04-25 12:09:03 -07:00
Evan Hunt
5cef06f8d0 Merge branch '171-lgtm-issues-v9_12' into 'v9_12' 
Resolve "problems detected by LGTM static analyzer"

Closes #171

See merge request isc-projects/bind9!213
 2018-04-22 12:57:52 -07:00
Evan Hunt
493a8b53ed remove unnecessary comparison 
(cherry picked from commit 8b1baa10ee)
 2018-04-22 12:57:52 -07:00
Evan Hunt
fe27dfa9fd silence warnings about unnecessary comparisons 
- these are cases where result has been explicitly set, so
  if (result != ISC_R_SUCCESS) is unnecessary

(cherry picked from commit e00eb55cd2)
 2018-04-22 12:57:52 -07:00
Evan Hunt
19be8866d8 add header guards in files that were missing them 
(cherry picked from commit 4247477b61)
 2018-04-22 12:57:52 -07:00
Evan Hunt
b8aec550c4 add header guard when generating bind.keys.h 
(cherry picked from commit bfbe6925df)
 2018-04-22 12:57:52 -07:00
Evan Hunt
982ddf4012 change "key" to "tsigkey" to silence "short global name" warning 
(cherry picked from commit 0cc7aa250e)
 2018-04-22 12:57:52 -07:00
Evan Hunt
97cbc27ed7 fix shadowed global variables 
(cherry picked from commit 9ca3ab1168)
 2018-04-22 12:57:52 -07:00
Evan Hunt
62c64cfe85 fix duplicate include guard in dnsconf.h 
- IMHO we should consider removing dnsconf.c and deprecating the
  /etc/dns.conf file, though, as I don't think it's likely anyone
  is using it

(cherry picked from commit a08ba418ef)
 2018-04-22 12:57:52 -07:00
Evan Hunt
d44d594219 Merge branch '37-implement-geoff-huston-s-trusted-key-sentinel-feature-v9_12' into 'v9_12' 
Implement Geoff Huston's trusted key sentinel feature

Closes #37

See merge request isc-projects/bind9!123
 2018-04-22 12:48:12 -07:00
Mark Andrews
af267c4da9 CHANGES entry for root-key-sentinel 
(cherry picked from commit 2845d7160e)
 2018-04-22 12:48:10 -07:00
Mark Andrews
edb761b08c add release note for root-key-sentinel 
(cherry picked from commit e20790c956)
 2018-04-22 12:47:31 -07:00
Mark Andrews
b9e6b124aa add system test for root-key-sentinel 
(cherry picked from commit a23b305e6b)
 2018-04-22 12:46:03 -07:00
Mark Andrews
ee763ef281 add named.conf option root-key-sentinel 
(cherry picked from commit 68e9315c7d)
 2018-04-22 12:46:03 -07:00
Mark Andrews
7111eff80c detect and processes root-key-sentinel labels. 
(cherry picked from commit 8fc9f64df9)
 2018-04-22 12:46:03 -07:00
Ondřej Surý
0071c0400f Merge branch '202-cppcheck-reporting-miscellaneous-issues-v9_12' into 'v9_12' 
Resolve "cppcheck reporting miscellaneous issues"

See merge request isc-projects/bind9!216
 2018-04-20 18:20:11 -04:00
Mark Andrews
77643775c5 remove exit calls after FATAL_ERROR 
(cherry picked from commit f8d2a46daa)
 2018-04-20 15:13:12 -07:00
Mark Andrews
53e39ca0ea remove dead code 
(cherry picked from commit 686edad5c5)
 2018-04-20 15:13:12 -07:00
Mark Andrews
ba238ab374 use %u instead of %d for unsigned int arguments 
(cherry picked from commit 49f8e9571c)
 2018-04-20 15:13:12 -07:00
Ondřej Surý
5e11b261f4 Merge branch '206-nslookup-accepts-any-bogus-option-interpret-it-as-vc-v9_12' into 'v9_12' 
Resolve "nslookup accepts any -bogus -option, interpret it as -vc"

See merge request isc-projects/bind9!214
 2018-04-20 18:01:02 -04:00
Mukund Sivaraman
a36f89341f Remove bogus comparison 
(cherry picked from commit 89cf503880)
 2018-04-20 14:51:26 -07:00
Ondřej Surý
7c830940b9 Merge branch '189-fix-win32-build-v9_12' into 'v9_12' 
[v9_12] Fix runtime assertion on Windows due isc_file_template being out-of-sync

See merge request isc-projects/bind9!194
 2018-04-12 03:00:44 -04:00
Ondřej Surý
6171037403 Sync isc_file_template functions between unix and win32, so they are same 
(cherry picked from commit 8c99d104e3)
 2018-04-12 08:47:11 +02:00
Ondřej Surý
c4a7fbcc36 Merge branch '189-fix-tsig-dump-keyfile-name-generation-issues-v9_12' into 'v9_12' 
[v9_12] Fix TSIG dump keyfile name generation issues

See merge request isc-projects/bind9!191
 2018-04-11 08:45:17 -04:00
Mukund Sivaraman
c932fd2d49 Fix TSIG dump keyfile name buffer size issues 
(cherry picked from commit 44b84cb5a6)
 2018-04-11 14:37:46 +02:00
Ondřej Surý
e052e7f427 Define PATH_MAX on Windows as _MAX_PATH, so we can use it everywhere 
(cherry picked from commit 7467735258)
 2018-04-11 14:37:46 +02:00
Evan Hunt
5ce20e4928 Merge branch '193-fix-variable-definitions-in-bin-tests-Makefile.in-v9_12' into 'v9_12' 
Fix variable definitions in bin/tests/Makefile.in

Closes #193

See merge request isc-projects/bind9!183
 2018-04-10 20:04:31 -07:00
Evan Hunt
a6cbac45eb Alter distclean rule to prevent recursing into the same directory twice 
Commit f87e0c03ee removed the "system" directory from the TESTDIRS
variable in bin/tests/Makefile.in in an attempt to fix "make distclean"
which was broken since commit 0d784de16a.  However, this change
prevented any system tests from being run when "make test" is invoked.

We now put it back into both SUBDIRS and TESTDIRS, but with a modified
rule to check for the existence of a Makefile in each subdirectory before
trying to run make there. This prevents "make distclean" from trying to
run again in a directory where it's already been run.

(cherry picked from commit 93ee6b8a22)
 2018-04-10 20:04:31 -07:00
Michał Kępień
a7f8268833 Fail CI pipeline when "make test" does not run any system tests 
Apart from ensuring "make test" returns 0, also check whether any system
test output was generated as a result of running it.  This prevents the
CI job running system tests from succeeding unless it actually tests
something.

(cherry picked from commit 80ab2c0f22)
 2018-04-10 20:04:31 -07:00
Evan Hunt
b26a269b42 Merge branch '197-dnstap-sockaddr-v9_12' into 'v9_12' 
Resolve "dnstap: log actual local IPv6 address, not :: listening address"

Closes #197

See merge request isc-projects/bind9!188
 2018-04-10 17:21:08 -07:00
Evan Hunt
fde64f3fe4 CHANGES note 
(cherry picked from commit 330b26c9df)
 2018-04-10 17:21:08 -07:00
Tony Finch
58aac41b7e dnstap: log actual local IPv6 address, not :: listening address 
(cherry picked from commit ccff953c25)
 2018-04-10 17:21:08 -07:00
Evan Hunt
011968a6d4 Merge branch '183-add-dns_fixedname_initname-v9_12' into 'v9_12' 
Add and use dns_fixedname_initname()

Closes #183

See merge request isc-projects/bind9!161
 2018-04-10 13:10:29 -07:00
Mukund Sivaraman
d7676d0fa8 Add CHANGES entry: 
4921.   [cleanup]       Add dns_fixedname_initname() and refactor the caller
                        code to make usage of the new function, as a part of
                        refactoring dns_fixedname_*() macros were turned into
                        functions. [GL #183]

(cherry picked from commit d7faee2566)
 2018-04-10 13:10:23 -07:00
Michał Kępień
706f865a20 Do not access dns_fixedname_t fields directly 
Employ dns_fixedname_name() and dns_fixedname_initname() to no longer
directly access dns_fixedname_t fields.

(cherry picked from commit 39ddf9991f)
 2018-04-10 13:09:37 -07:00
Michał Kępień
0041aeb751 Use dns_fixedname_initname() where possible 
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.

This patch was mostly prepared using Coccinelle and the following
semantic patch:

    @@
    expression fixedname, name;
    @@
    -	dns_fixedname_init(&fixedname);
    	...
    -	name = dns_fixedname_name(&fixedname);
    +	name = dns_fixedname_initname(&fixedname);

The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.

It is likely that more occurrences of this pattern can be refactored in
an identical way.  This commit only takes care of the low-hanging fruit.

(cherry picked from commit 4df4a8e731)
 2018-04-10 13:09:24 -07:00
Mukund Sivaraman
cee4fef7c5 Add a dns_fixedname_initname() helper function 
This also turns the dns_fixedname macros into functions.

(cherry picked from commit 0d2a03c290)
 2018-04-10 13:06:43 -07:00
Mark Andrews
38d5e47881 Merge branch 'ssl-double-free-v9_12' into 'v9_12' 
Fix double free after keygen error in dnssec-keygen

Closes #109

See merge request isc-projects/bind9!70
 2018-04-06 14:23:01 +10:00
Ondřej Surý
24ea156f9e Add CHANGES entry 
(cherry picked from commit ef2b2a6c92)
 2018-04-06 14:22:46 +10:00
Ondřej Surý
cd6d3fbf07 A couple of more cleanups after free in opensslrsa_generate() 
(cherry picked from commit d2b3188c61)
 2018-04-06 14:21:11 +10:00
Petr Mensik
d27c7940d9 Do not assign NULL conditionally in OpenSSL < 1.1, make it always explicit. 
(cherry picked from commit edaafacf36)
 2018-04-06 14:21:11 +10:00
Petr Mensik
587452f830 Fix double free on RSA_generate_key_ex failure 
(cherry picked from commit 01cc622e7b)
 2018-04-06 14:21:11 +10:00
Mark Andrews
342e146fe3 system should only be in SUBDIRS 2018-04-06 13:04:15 +10:00
Ondřej Surý
9cf1468b77 Update libtool files to 2.4.6 
(cherry picked from commit fe06778be7)
 2018-04-06 12:36:39 +10:00
Ondřej Surý
c2f32eba34 Merge branch 'pemensik/bind9-no-idn2-export-v9_12' into 'v9_12' 
Don't include -lidn2 in isc-config.sh output

See merge request isc-projects/bind9!179
 2018-04-05 06:15:41 -04:00
Ondřej Surý
40e5ba9cc5 Print information about LIBIDN2 in Configuration summary (Closes: #163) 
(cherry picked from commit 8da5e5290f)
 2018-04-05 12:07:53 +02:00
Petr Menšík
8e8c195f94 Remove -lidn2 from exported LIBS. Do not propagate it from isc-config.sh --libs isc. 
(cherry picked from commit 21c2871667)
 2018-04-05 12:07:51 +02:00
Ondřej Surý
2c1fdbbb36 Merge branch 'kchen/bind9-test-prereqs-v9_12' into 'v9_12' 
Add a Net::DNS prereq for couple of tests

See merge request isc-projects/bind9!176
 2018-04-04 17:07:36 -04:00
Kevin Chen
a8d7b3a12b Add a Net::DNS prereq for digdelv, fetchlimit, rpzrecurse, and zero 
tests to avoid failed tests when Net::DNS is not present.

(cherry picked from commit 8b1b809ab4)
 2018-04-04 23:00:56 +02:00
Stephen Morris
5fafa7303c Merge branch '139-tests-for-idna2008-libidn2-merge-v9_12' into 'v9_12' 
Resolve "Tests for IDNA2008 (libidn2)" - Merge into 9.12

See merge request isc-projects/bind9!174
 2018-04-04 10:05:05 -04:00