Commit Graph

1333 Commits

Author SHA1 Message Date
David Lawrence
eda73d8aad redo 1.64 "potential null pointer dereference" more consistent with the style
of the function and file (i.e., not returning from the middle of a function)
2001-06-10 17:06:45 +00:00
David Lawrence
04260c5c48 895. [func] New function, isc_dir_current(), akin to POSIX's
getcwd().
2001-06-08 23:50:32 +00:00
David Lawrence
504f7802d4 893. [func] Removed isc_file_test() and added isc_file_exists()
for the basic functionality that was being added
			with isc_file_test().
2001-06-08 21:53:49 +00:00
Mark Andrews
4585aeb2cc 866. [func] Close debug only file channels when debug is set to
zero. [RT #1246]
2001-06-08 02:57:13 +00:00
Brian Wellington
224e84bc0e misc. stuff related to [RT #1293] 2001-06-07 00:21:53 +00:00
Brian Wellington
338d559b3e remove extraneous blank line 2001-06-06 21:02:43 +00:00
David Lawrence
65640f401a Removed the requirement for isc_mem_setwater() that when the callback function
is not null then hi_water must exceed lo_water and both must be > 0.
Now requires hi_water >= lo_water, and they can both be 0.  Not allowing
them to be equal was just an unnecessary restriction, and letting them be 0
is useful for the case where the context has had non-zero values set, went
over hi_water and called the callback, and then wanted to remove limits
(perhaps because of a reconfiguration).  This allows the callback to
be signaled as ISC_MEM_LOWATER on the next isc_mem_put(), which the caller
might need to terminate any outstanding action that was triggered by
the hi_water.
2001-06-05 22:14:20 +00:00
Brian Wellington
33e49e8fdc #include <isc/magic.h> 2001-06-05 06:34:11 +00:00
David Lawrence
92ef1a9b9d use ISC_MAGIC for all magic numbers, for our friends in EBCDIC land 2001-06-04 19:33:39 +00:00
Brian Wellington
d0b6ece407 ISC_LANG_BEGINDECLS -> ISC_LANG_ENDDECLS 2001-06-01 01:11:28 +00:00
David Lawrence
64c7a503c2 ensure that INADDR_LOOPBACK is defined 2001-05-31 10:54:51 +00:00
David Lawrence
50b7860fff new function isc_file_test() as framework for determining various attributes
of a pathname
2001-05-31 10:53:14 +00:00
Brian Wellington
9547c4a3f8 potential null pointer dereference 2001-05-29 22:35:54 +00:00
Mark Andrews
097dc0a693 add sys/types.h for FreeBSD 2.1 2001-05-18 03:02:45 +00:00
Andreas Gustafsson
d76b6ae2ad isc_print_vsnprintf() could throw an assertion failure when
given a %lld format, causing a deadlock when logging the assertion if invoked
from the logging system.  Since the %qd format does not have the bug, this only
affects platforms where the native quad format is %lld and that lack a native
vsnprintf().  The only known such platform is SunOS 5.5.1. [RT #1312]
2001-05-16 00:52:55 +00:00
Andreas Gustafsson
740ae0808f when returning a socket error, use isc__errno2result() instead
of always returning ISC_R_UNEXPECTED
2001-05-14 23:58:33 +00:00
Andreas Gustafsson
fd5847ef09 828. [bug] The errno value from recvfrom() could be overwritten
by logging code. [RT #1293]
2001-05-14 18:20:03 +00:00
Andreas Gustafsson
c3ebcedbe5 Add isc_file_progname(), with trivial POSIX implementation, and
call it from main().  A separate WIN32 implementation will be needed.
2001-05-08 19:47:55 +00:00
Brian Wellington
d144ea1d1c isc_file_basename should return a (const char *) 2001-05-05 02:47:21 +00:00
Brian Wellington
f2194a8ba9 implement isc_file_basename() 2001-05-03 18:59:30 +00:00
Andreas Gustafsson
1ed0723a1f a pointer argument used to return an "int" value into an "int"
variable is better defined as "int *" than "unsigned int *"
2001-04-28 01:08:07 +00:00
Andreas Gustafsson
5e194abb5b 814. [bug] Socket objects left over from accept() failures
were incorrectly destroyed, causing corruption
                        of socket manager data structures.

 813.   [bug]           File descriptors exceeding FD_SETSIZE were handled
                        badly. [RT #1192]
2001-04-26 23:45:55 +00:00
David Lawrence
2b5f436aeb Make greatest_version() return an isc_result_t, which it should have
been doing all along since there was the possibility isc_dir_open() would
fail and overloading the return value of "0" was bad practice.

If isc_dir_open() fails in greatest_version(), make sure the path separator
is restored to the destination pathname if it was NULified before returning
the error.

The underlying problem of isc_log_open() not having the bad result of
isc_dir_open() reported anywhere will be slightly mediate by a change
to bin/named/logconf.c to test the directory.  lib/isc/log.c can't really
handle it because it has no idea to where such an error should be reported,
and it only shows up during isc_log_open() as part of the isc_log_write()
family of calls, which are all void.
2001-04-25 23:59:44 +00:00
Andreas Gustafsson
0dc1e14537 alphabetized includes 2001-04-24 18:40:07 +00:00
David Lawrence
1bd5b8aac6 use ISC_MAGIC to define magic number 2001-04-17 14:36:45 +00:00
David Lawrence
79ed194592 sigh. always test recompile things even after a minor change. after deciding
to _not_ much with the lock tracing/printing facility for the last change,
i forgot to also add the new result variable back into the stack
declarations, where i had correctly put it the first time.
2001-04-17 13:42:32 +00:00
David Lawrence
8e60ba90e0 unlock the mutex when non-blocking locking is attempted and the lock is busy. 2001-04-17 04:07:38 +00:00
David Lawrence
900d7d9c9b forgot to actually change the macro call that needed the deconst argument 2001-04-14 00:20:07 +00:00
David Lawrence
ddb8f23a09 a different approach to shutting up compilers about an empty file, one that
does not cause all the compilers to complain about a variable being
defined but not used.
2001-04-13 02:26:32 +00:00
David Lawrence
79b19f175c added a single static variable declaration to prevent compilers from
complainig about an effectively empty input file.
2001-04-12 22:26:41 +00:00
David Lawrence
de6fe5ebe2 cleared up a const issue with IN6_IS_ADDR_V4MAPPED on some platforms 2001-04-12 21:23:21 +00:00
David Lawrence
6f053cd485 use ISC_TF() to set an isc_boolean_t 2001-04-12 21:04:14 +00:00
David Lawrence
3507ae5d59 #include <time.h> for the utimes() prototype 2001-04-12 19:46:39 +00:00
Andreas Gustafsson
7900390a52 Previous change turned invalid peer address returns from accept()
into hard errors - they should be soft errors
2001-04-10 21:48:27 +00:00
Andreas Gustafsson
a84cfaa3f2 The bug fix in socket.c 1.189 was less than ideal: if a socket
got wedged in a state where accept() always returns EBADF, the server would loop calling
internal_accept() repeatedly.  Implemented an alternative fix where a hard
error in accept() causes an event with a nonzero result code to be sent, and
the new socket object to be freed
2001-04-10 21:38:33 +00:00
Brian Wellington
f8b3c62794 804. [bug] Attempting to obtain entropy could fail in some
situations.  This would be most common on systems
			with user-space threads. [RT #1131]
2001-04-04 20:57:35 +00:00
Brian Wellington
672056d560 797. [func] Issue a warning if the 'directory' option contains
a relative path. [RT #269]
2001-03-29 02:33:48 +00:00
David Lawrence
2a86ee1f54 simplify the test about whether to roll; one expression was redundant 2001-03-28 05:48:16 +00:00
David Lawrence
9027e1bcf1 796. [func] When a size limit is associated with a log file,
only roll it when the size is reached, not every
			time the log file is opened. [RT #1096]
2001-03-28 04:16:32 +00:00
Brian Wellington
1d92d8a245 792. [cleanup] Replace the OMAPI command channel protocol with a
simpler one.
2001-03-27 00:44:59 +00:00
Brian Wellington
6eccf5bd07 788. [feature] Add the "match-mapped-addresses" options, which
causes IPv6 v4mapped addresses to be treated as
			IPv4 addresses for the purpose of acl matching.
2001-03-26 21:33:07 +00:00
Andreas Gustafsson
9efa0d2ae3 do not capitalize error message strings 2001-03-24 02:18:42 +00:00
Brian Wellington
734ae1f7c6 isc_{base64|hex}_decodestring took an unused mctx. Remove the mctx. 2001-03-22 00:07:07 +00:00
Brian Wellington
48565891e8 784. [bug] nsupdate and other programs would not quit properly
if some signals were blocked by the caller. [RT #1081]
2001-03-20 21:45:20 +00:00
Brian Wellington
dde4382b7f fix comment 2001-03-19 22:44:52 +00:00
Brian Wellington
2f02f32f04 exit(1), not exit(-1) 2001-03-14 06:31:17 +00:00
Bob Halley
c6237585d8 Fix some typos in the non-threaded version of isc_rwlock_trylock() that
were preventing compilation.
2001-03-08 19:52:13 +00:00
David Lawrence
a82fd2c01b added non-blocking locking, isc_rwlock_trylock() 2001-03-08 00:55:15 +00:00
Andreas Gustafsson
d55642259e use a simpler, faster hash function 2001-03-07 23:52:16 +00:00
Brian Wellington
2eb3dafdcf Add the socket flag ISC_R_NORETRY, which makes the socket code treat
a soft error as a hard error on send (that is, not retry it).  It also
modifies the code calling sendmsg() to retry on EINTR.
2001-03-06 01:23:03 +00:00