ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
27,156 Commits 589 Branches 805 Tags
af021f136e277a4eec00a1a31d159a17f3e3cd85
Commit Graph

27156 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ondřej Surý
6aa63d9349 Add extra return failure after INSIST(0) in default branch 
(cherry picked from commit 29c45200e7)
(cherry picked from commit 2a26189256)
 2018-11-08 22:03:33 +07:00
Ondřej Surý
d894b2da79 Use larger buffers on snprintf buffer overflow false positives 
(cherry picked from commit 4eaf927571)
(cherry picked from commit 65536fb10b)
 2018-11-08 22:03:33 +07:00
Ondřej Surý
c576cb2ff6 Don't assert on failed getrlimit call to allow called to handle this gracefully as it already does, just abort where we need to know the numbers 
(cherry picked from commit e2e138a801)
(cherry picked from commit 1e6329038b)
 2018-11-08 22:03:31 +07:00
Ondřej Surý
f1224b4af1 When ISC assertions are disabled, still execute the condition to prevent unused variable warnings/errors from the compiler 
(cherry picked from commit a831e0f72d)
(cherry picked from commit 3d834566f1)
 2018-11-08 22:03:00 +07:00
Ondřej Surý
7eb962ee14 Add a GitLab CI job that runs with all assertions disabled 
(cherry picked from commit 461ffead1f)
(cherry picked from commit c5825eba40)
 2018-11-08 22:03:00 +07:00
Ondřej Surý
12a266211e Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool 
(cherry picked from commit b2b43fd235)
(cherry picked from commit fcd1569e2b)
 2018-11-08 22:02:58 +07:00
Ondřej Surý
9d15323e24 Add small tweaks to the code to fix compilation when ISC assertions are disabled 
While implementing the new unit testing framework cmocka, it was found that the
BIND 9 code doesn't compile when assertions are disabled or replaced with any
function (such as mock_assert() from cmocka unit testing framework) that's not
directly recognized as assertion by the compiler.

This made the compiler to complain about blocks of code that was recognized as
unreachable before, but now it isn't.

The changes in this commit include:

* assigns default values to couple of local variables,
* moves some return statements around INSIST assertions,
* adds __builtin_unreachable(); annotations after some INSIST assertions,
* fixes one broken assertion (= instead of ==)

(cherry picked from commit fbd2e47f51)
(cherry picked from commit b222783ae9)
 2018-11-08 22:00:49 +07:00
Mark Andrews
76983d693e Merge branch 'wpk-get-rid-of-bashism-in-CDS-test-v9_11' into 'v9_11' 
Small system tests fixes for Solaris

See merge request isc-projects/bind9!992
 2018-11-07 20:36:40 -05:00
Witold Krecicki
2db31ececa Remove unnecessary sed from autosign test 
(cherry picked from commit 82dfb77328)
 2018-11-08 12:26:04 +11:00
Witold Krecicki
4b9d115e35 Use 'local' variable in echo functions in tests 
(cherry picked from commit 0949b1fe2c)
 2018-11-08 12:26:01 +11:00
Mark Andrews
93efc4724f Merge branch '653-idnout-only-on-tty-v9_11' into 'v9_11' 
Enable idnout output only on tty, disable it when the stdout is not a tty

See merge request isc-projects/bind9!984
 2018-11-06 19:50:15 -05:00
Ondřej Surý
0dd034d66b Add CHANGES entry for GL #653 
(cherry picked from commit 9c0c44405c)
 2018-11-07 11:37:11 +11:00
Ondřej Surý
31a974bc05 Add release notes for IDN processing update 
(cherry picked from commit 2a11a7dd29)
 2018-11-07 11:37:11 +11:00
Ondřej Surý
96f621bbef Update the IDN documentation for nslookup 
(cherry picked from commit b659765869)
 2018-11-07 11:37:11 +11:00
Ondřej Surý
45f99ab755 Change the dig documentation 
(cherry picked from commit 7697923eab)
 2018-11-07 11:37:11 +11:00
Ondřej Surý
ec6bb32c6a Update the idna tests for the new non-tty defaults 
(cherry picked from commit e8c57a78aa)
 2018-11-07 11:37:11 +11:00
Ondřej Surý
8e1cc95c94 Enable IDN processing (both idnin and idnout) only on tty, disable it when the stdout is not a tty 
(cherry picked from commit 0e1bf7d017)
 2018-11-06 17:36:48 +11:00
Mark Andrews
67401ba29c Merge branch '601-build-option-with-python-should-default-to-yes-v9_11' into 'v9_11' 
Resolve "Build option --with-python should default to yes"

See merge request isc-projects/bind9!982
 2018-11-06 00:52:41 -05:00
Mark Andrews
0768f54fd2 require python to be explicitly disabled 
(cherry picked from commit bf8746126c)
 2018-11-06 16:44:06 +11:00
Mark Andrews
9f15b9d80a Merge branch '617-if-rrl-is-configured-the-require-server-cookie-yes-is-ignored-v9_11' into 'v9_11' 
Resolve "If RRL is configured the "require-server-cookie yes;" is ignored."

See merge request isc-projects/bind9!978
 2018-11-05 18:52:38 -05:00
Mark Andrews
cc35795b07 add CHANGES note 
(cherry picked from commit a868f335d2)
 2018-11-06 10:34:45 +11:00
Mark Andrews
636e435e11 test require-server-cookie with rate-limit 
(cherry picked from commit 164370102a)
 2018-11-06 10:33:35 +11:00
Mark Andrews
f4bea4002a check requireservercookie even if rrl is configured 
(cherry picked from commit d6f6eeda9d)
 2018-11-06 10:33:32 +11:00
Mark Andrews
f59644a145 Merge branch '649-resolver-test-failing-v9_11' into 'v9_11' 
Resolve "resolver test failing"

See merge request isc-projects/bind9!961
 2018-10-31 01:51:15 -04:00
Mark Andrews
f21e5369a5 use new packet for response; rename variable to request and response 
(cherry picked from commit 280d0ca507)
 2018-10-31 16:38:48 +11:00
Evan Hunt
dea184741e Merge branch 'silence-warning-v9_11' into 'v9_11' 
silence warning from missing print.h

See merge request isc-projects/bind9!957
 2018-10-30 11:11:24 -04:00
Evan Hunt
6690b9e5a3 silence warning from missing print.h 
(cherry picked from commit a0de6707c0)
 2018-10-30 08:09:44 -07:00
Michał Kępień
131e26e671 Merge branch '644-fix-isc_buffer_copyregion-for-auto-reallocated-buffers-v9_11' into 'v9_11' 
[v9_11] Fix isc_buffer_copyregion() for auto-reallocated buffers

See merge request isc-projects/bind9!951
 2018-10-30 08:52:28 -04:00
Michał Kępień
1a69df0211 Add CHANGES entry 
5072.	[bug]		Add unit tests for isc_buffer_copyregion() and fix its
			behavior for auto-reallocated buffers. [GL #644]

(cherry picked from commit 07050fb49a)
 2018-10-30 13:34:49 +01:00
Michał Kępień
00bc5bf6bd Fix isc_buffer_copyregion() for auto-reallocated buffers 
While isc_buffer_copyregion() calls isc_buffer_reserve() to ensure the
target buffer will have enough available space to append the contents of
the source region to it, the variables used for subsequently checking
available space are not updated accordingly after that call.  This
prevents isc_buffer_copyregion() from working as expected for
auto-reallocated buffers: ISC_R_NOSPACE will be returned if enough space
is not already available in the target buffer before it is reallocated.
Fix by calling isc_buffer_used() and isc_buffer_availablelength()
directly instead of assigning their return values to local variables.

(cherry picked from commit e1f0aed034)
 2018-10-30 13:34:49 +01:00
Michał Kępień
b549996d58 Add unit tests for isc_buffer_copyregion() 
Add some basic checks for isc_buffer_copyregion() to ensure it behaves
as expected for both fixed-size buffers and buffers which can be
automatically reallocated.  Adjust the list of headers included by
lib/isc/tests/buffer_test.c so that it matches what that test program
really uses.

(cherry picked from commit 15440d8027)
 2018-10-30 13:34:48 +01:00
Ondřej Surý
31dba79733 Merge branch 'ondrej/cleanup-leftover-fatal-v9_11' into 'v9_11' 
(v9_11) Remove double result check leftover

See merge request isc-projects/bind9!948
 2018-10-30 08:10:33 -04:00
Ondřej Surý
a437c42521 Remove double result check leftover 
(cherry picked from commit 065ff16e40)
 2018-10-30 13:00:51 +01:00
Mark Andrews
6ee7fd95e7 Merge branch '631-dns_rdata_compare-for-nxt-performs-case-sensitive-name-comparison-v9_11' into 'v9_11' 
Resolve "dns_rdata_compare() for NXT performs case sensitive name comparison"

See merge request isc-projects/bind9!942
 2018-10-30 00:26:20 -04:00
Mark Andrews
a037959ae3 add CHANGES note 
(cherry picked from commit 921bc89f59)
 2018-10-30 15:13:22 +11:00
Mark Andrews
e646307f91 compare_nxt compared records with identical next fields case insensitively 
(cherry picked from commit cf83016682)
 2018-10-30 15:10:55 +11:00
Mark Andrews
3b6346b5a3 Merge branch 'move-declaration-of-pending-v9_11' into 'v9_11' 
move declaration of pending

See merge request isc-projects/bind9!940
 2018-10-29 20:55:58 -04:00
Mark Andrews
375df38a4a move declaration of pending 
(cherry picked from commit bc53e5e5d4)
 2018-10-30 11:55:12 +11:00
Mark Andrews
e93e971fea Merge branch '638-record-types-with-empty-rdata-fields-were-not-being-handled-correctly-v9_11' into 'v9_11' 
Resolve "Record types with empty rdata fields were not being handled correctly."

See merge request isc-projects/bind9!938
 2018-10-29 20:28:26 -04:00
Mark Andrews
67816c747d document eol 
(cherry picked from commit 97a680e5ce)
 2018-10-30 11:18:06 +11:00
Mark Andrews
9b0a277490 Record types which support a empty rdata field were not handling the empty rdata field case. 
(cherry picked from commit 2ff57d8a39)
 2018-10-30 11:17:59 +11:00
Evan Hunt
c4cc5c3836 Merge branch '641-unquoted-rpz-v9_11' into 'v9_11' 
allow unquoted response-policy zone names

See merge request isc-projects/bind9!935
 2018-10-29 13:14:24 -04:00
Evan Hunt
dc59f82011 allow unquoted response-policy zone names 
(cherry picked from commit 507230aa88)
 2018-10-29 10:00:27 -07:00
Mark Andrews
f735b3c61b Merge branch '635-unchecked-return-in-query-c-v9_11' into 'v9_11' 
Resolve "unchecked return in query.c"

See merge request isc-projects/bind9!931
 2018-10-29 03:39:04 -04:00
Mark Andrews
332e0bc3c2 always call RUNTIME_CHECK(result == ISC_R_SUCCESS); for dns_rdata_tostruct 
(cherry picked from commit e11cfafff2)
 2018-10-29 18:30:16 +11:00
Mark Andrews
78619cc129 Merge branch '553-socket-c-2171-unexpected-error-v9_11' into 'v9_11' 
Only set IPV6_USE_MIN_MTU on IPv6.

See merge request isc-projects/bind9!927
 2018-10-29 02:43:28 -04:00
Mark Andrews
bf299d5ee1 Only set IPV6_USE_MIN_MTU on IPv6. 
(cherry picked from commit 561b780ba0)
 2018-10-29 17:29:36 +11:00
Mark Andrews
39f3fefc74 Merge branch '624-lib-dns-dnstap_test-totext-does-not-work-well-with-softhsm-pkcs11-v9_11' into 'v9_11' 
Resolve "lib/dns/dnstap_test:totext does not work well with SoftHSM PKCS11"

See merge request isc-projects/bind9!923
 2018-10-29 01:46:54 -04:00
Mark Andrews
a7fb84e783 Initalize TZ environment variable before calling dns_test_begin in dnstap_test. 
(cherry picked from commit 1cf1254051)
 2018-10-29 16:36:25 +11:00
Evan Hunt
d1d42ef30d Merge branch '626-implement-eid-and-nimloc-v9_11' into 'v9_11' 
Resolve "Implement EID and NIMLOC"

See merge request isc-projects/bind9!914
 2018-10-25 18:44:48 -04:00