Commit Graph

470 Commits

Author SHA1 Message Date
Ondřej Surý
2f8b28efad Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached
(cherry picked from commit 23fff6c569)
(cherry picked from commit 4568669807)
2018-11-08 22:42:52 +07:00
Ondřej Surý
12a266211e Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool
(cherry picked from commit b2b43fd235)
(cherry picked from commit fcd1569e2b)
2018-11-08 22:02:58 +07:00
Ondřej Surý
1084b40b44 Replace custom isc_boolean_t with C standard bool type
(cherry picked from commit 994e656977)
(cherry picked from commit 884929400c)
2018-08-10 15:20:57 +02:00
Ondřej Surý
aaa76dc654 Replace custom isc_u?intNN_t types with C99 u?intNN_t types
(cherry picked from commit cb6a185c69)
(cherry picked from commit d61e6a3111)
2018-08-10 15:20:57 +02:00
Ondřej Surý
bfc6a25f2d Replace ISC_PRINT_QUADFORMAT with inttypes.h format constants
(cherry picked from commit 64fe6bbaf2)
(cherry picked from commit c863a076ae)
2018-08-10 15:20:57 +02:00
Mark Andrews
0a9f953a2f refcount errors on error paths
(cherry picked from commit 4093efc900)
2018-07-31 18:43:18 +10:00
Ondřej Surý
188526f41c Remove $Id markers, Principal Author and Reviewed tags from the full source tree
(cherry picked from commit 55a10b7acd)
2018-05-11 14:25:15 +02:00
Michał Kępień
ecea678dac Use dns_fixedname_initname() where possible
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.

This patch was mostly prepared using Coccinelle and the following
semantic patch:

    @@
    expression fixedname, name;
    @@
    -	dns_fixedname_init(&fixedname);
    	...
    -	name = dns_fixedname_name(&fixedname);
    +	name = dns_fixedname_initname(&fixedname);

The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.

It is likely that more occurrences of this pattern can be refactored in
an identical way.  This commit only takes care of the low-hanging fruit.

(cherry picked from commit 4df4a8e731)
(cherry picked from commit 0041aeb751)
2018-04-10 13:26:23 -07:00
Evan Hunt
8b205089b7 update file headers to remove copyright years 2018-03-14 16:40:20 -07:00
Tinderbox User
574176a88d update copyright notice / whitespace 2018-01-24 23:47:27 +00:00
Evan Hunt
f6ea3eaf82 [v9_11] change uint to isc_uint to fix build failure on windows 2018-01-24 10:59:57 -08:00
Mukund Sivaraman
16f43564c6 Backport performance work to 9.11 (#45637) 2017-12-06 10:35:21 +05:30
Evan Hunt
4a5dfa2d51 [v9_11] silence compiler warning
(cherry picked from commit 49a8cd6c01)
2017-11-30 13:55:49 -08:00
Ondřej Surý
c62d9ac65f [v9_11] Type the shifted values to isc_uint32_t so the top bit is unsigned (found by UBSAN) [RT #46740]
(cherry picked from commit a4a148cf9a)
2017-11-30 18:27:07 +01:00
Mark Andrews
0adaa6be4b #define update_recordsandbytes update_recordsandbytes64 2017-11-28 14:14:04 +11:00
Mark Andrews
f98a58d9e6 map more entry points to <name>64 2017-11-28 14:13:17 +11:00
Tinderbox User
4c713bf940 update copyright notice / whitespace 2017-11-27 23:47:09 +00:00
Mark Andrews
eb59c7d35b restore setting header->heap_index to zero in setsigningtime
(cherry picked from commit c22b540e4c)
2017-11-28 06:47:06 +11:00
Mark Andrews
89085bebd3 More:
4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fails. [RT #46473]

(cherry picked from commit 19f6a63184)
2017-11-27 15:22:20 +11:00
Mark Andrews
55abc014f7 in rdbdb.c:setsigningtime stop breaking heap invariant property unless we are going to restore the invariant property
(cherry picked from commit 6ead410268)
2017-11-24 08:51:01 +11:00
Tinderbox User
7d4205bea9 update copyright notice / whitespace 2017-11-17 23:46:02 +00:00
Mark Andrews
13bd0e3159 remove out of date comment
(cherry picked from commit a197094d76)
2017-11-18 08:51:57 +11:00
Mark Andrews
86d2f9abc8 4821. [bug] When resigning ensure that the SOA's expire time is
always later that the resigning time of other records.
                        [RT #46473]

4820.   [bug]           dns_db_subtractrdataset should transfer the resigning
                        information to the new header. [RT #46473]

4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fail. [RT #46473]

(cherry picked from commit 656eed7c9b)
2017-11-18 07:21:28 +11:00
Mark Andrews
c5e68335a1 address resource leak [RT #46413]
(cherry picked from commit c341e524dc)
2017-10-27 10:01:38 +11:00
Evan Hunt
e7c0f97842 [v9_11] check file and tree headers when loading map files
4792.	[bug]		Fix map file header correctness check. [RT #38418]

(cherry picked from commit 5b69d3da83)
2017-10-25 21:37:21 -07:00
Mark Andrews
d72952cf25 4739. [cleanup] Address clang static analysis warnings. [RT #45952]
(cherry picked from commit f9f3f20d2d)
2017-09-27 10:58:44 +10:00
Michał Kępień
62f2fefaec [v9_11] Prevent possible infinite signing loop after retransferring an inline-signed slave using NSEC3
4727.	[bug]		Retransferring an inline-signed slave using NSEC3
			around the time its NSEC3 salt was changed could result
			in an infinite signing loop. [RT #45080]

(cherry picked from commit f665c724e4)
2017-09-18 09:23:18 +02:00
Evan Hunt
7cd594b842 [master] cleanup strcat/strcpy
4722.	[cleanup]	Clean up uses of strcpy() and strcat() in favor of
			strlcpy() and strlcat() for safety. [RT #45981]

(cherry picked from commit 114f95089c)
2017-09-13 00:17:16 -07:00
Evan Hunt
59122481b2 [v9_11] Maintain ZEROTTL cache entries at the tail of the LRU lists
4662.	[performance]	Improve cache memory cleanup of zero TTL records
			by putting them at the tail of LRU header lists.
			[RT #45274]

(cherry picked from commit e924155211)
2017-07-28 00:13:37 -07:00
Mark Andrews
bfde61d519 4654. [cleanup] Don't use C++ keywords delete, new and namespace.
[RT #45538]

(cherry picked from commit 4bf32aa587)
2017-07-21 12:28:58 +10:00
Mark Andrews
3a015a84bc add mark_stale_header define 2017-04-27 13:02:42 +10:00
Mark Andrews
790345ffa3 add rbtdb_zero_header define 2017-04-27 12:49:55 +10:00
Mukund Sivaraman
9a8b2b3ab3 Adjust RPZ trigger counts only when the entry being deleted exists (#43386)
(cherry picked from commit f23c10f925)
2017-04-21 17:13:45 +05:30
Mukund Sivaraman
eeb16584fb Fix inconsistencies in inline signing time comparisons (#42112)
(cherry picked from commit 4176d278e2)
2017-04-21 16:44:51 +05:30
Tinderbox User
f6b9092741 update copyright notice / whitespace 2017-01-12 23:46:13 +00:00
Mark Andrews
2cee8eadec 4553. [bug] Named could deadlock there were multiple changes to
NSEC/NSEC3 parameters for a zone being processed at
                        the same time. [RT #42770]

(cherry picked from commit d2e1b47d4f)
2017-01-12 14:26:06 +11:00
Tinderbox User
9ab989b88c update copyright notice / whitespace 2016-11-02 23:48:10 +00:00
Mark Andrews
744c1db635 4504. [security] Allow the maximum number of records in a zone to
be specified.  This provides a control for issues
                        raised in CVE-2016-6170. [RT #42143]

(cherry picked from commit 5f8412a4cb)
2016-11-03 09:48:26 +11:00
Evan Hunt
6ce5279d0f [v9_11] check for STALE rdatasets in cache search
4446.	[bug]		The cache_find() and _findrdataset() functions
			could find rdatasets that had been marked stale.
			[RT #42853]

(cherry picked from commit 46e7763d19)
2016-08-17 11:44:41 -07:00
Mark Andrews
b4bbf49418 4439. [bug] Address race conditions getting ownernames of nodes.
[RT #43005]

(cherry picked from commit c7e021e2e6)
2016-08-12 14:09:34 +10:00
Mukund Sivaraman
47ed813864 Some general cleanup (#42827)
(cherry picked from commit e65cd99461)
2016-07-13 14:31:48 +05:30
Mark Andrews
8d9a134fe7 4405. [bug] Change 4342 introduced a regression where you could
not remove a delegation in a NSEC3 signed zone using
                        OPTOUT via nsupdate. [RT #42702]

(cherry picked from commit d811a7d9ef)
2016-07-06 10:14:01 +10:00
Mark Andrews
0c27b3fe77 4401. [misc] Change LICENSE to MPL 2.0. 2016-06-27 14:56:38 +10:00
Mark Andrews
b56bd9b59f 4387. [bug] Change 4336 was not complete leading to SERVFAIL
being return as NS records expired. [RT #42683]
2016-06-22 15:26:38 +10:00
Francis Dupont
affa9c9825 Fixed WIN32 (VS 2010 32 bits) compiling problems 2016-05-30 17:10:08 +02:00
Tinderbox User
262bebd081 update copyright notice / whitespace 2016-05-27 23:45:23 +00:00
Mark Andrews
9268297baa 4379. [bug] An INSIST could be triggered if a zone contains
RRSIG records with expiry fields that loop
                        using serial number arithmetic. [RT #40571]
2016-05-27 15:24:30 +10:00
Witold Krecicki
7a00d69909 4376. [experimental] Added support for Catalog Zones, a new method for
provisioning secondary servers in which a list of
                        zones to be served is stored in a DNS zone and can
                        be propagated to slaves via AXFR/IXFR. [RT #41581]

4375.   [func]          Add support for automatic reallocation of isc_buffer
                        to isc_buffer_put* functions. [RT #42394]
2016-05-26 21:23:19 +02:00
Mark Andrews
6214c3c93a 4341. [bug] 'rndc flushtree' could fail to clean the tree if there
wasn't a node at the specified name. [RT #41846]
2016-03-24 11:31:25 +11:00
Mark Andrews
558278974e 4338. [bug] Reimplement change 4324 as it wasn't properly doing
all the required book keeping. [RT #41941]
2016-03-23 10:38:05 +11:00