Commit Graph

28 Commits

Author SHA1 Message Date
Evan Hunt
665122be0d Revert "Merge branch 'ondrej/fix-race-condition-in-dnstap-v9_11' into 'v9_11'"
This reverts merge request !1345
2019-01-23 13:56:26 -05:00
Ondřej Surý
5c73b97715 Fix race condition in cleanup part of dns_dt_create()
(cherry picked from commit 482dd7eed3)
2019-01-15 09:51:25 +01:00
Ondřej Surý
2f8b28efad Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached
(cherry picked from commit 23fff6c569)
(cherry picked from commit 4568669807)
2018-11-08 22:42:52 +07:00
Ondřej Surý
9d15323e24 Add small tweaks to the code to fix compilation when ISC assertions are disabled
While implementing the new unit testing framework cmocka, it was found that the
BIND 9 code doesn't compile when assertions are disabled or replaced with any
function (such as mock_assert() from cmocka unit testing framework) that's not
directly recognized as assertion by the compiler.

This made the compiler to complain about blocks of code that was recognized as
unreachable before, but now it isn't.

The changes in this commit include:

* assigns default values to couple of local variables,
* moves some return statements around INSIST assertions,
* adds __builtin_unreachable(); annotations after some INSIST assertions,
* fixes one broken assertion (= instead of ==)

(cherry picked from commit fbd2e47f51)
(cherry picked from commit b222783ae9)
2018-11-08 22:00:49 +07:00
Ondřej Surý
1084b40b44 Replace custom isc_boolean_t with C standard bool type
(cherry picked from commit 994e656977)
(cherry picked from commit 884929400c)
2018-08-10 15:20:57 +02:00
Ondřej Surý
aaa76dc654 Replace custom isc_u?intNN_t types with C99 u?intNN_t types
(cherry picked from commit cb6a185c69)
(cherry picked from commit d61e6a3111)
2018-08-10 15:20:57 +02:00
Evan Hunt
8b205089b7 update file headers to remove copyright years 2018-03-14 16:40:20 -07:00
Mark Andrews
faf0e3ff65 use %u instead of %d 2018-02-16 14:36:56 +11:00
Tinderbox User
574176a88d update copyright notice / whitespace 2018-01-24 23:47:27 +00:00
Evan Hunt
f6ea3eaf82 [v9_11] change uint to isc_uint to fix build failure on windows 2018-01-24 10:59:57 -08:00
Tinderbox User
1617002c78 update copyright notice / whitespace 2017-02-04 23:46:08 +00:00
Evan Hunt
07b7a3eade [v9_11] store local and remote addresses in dnstap
4569.	[func]		Store both local and remote addresses in dnstap
			logging, and modify dnstap-read output format to
			print them. [RT #43595]

(cherry picked from commit 650b5e7592)
2017-02-03 17:11:06 -08:00
Tinderbox User
a3253fb44c update copyright notice / whitespace 2016-08-25 23:46:16 +00:00
Mark Andrews
6f36f2f7b8 rename ioqversion -> generation; move increment before fstrm_iothr_destroy
(cherry picked from commit 7535dd93a1)
2016-08-25 12:07:34 +10:00
Mark Andrews
7df3f06c0b 4454. [bug] 'rndc dnstap -reopen' had a race issue. [RT #43089]
(cherry picked from commit 726cddb564)
2016-08-25 10:05:07 +10:00
Mark Andrews
7204d08a31 4447. [tuning] Allow the fstrm_iothr_init() options to be set using
named.conf to control how dnstap manages the data
                        flow. [RT #42974]

(cherry picked from commit 934837913f)
2016-08-18 11:16:58 +10:00
Evan Hunt
3525200d9f [v9_11] rndc dnstap -roll
4411.	[func]		"rndc dnstap -roll" automatically rolls the
			dnstap output file; the previous version is
			saved with ".0" suffix, and earlier versions
			with ".1" and so on. An optional numeric argument
			indicates how many prior files to save. [RT #42830]
2016-07-13 01:18:41 -07:00
Mark Andrews
28303a06ce 4410. [bug] Address use after free and memory leak with dnstap.
[RT #42746]

(cherry picked from commit a2101037d9)
2016-07-13 16:56:53 +10:00
Mark Andrews
27330b0e55 #include <stdlib.h>
(cherry picked from commit 700e08fcc4)
2016-06-29 11:39:14 +10:00
Mark Andrews
0c27b3fe77 4401. [misc] Change LICENSE to MPL 2.0. 2016-06-27 14:56:38 +10:00
Mark Andrews
7d262a3647 4394. [func] Add rndc command "dnstap-reopen" to close and
reopen dnstap output filed. [RT #41803]
2016-06-24 09:37:04 +10:00
Mark Andrews
5ba7394a4f complete the NULL pointer fixes 2016-06-23 12:50:47 +10:00
Mark Andrews
96d49a84ff 4493. [bug] Address potential NULL pointer dereferences in
dnstap code.
2016-06-23 12:18:03 +10:00
Tinderbox User
6ad05c5f46 update copyright notice / whitespace 2016-04-13 23:45:17 +00:00
Evan Hunt
5fdf476b32 [master] fix dns_dtmsg_t type redefinition 2016-04-13 10:12:21 -07:00
Tinderbox User
244d11a227 update copyright notice / whitespace 2015-10-03 23:45:23 +00:00
Evan Hunt
48b2a92da2 [master] missing .def entries, print.h 2015-10-02 14:38:59 -07:00
Evan Hunt
b66b333f59 [master] dnstap
4235.	[func]		Added support in named for "dnstap", a fast method of
			capturing and logging DNS traffic, and a new command
			"dnstap-read" to read a dnstap log file.  Use
			"configure --enable-dnstap" to enable this
			feature (note that this requires libprotobuf-c
			and libfstrm). See the ARM for configuration details.

			Thanks to Robert Edmonds of Farsight Security.
			[RT #40211]
2015-10-02 12:32:42 -07:00