Commit Graph
2261 Commits
Author SHA1 Message Date
Brian Wellington 3aec811249 fixed memory leak on TSIG BADSIG 2000-06-06 23:44:13 +00:00
David Lawrence 92ab6defb6 don't redefine DNS_RBT_ANCESTORBLOCK to a tiny size when ISC_MEM_DEBUG is
defined, as it is by default now.  huge performance hit that we would
likely have been slow to notice if not for the t_rbt chain tests
having a bug. :-)
2000-06-06 23:25:29 +00:00
David Lawrence 49f64feb02 removed an irrelevant cast to off_t in the offset wraparound check.
the expression in question is already of type isc_offset_t, which
is just a typedef for off_t.
2000-06-06 22:28:21 +00:00
Brian Wellington b3ef06344a DST API updates 2000-06-06 22:01:49 +00:00
Brian Wellington 4441bfbd6b More dst updates:
- dst_lib_init()/dst_lib_destroy() allow dst to use a predefined
	  mctx and free all resources on exit.
	- dst_key_tofile() & dst_key/fromfile() take a directory parameter.
	- dst_key_parsefile() removed, replaced by dst_key_fromnamedfile()
	- more bug fixes and memory leak fixes
2000-06-06 21:58:16 +00:00
Brian Wellington 46734259ca Replace the calls to openssl error routines with stubs, since the calls
allocate memory somewhere which isn't being freed.
2000-06-06 20:40:28 +00:00
Andreas Gustafsson ee03a00244 changed references to 'binary buffer' in comments
to just 'buffer', as there is no longer a distinction between binary
and text buffers
2000-06-06 17:47:54 +00:00
Andreas Gustafsson ad7209ea70 style, no functional change 2000-06-06 17:43:21 +00:00
David Lawrence bb808665b4 removed unused stack variable "ctx" from dnssafersa_verify() 2000-06-06 16:35:59 +00:00
David Lawrence fccbca2cdf style lint; macro parameter names are lowercase 2000-06-06 15:23:26 +00:00
David Lawrence 9e532f8f5e use ISC_TF to assign an isc_boolean_t 2000-06-06 15:21:46 +00:00
David Lawrence febb976e2e dnssafersa_verify() was failing because it used isc_buffer_used() where it
needed isc_buffer_base().
2000-06-06 15:16:45 +00:00
James Brister 616c83b78b temporarily disable code that validates listen-on and listen-on-v6 lists. 2000-06-06 14:20:03 +00:00
Mark Andrews 7ed73313b1 Add function to determine whether a given request used TCP or not. 2000-06-06 02:07:13 +00:00
Mark Andrews ba6f0d85b4 Add macro to initalise the common part of a rdata struct. 2000-06-06 02:03:23 +00:00
Mark Andrews d2b5fe92a4 Generate dependancies for dot 'h' files made by gen. 2000-06-06 02:01:41 +00:00
Andreas Gustafsson 9c11326b18 237. [bug] If connect() returned ENOBUFS when the resolver was
initiating a TCP query, the socket didn't get destroyed,
                        and the server did not shut down cleanly.  [RT #107]
2000-06-05 22:31:54 +00:00
David Lawrence b1a8714e07 cast void *isc_buffer_used() to char * for pointer arithmetic 2000-06-05 22:20:04 +00:00
James Brister c78dc8b001 Added new listen-on-v6 config file statement.
Consider it a config file error if a listen-on statement has an IPv6
address in it, or a listen-on-v6 statement has an IPv4 address in it.
2000-06-05 22:08:50 +00:00
Andreas Gustafsson abf2e095fb config code now guarantees that port number is set in the
also-notify list
2000-06-05 21:54:28 +00:00
James Brister d5399cc351 Allow a trusted-key's first field (domain-name) be either a quoted or
an unquoted string, instead of requiring a quoted string.
2000-06-05 20:32:01 +00:00
Brian Wellington b70f6ae9d0 missing call to dst_context_destroy 2000-06-05 20:01:07 +00:00
Brian Wellington b15d35d4e6 use the dst md5 layer instead of openssl md5, replace verify with sign & compare 2000-06-05 19:10:58 +00:00
Brian Wellington 9ee00c4fa0 use the dst md5 layer instead of dnssafe md5 2000-06-05 19:10:27 +00:00
Andreas Gustafsson f1f2f8bd47 Wired up the new 'port' option. Also, the interface manager now has
both a 'listen-on' and a 'listen-on-v6' ACL.  We are still waiting for
the 'listen-on-v6' config file option to set the latter explicitly,
but at least the default value now tracks the 'port' option and the
'-p' command line option.
2000-06-05 19:10:13 +00:00
James Brister 029f5aa861 Conversion of various config file values to isc_uint32_t. 2000-06-05 09:17:14 +00:00
Mark Andrews ac3b769801 232. [bug] Allow slave zones to not have a file. 2000-06-05 03:44:17 +00:00
James Brister 69b691c962 Support new 'port' clause in config file options section. Causes
'listen-on', 'masters' and 'also-notify' statements to use its value
instead of default (53).
2000-06-04 19:51:22 +00:00
Brian Wellington aeca99a602 Don't dereference a pointer before assigning it. 2000-06-03 00:43:46 +00:00
Brian Wellington e27021ee1f Certain negative responses could crash the validator.
The insecurity proof code didn't check to see if the name was below a security
root.
2000-06-03 00:18:43 +00:00
Brian Wellington e8325473bc typos 2000-06-02 23:44:52 +00:00
Andreas Gustafsson f266030dc3 RT #129: the journalling code assumed (and indeed INSISTed) that the
in-core and on-disk representations of a journal file offset be the same size.
This restriction has now been lifted.
2000-06-02 23:43:17 +00:00
Brian Wellington 182706b2e9 more dst updates 2000-06-02 23:36:14 +00:00
Brian Wellington 4fe8755480 Use the new DST API 2000-06-02 18:59:33 +00:00
Brian Wellington 011463c376 New DST API for signing/verifying, as well as some reorganization, cleanup,
and bug fixes.
2000-06-02 18:57:51 +00:00
Andreas Gustafsson 11d0a4a55e wired up the sig-validity-interval option; renamed its
access functions in the config code to be consistent with the option name
2000-06-02 17:31:43 +00:00
James Brister 98c2f9a111 Support config file trusted-keys and also-notify statemenets in views.
Support config file sig-validity-interval statement in options, views
and zone statements (master zones only).

Logging messages in config module stripped of trailing period.
2000-06-02 15:12:36 +00:00
David Lawrence f8faa9fe09 my last revision created a dns_rdataclass_* enum that had a comma after the
last idenfier, and IRIX whined about it.  Repeatedly.  Sigh.
2000-06-02 03:26:17 +00:00
David Lawrence 97741ef83e ndata and offsets for dns_rootname and dns_wildcardname need to be
unsigned char * (not char *) to match the ndata and offsets in dns_name_t.
2000-06-02 03:18:12 +00:00
David Lawrence 1c70c5ee90 227. [cleanup] The enumerated identifiers dns_rdataclass_*,
dns_rcode_*, dns_opcode_*, and dns_trust_* are
                        also now cast to their appropriate types.
2000-06-02 01:07:05 +00:00
Andreas Gustafsson 3755da41db reformatting; no functional change 2000-06-02 00:20:46 +00:00
Andreas Gustafsson c7298a2f0e dns_name_totext() now always prints the root name as '.',
even when omit_final_dot is true
2000-06-02 00:19:37 +00:00
Andreas Gustafsson a3c0a79b61 dns_name_totext() now always prints the root name as '.',
even when omit_final_dot is true
2000-06-02 00:14:02 +00:00
Andreas Gustafsson 8edbb66acd #include <errno.h> no longer needed now that we use isc_file_* 2000-06-02 00:05:30 +00:00
Andreas Gustafsson 658dc22047 no need to check for a port number of zero in master addresses as
the configuration code now guarantees that the port numbers have been
set in the masters list
2000-06-01 23:17:46 +00:00
Andreas Gustafsson a892ddd1bd changed the zone type of the version.bind. CH zone from 'none'
to 'master', as the semantics of zones of type 'none' are not well defined.
Allow zone->dbname to be NULL to support this usage.
2000-06-01 23:11:26 +00:00
Andreas Gustafsson b3352f568a removed outdated comment 2000-06-01 22:34:03 +00:00
Andreas Gustafsson 11a91ac55e call isc_task_setname() on the dispatch tasks 2000-06-01 22:00:09 +00:00
David Lawrence 0b056755b2 225. [cleanup] The enumerated dns_rdatatype_* identifiers are now
cast to dns_rdatatype_t via macros of their same name
                        so that they are of the proper integral type wherever
                        a dns_rdatatype_t is needed.

(And a few prototypes that I recently bogusly changed to take "int" parameters
in place of "dns_rdatatype_t" to accomodate the type of an enum identifier
have been reverted to again properly take a dns_rdatatype_t.)
2000-06-01 21:42:42 +00:00
David Lawrence 6d12fdf966 Megacommit of many files.
Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const.  Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.

The macro DE_CONST is used to deal with a handful of very special
places where something is qualified as const but really needs to have
its const qualifier removed.

rdata.c now defines macros for the prototypes of the basic rdata functions,
and all of the lib/dns/rdata/**/*.c files now use them.

Some minor integer-compatibility issues.  (IE, ~0x03 is a signed int,
so assigning it to an unsigned int should use a cast.  The type of an
enum member is int, so there are some conversion issues there, too.)

A pointers-to-function should not be cast to a pointer-to-object.

Variables should not be named for C reserved identifiers.

One or two set-but-not-used variables removed.

Minor other ISC style cleanups.
2000-06-01 18:26:56 +00:00