Brian Wellington
a49acbf201
Store tsig keys in an rbt, not a list.
2000-07-21 20:53:59 +00:00
Michael Sawyer
b6e3718b20
Should really allocate memory before trying to use it.
2000-07-21 20:51:44 +00:00
Andreas Gustafsson
e30c4dbe6f
typos
2000-07-21 20:37:01 +00:00
Brian Wellington
84a47e20ae
If the request was signed with a tsig key, verify the signature on the
...
response.
2000-07-21 20:33:13 +00:00
Brian Wellington
4be64854b4
The wrong name was being duped when a tsig key was generated using tkey.
2000-07-21 20:32:12 +00:00
Michael Sawyer
5813d091e9
Spacing changes
...
replace memset with slightly more portable NULL initialization
properly NULL masterkeynames when zone is created
2000-07-21 20:10:03 +00:00
Michael Sawyer
9b72c4648f
Internal code for masters with key entries. Not wired into config yet.
2000-07-21 18:47:23 +00:00
Brian Wellington
d6e6858bb9
If dns_request_getresponse() fails, log it.
2000-07-20 19:34:16 +00:00
Brian Wellington
a5e73f3e9d
Having a non-noerror value inn the tsig error field should always return
...
DNS_R_TSIGERRORSET in dns_tsig_verify. Change the result text to reflect
this.
2000-07-20 19:32:57 +00:00
Andreas Gustafsson
b7ebc6a127
minor tweak to hash function of previous change
2000-07-20 01:15:25 +00:00
Andreas Gustafsson
f969863d54
replaced the hash function in dns_name_hash() by one
...
that is simpler, faster, and produces a much more even distribution,
particularly when the data to hash ends with a null byte like domain
names often do
2000-07-20 01:14:48 +00:00
Andreas Gustafsson
99eba32b06
Removed the code added in revision 1.57:
...
"Store CNAMEs and their SIGs (if any) in their own name structure on
the name list. I.e. do not mix CNAMEs with non-CNAME data. Do the
same thing for DNAMEs."
because it caused DNSSEC validation of responses to ANY queries at
nodes with CNAME records to fail, and no one was able to figure out
why it was added in the first place. As a beneficial side effect,
findname() now finds names even if they have attribute bits set
differently from the one being searched for. This supersedes
the fix of revision 1.133.
2000-07-20 00:05:32 +00:00
Andreas Gustafsson
aa5940281a
When handling the response to an ANY query in a secure zone, deal with
...
the multiple answer RRsets by validating each one separately. Also,
eliminated the "done" variable in answer_response() because in the
rare situations where it got set to ISC_TRUE, it caused the function
to return prematurely by exiting a loop with a result of ISC_R_SUCCESS
and hitting a "if (result != ISC_R_NOMORE) return (result);" test
immediately following following the loop.
This should fix [RT #109 ], "ANY query in secure zone crashes server".
2000-07-19 23:19:05 +00:00
Brian Wellington
209ec709f3
Use the isc hmac library instead of a separate implementation (not that
...
the separate implementation was especially complicated). dst hmac-md5 should
really go away at some point.
2000-07-18 18:15:27 +00:00
James Brister
4ca8537286
Removed some debugging cruft.
...
Fixed handling of octal/hexadecimal numbers on input.
2000-07-18 13:19:27 +00:00
Brian Wellington
9df7d74e42
Use isc_base64_decodestring() instead of an explicit lexer.
2000-07-18 01:14:17 +00:00
Brian Wellington
49c8a96fba
Don't require that tsig keys must be on a keyring. Also some other cleanup.
2000-07-18 00:46:03 +00:00
Brian Wellington
7a184cd4e5
don't copy a name structure, copy a pointer.
2000-07-18 00:44:52 +00:00
Brian Wellington
f6579931b3
Added calls to isc_log_wouldlog() in additional logging functions.
2000-07-17 23:25:35 +00:00
Brian Wellington
9c4cba349f
334. [func] Added hmac-md5 to libisc.
2000-07-17 17:33:39 +00:00
Andreas Gustafsson
0e65062acb
strengthened the check added in the previous change:
...
the new query domain must not only be a non-child of the query name,
it must be a parent of the query name (or equal to the query name)
2000-07-16 18:26:18 +00:00
Andreas Gustafsson
64024eaa4d
333. [bug] The resolver incorrectly accepted referrals to
...
subdomains of the query domain, causing an
assertion failure.
2000-07-15 01:02:25 +00:00
David Lawrence
891a1bead8
Use new function dns_name_reset() to make a name have no data, instead
...
of dns_name_concatenate(NULL, NULL, name, NULL).
Define DNS_NAME_USELINE to get macroized name functions. Removed
older FAST_COUNTLABELS and FAST_ISABSOLUTE to use standard name
interface, which are covered by DNS_NAME_USEINLINE.
2000-07-14 19:17:39 +00:00
David Lawrence
da527e4ff6
332. [func] New function dns_name_reset().
2000-07-14 19:12:54 +00:00
Brian Wellington
da892e9733
Typo in comment - isc_time_microdiff returns microseconds, not milliseconds.
2000-07-14 16:59:32 +00:00
Andreas Gustafsson
10f4e9668a
the INSIST condition of 1.145 was too strong, weakened it;
...
dded another INSIST to help track down the INSIST(!external) crash
2000-07-14 00:37:27 +00:00
Andreas Gustafsson
55da37e18f
removed dead code
2000-07-14 00:33:09 +00:00
Brian Wellington
6bc1a64561
If a positive validation fails and it looks like the reason is that there
...
are no material DNSSEC signatures, try an insecurity proof.
2000-07-13 23:52:04 +00:00
Brian Wellington
4250285838
Return DNS_R_NAMETOOLONG in a few places where less useful errors were
...
returned before.
2000-07-13 18:10:18 +00:00
Brian Wellington
618e871c2e
Add DNS_R_NAMETOOLONG
2000-07-13 02:41:20 +00:00
Andreas Gustafsson
4532e9e7c6
in isc_log_wouldlog(), deal with the possibility of lctx
...
being NULL
2000-07-13 02:28:18 +00:00
Andreas Gustafsson
0072e42780
use isc_log_wouldlog() in manager_log()
2000-07-13 01:38:40 +00:00
Brian Wellington
2935e25e99
Removed debugging code that is no longer useful.
2000-07-13 01:22:56 +00:00
Andreas Gustafsson
9317787889
use isc_log_wouldlog()
2000-07-13 01:16:22 +00:00
Brian Wellington
febc974d0f
Use isc_log_wouldlog() to avoid calling strerror() whenever possible.
2000-07-13 01:13:53 +00:00
Brian Wellington
2e1236ad1e
Call isc_log_wouldlog()
2000-07-13 00:30:58 +00:00
Brian Wellington
945c32833b
Call isc_log_wouldlog() in a few places.
2000-07-13 00:27:17 +00:00
Andreas Gustafsson
211ac47e07
use isc_log_wouldlog() to avoid unnecessary formatting work
...
when the debug level does not warrant logging
2000-07-13 00:25:38 +00:00
Andreas Gustafsson
30576c592b
330. [func] New function isc_log_wouldlog().
2000-07-13 00:19:02 +00:00
Brian Wellington
ecb2897c71
Insist that when a fetch returns a successful event, the rdataset is associated.
...
A test failed about a week ago because this was not true, and because it
died in the event handler, diagnosing the problem was impossible.
2000-07-12 23:56:06 +00:00
Andreas Gustafsson
2c24bbb10b
clarified warning messages
2000-07-12 16:17:38 +00:00
James Brister
8af589aea3
It's no longer a fatal error if a keys{} clause is missing on a control
...
channel definition, nor if the keys{} clause is empty. Warnings are
issued.
2000-07-12 15:36:09 +00:00
Brian Wellington
a6f31a3fd0
Only install default handlers for SIGTERM and SIGWAIT if we haven't installed
...
other handlers already.
2000-07-12 01:46:57 +00:00
Andreas Gustafsson
403cc93b27
typo in log message
2000-07-11 22:44:33 +00:00
David Lawrence
ce2be9b721
329. [func] omapi_auth_register() now takes a size_t argument for
...
the length of a key's secret data. Previously
OMAPI only stored secrets up to the first NUL byte.
This change was made to cope with decoded base64 secrets, so in this
revision omapiconf.c and rndc.c also decode the secret.
2000-07-11 22:03:12 +00:00
David Lawrence
9bf765ab3a
328. [func] Added isc_base64_decodestring().
...
(This is basically bin/named/server.c:base64_cstring_tobuffer(), which I
will remove in another revision that will not need to be pulled up. I also
would like to change isc_base64_totext() and isc_base64_tobuffer() to be
isc_base64_encoderegion() and isc_base64_decodelexer(), unless there are
exceptions. I find their existing names to be quite confusing with regard to
what translation function each performs.)
2000-07-11 21:51:13 +00:00
James Brister
f4d9f465cd
327. [bug] rndc.conf parser wasn't correctly recognising an IP
...
address where a host specification was required.
2000-07-11 20:13:09 +00:00
Brian Wellington
838f13fbdc
Set default signal handlers for SIGINT and SIGTERM (SIGHUP already had one).
...
This doesn't appear to have an effect on any platform, but it seems like a
good idea.
2000-07-11 19:18:05 +00:00
James Brister
adade77942
326. [func] 'keys' in an 'inet' control statement is now
...
required and must have at least one item in it.
warning is issued if a 'unix' control channel is
defined (not supported).
2000-07-11 19:09:10 +00:00
Mark Andrews
5c0a406664
325. [bug] isc_lex_gettoken was processing octal strings when
...
ISC_LEXOPT_CNUMBER was not set.
2000-07-11 02:44:54 +00:00