Evan Hunt
7ec945bd41
convert parser_test; remove ATF from lib/isccfg/tests
2018-11-14 20:17:04 -08:00
Evan Hunt
d8766293ab
assert if {isc,dns,ns}_test_begin() is called when a prior test is running
2018-11-14 20:17:04 -08:00
Evan Hunt
b434b0a4b6
remove .NOTPARALLEL so unit tests can build faster
2018-11-14 20:17:04 -08:00
Evan Hunt
2afd18a2ce
add cmocka support to remaining unit test makefiles
...
- also cleaned up some existing test code
2018-11-14 20:17:04 -08:00
Evan Hunt
f456e64736
set HAVE_CMOCKA correctly when using --with-cmocka=yes
...
(note: this is still broken if using --with-cmocka=path)
2018-11-14 20:17:04 -08:00
Ondřej Surý
c38b145b89
Remove OPENSSL_cleanup() call as we cannot recover from that, it will be called via atexit mechanism automatically
2018-11-14 20:17:04 -08:00
Ondřej Surý
de6f43d071
Use static assertion to check for correct alignment size
2018-11-14 18:18:27 -05:00
Ondřej Surý
5e44a1008f
Define STATIC_ASSERT(cond, msg) to be _Static_assert(cond, msg) everywhere but on Windows where it stays to be INSIST(cond)
2018-11-14 18:18:27 -05:00
Mark Andrews
4eadebe2b2
uninitalize memory read on error path
2018-11-14 15:26:27 -05:00
Mark Andrews
93776c4c81
errors initalizing badcaches were not caught or cleaned up on error paths
2018-11-14 15:26:27 -05:00
Witold Kręcicki
9c8fead6d8
qname minimization: issue a warning only if the server is really broken
2018-11-14 19:55:10 +00:00
Mark Andrews
50714a9b35
free tmpzonename and restart_master
2018-11-14 11:23:21 -08:00
Mark Andrews
333f718dd3
don't use 'typename' as it is reserved in C++
2018-11-14 13:45:20 -05:00
Ondřej Surý
e9a939841d
Add min-cache-ttl and min-ncache-ttl keywords
...
Sometimes it is useful to set a 'floor' on the TTL for records
to be cached. Some sites like to use ridiculously low TTLs for
some reason, and that often is not compatible with slow links.
Signed-off-by: Michael Milligan <milli@acmeps.com >
Signed-off-by: LaMont Jones <lamont@debian.org >
2018-11-14 18:24:53 +01:00
Mark Andrews
9024cf0c15
remove lib/isc/tests/result_test as it is now cmocka
2018-11-13 07:26:29 +11:00
Mark Andrews
9a59352b4c
link in lib/isccc/tests/Kyuafile
2018-11-13 07:23:36 +11:00
Evan Hunt
471110933a
convert result tests to use CMocka instead of ATF
2018-11-10 12:29:40 -08:00
Mark Andrews
4f04a79250
check result tables are complete
2018-11-10 10:30:43 +11:00
Mark Andrews
6ead8c7be8
look in windows registry for nameservers, domainname and search list
2018-11-09 16:06:49 +11:00
Mark Andrews
28442f11f0
log RPZ type and class
2018-11-08 22:48:28 -05:00
Ondřej Surý
6f5fe11f5a
isc_stdtime_t is always 32-bit now, so remove the always true macro STDTIME_ON_32BITS
2018-11-09 02:27:06 +07:00
Ondřej Surý
68ca987792
Remove dummy ISLOCKED macro
2018-11-08 12:22:26 +07:00
Ondřej Surý
23fff6c569
Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached
2018-11-08 12:22:17 +07:00
Ondřej Surý
b992b5b811
Modify the dbversion_test.c to detect disabled assertions
2018-11-08 12:22:17 +07:00
Ondřej Surý
29c45200e7
Add extra return failure after INSIST(0) in default branch
2018-11-08 12:22:17 +07:00
Ondřej Surý
4eaf927571
Use larger buffers on snprintf buffer overflow false positives
2018-11-08 12:21:53 +07:00
Ondřej Surý
e2e138a801
Don't assert on failed getrlimit call to allow called to handle this gracefully as it already does, just abort where we need to know the numbers
2018-11-08 12:21:53 +07:00
Ondřej Surý
a831e0f72d
When ISC assertions are disabled, still execute the condition to prevent unused variable warnings/errors from the compiler
2018-11-08 12:21:53 +07:00
Ondřej Surý
b2b43fd235
Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool
2018-11-08 12:21:53 +07:00
Ondřej Surý
fbd2e47f51
Add small tweaks to the code to fix compilation when ISC assertions are disabled
...
While implementing the new unit testing framework cmocka, it was found that the
BIND 9 code doesn't compile when assertions are disabled or replaced with any
function (such as mock_assert() from cmocka unit testing framework) that's not
directly recognized as assertion by the compiler.
This made the compiler to complain about blocks of code that was recognized as
unreachable before, but now it isn't.
The changes in this commit include:
* assigns default values to couple of local variables,
* moves some return statements around INSIST assertions,
* adds __builtin_unreachable(); annotations after some INSIST assertions,
* fixes one broken assertion (= instead of ==)
2018-11-08 12:21:53 +07:00
Witold Kręcicki
ce478b4fc9
Fix a typo in lib/isc/unix/thread.c
2018-11-07 19:31:06 +00:00
Witold Kręcicki
9a903789ed
Use larger quantum for network tasks
2018-11-06 08:19:50 +00:00
Witold Kręcicki
460c8038c1
Use a single wake_all_queues() function to wake all queues
2018-11-06 08:19:50 +00:00
Witold Kręcicki
b3827319e0
Switch from privileged to un-privileged mode under lock
2018-11-06 08:19:50 +00:00
Witold Kręcicki
f166cabcae
Document isc_task_sendto properly, make sure that cpu we're sending to is always sane
2018-11-06 08:19:50 +00:00
Witold Kręcicki
025c74adee
Use proper memory ordering for tasks_running/tasks_ready
2018-11-06 08:19:50 +00:00
Witold Kręcicki
8fb5bc783f
Comment about taskmgr exclusive mode, fix a REQUIRE.
2018-11-06 08:19:50 +00:00
Witold Kręcicki
913856911a
Saner exclusive task handling in taskmgr
2018-11-06 08:19:50 +00:00
Witold Kręcicki
17d46fd48b
Formatting
2018-11-06 08:19:50 +00:00
Witold Kręcicki
c80e25e482
Get rid of isc_taskmgr_setmode, we only use it to set privileged mode
2018-11-06 08:19:50 +00:00
Witold Kręcicki
64020dd7bc
Make sure all priority tasks are done before entering normal execution
2018-11-06 08:19:50 +00:00
Witold Kręcicki
669a694d3b
Post shutting down tasks always to manager 0
2018-11-06 08:19:50 +00:00
Witold Kręcicki
c416389d32
Separate structure for each thread/queue; 2-phase-locking for exclusive tasks
2018-11-06 08:19:50 +00:00
Witold Kręcicki
818d63a3a1
Always restart dispatchers on empty readyq
2018-11-06 08:19:50 +00:00
Witold Kręcicki
d7be8afea5
Taskmgr shutdown fixes
2018-11-06 08:19:50 +00:00
Witold Kręcicki
81a85070c5
Multiple worker queues
2018-11-06 08:19:50 +00:00
Witold Krecicki
7b6721b27f
isc_thread_setaffinity()
2018-11-06 08:19:50 +00:00
Tony Finch
1b1d63acd8
Fixes for rndc nta user interface
...
Tell the user explicitly about their mistakes:
* Unknown options, e.g. -list instead of -dump
or -delete instead of -remove.
* Unknown view names.
* Excess arguments.
Include the view name in `rndc nta -dump` output, for consistency with
the NTA add and remove actions.
When removing an NTA from all views, do not abort with an error if the
NTA was not found in one of the views.
2018-11-05 22:01:28 -08:00
Tony Finch
3064d3d0ef
Abolish ip6.int support in dig and mdig
2018-11-05 19:07:31 -05:00
Mark Andrews
d6f6eeda9d
check requireservercookie even if rrl is configured
2018-11-06 10:10:04 +11:00