Commit Graph
250 Commits
Author SHA1 Message Date
Mark Andrews f3352b9bec compare: a REQUIRE() was comparing a variable against itself not agaist the
other arguement as it should have been.
2001-09-10 23:47:26 +00:00
Mark Andrews c38b92000c 947. [bug] dns_rdata_soa_t had a badly name element "mname" which
was really the RNAME field from RFC1035.  To avoid
                        confusion and silent errors that would occur it ther
                        "origin" and "mname" elements were given their correct
                        names "mname" and "rname" respectively, the "mname"
                        element is renamed to "contact".
2001-07-30 01:09:14 +00:00
Andreas Gustafsson 90e289c59f A6 has an RFC now 2001-07-26 21:34:02 +00:00
Mark Andrews bddfe77128 936. [func] Warn when non dotted decimal quad's are used.
[RT #1084]

 935.   [bug]           inet_pton failed to reject leading zeros.
2001-07-16 03:06:53 +00:00
Mark Andrews 85bdc128fc Relax REQUIRES() in *fromstruct() and unconditionally call
mem_maybedup() in *tostruct().
TXT is one or more (not zero or more) strings.
2001-06-21 04:00:47 +00:00
Andreas Gustafsson 08a44b06ef the length of the NULL record RDATA can be zero;
do not assert the contrary
2001-06-20 17:43:31 +00:00
Andreas Gustafsson 9762fd29cc DNAME now has an RFC 2001-04-27 21:02:01 +00:00
Brian Wellington caa55a6557 When printing KEY records with COMMENT and MULTILINE, the line would often
be too long.
2001-03-28 02:57:26 +00:00
Brian Wellington ae114ded82 Fix a bunch of unused variable warnings that only occurred with assertions
turned off.
2001-03-16 22:53:20 +00:00
Mark Andrews 9ac7076eba 769. [func] Improved error reporting when parsing rdata. [RT #740]
Two new error codes.  Also push back the last token, if it makes
sense to do so, so that it gets printed in the error message using
RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
Brian Wellington cdc50af0bf In the towire_* and additionaldata_* routines, add an offsets table to names
passed into dns_name_toregion().  This is effectively free, and reduces the
number of calls to set_offsets() and dns_name_clone() in name compression.
2001-02-12 03:05:05 +00:00
Brian Wellington 330705066b Wrap inet_ntop() and use that in the _totext() functions. The wrapper calls
inet_ntop() and copies the output (but not the trailing null) into the buffer.
2001-01-25 20:14:42 +00:00
Brian Wellington 2a006fffe4 our NAPTR implementation does conform to RFC 2915. 2001-01-18 22:05:41 +00:00
Brian Wellington cb2ad98ea4 make prefixlen an isc_uint8_t [RT #658] 2001-01-17 02:54:17 +00:00
Mark Andrews 7dbb39a417 680. [bug] dns_rdata_fromstruct() mis-handles options bigger
than 255 octets.
2001-01-16 06:14:00 +00:00
Brian Wellington e5fb13fb23 The asserts in fromstruct were too strong - it's possible to have a non-NULL
key and keylen == 0 if the pointer is to a 0 byte allocation.
2001-01-11 03:11:30 +00:00
Brian Wellington 499b34cea0 copyright update 2001-01-09 22:01:04 +00:00
Andreas Gustafsson 63cef8bde8 added UNUSED() macros for arguments that end up unused when assertion checking
is turned off
2000-12-01 01:40:59 +00:00
Andreas Gustafsson daf99720c9 the existence of a dynamically allocated array for the NXT
bits should not depend on its length
2000-11-14 18:14:44 +00:00
Brian Wellington add4043305 The identical gettoken() routines in rdata.c, hex.c, and base64.c have
been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
Brian Wellington 0a6ddf7b82 A typo caused null keys to be printed incorrectly. 2000-10-31 20:12:32 +00:00
Mark Andrews b589e90689 Remove the rdata->length == 0 checks, UPDATE pseudo rdata are now tagged.
Add sanity checks to rdata types where the length cannot legally be zero.
2000-10-25 05:44:10 +00:00
Brian Wellington e484f9de4f The nxt structure was basically useless. 2000-10-06 22:41:16 +00:00
Brian Wellington 8c7fa43b3c Make dst_region_computeid() take an algorithm, since it was returning the
wrong id for RSA keys.  Also clean up a few error messages from dst routines.
2000-09-08 14:23:49 +00:00
Brian Wellington 37a8fbab3a 411. [bug] A typo in the HS A code caused an assertion failure. 2000-08-28 17:39:21 +00:00
Andreas Gustafsson 9f139761ca don't use parentheses in the text representation of RRs unless
we are in multiline mode; this ensures that the output can be re-parsed with
dns_rdata_fromtext
2000-08-24 21:41:44 +00:00
Brian Wellington 9ce72fc748 don't print parens at all if in non-multiline mode. 2000-08-22 22:07:13 +00:00
Brian Wellington 2f507825cf _tostruct had a few typos. 2000-08-10 01:59:39 +00:00
Andreas Gustafsson efadda9a7b added UNUSED() macros to suppress compiler warnings when
compiling with assertion checking turned off
2000-08-08 23:40:46 +00:00
David Lawrence 40f53fa8d9 Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your
own CVS tree will help minimize CVS conflicts.  Maybe not.
Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
David Lawrence 23b251fbf2 needs <dns/name.h> for dns_name_t 2000-07-31 20:57:06 +00:00
Brian Wellington 0e93f65e10 Print the key id when DNS_STYLEFLAG_COMMENT is passed to _totext() 2000-07-31 19:47:21 +00:00
Brian Wellington 2b518b5fb4 fixedname.h is not needed 2000-07-31 19:40:52 +00:00
David Lawrence 15a4474541 word wrap copyright notice at column 70 2000-07-27 09:55:03 +00:00
David Lawrence 5eae30a019 in fact, ISC_LANG_BEGINDECLS and ISC_LANG_ENDDECLS are not needed at all since
rdatastructpre.h and rdatastructsuf.h already provide the wrapper.
(no need to pull up.)
2000-06-28 19:07:19 +00:00
David Lawrence 778d24f5ba do not include isc/lang.h; rdatastructpre.h already gets it.
no need to pull these changes up to the 9.0.0 branch.
2000-06-28 19:03:24 +00:00
David Lawrence 9c3531d72a add RCS id string 2000-06-22 22:00:42 +00:00
David Lawrence 28d9fd5381 update_copyrights 2000-06-21 22:45:24 +00:00
Andreas Gustafsson 12dd8db40b don't indent comments by one space 2000-06-16 21:45:51 +00:00
David Lawrence 003a40178f make DNS_RDATACOMMON_INIT work again. structure elemnts had the same name as
the downcased macro argument names
2000-06-07 00:11:51 +00:00
David Lawrence fccbca2cdf style lint; macro parameter names are lowercase 2000-06-06 15:23:26 +00:00
Mark Andrews ba6f0d85b4 Add macro to initalise the common part of a rdata struct. 2000-06-06 02:03:23 +00:00
David Lawrence 6d12fdf966 Megacommit of many files.
Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const.  Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.

The macro DE_CONST is used to deal with a handful of very special
places where something is qualified as const but really needs to have
its const qualifier removed.

rdata.c now defines macros for the prototypes of the basic rdata functions,
and all of the lib/dns/rdata/**/*.c files now use them.

Some minor integer-compatibility issues.  (IE, ~0x03 is a signed int,
so assigning it to an unsigned int should use a cast.  The type of an
enum member is int, so there are some conversion issues there, too.)

A pointers-to-function should not be cast to a pointer-to-object.

Variables should not be named for C reserved identifiers.

One or two set-but-not-used variables removed.

Minor other ISC style cleanups.
2000-06-01 18:26:56 +00:00
Andreas Gustafsson fd6de7af32 refer to RFC2845, not draft-ietf-dnsext-tsig-00.txt 2000-06-01 16:47:26 +00:00
Brian Wellington 5d83b561ad Added dns_tsigrcode_totext/fromtext 2000-05-25 00:46:32 +00:00
David Lawrence ed019cabc1 fixed lines > 79 columns wide 2000-05-24 05:10:00 +00:00
Andreas Gustafsson 1ac4b2a1da when printing a SIG record with covers==0, print it as 0,
not RESERVED0
2000-05-22 21:42:47 +00:00
Mark Andrews 373ce67419 Implement dns_rdata_fromstruct() where not already done.
Add missing REQUIRE tests to existing implementations.
2000-05-22 12:38:12 +00:00
Mark Andrews 389e24909e return ISC_R_SUCCESS from tostruct(). 2000-05-19 13:28:36 +00:00
Mark Andrews a2b5255212 remove INSIST(ISC_FALSE) from freestruct(). 2000-05-19 13:27:45 +00:00