cast to dns_rdatatype_t via macros of their same name
so that they are of the proper integral type wherever
a dns_rdatatype_t is needed.
(And a few prototypes that I recently bogusly changed to take "int" parameters
in place of "dns_rdatatype_t" to accomodate the type of an enum identifier
have been reverted to again properly take a dns_rdatatype_t.)
Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const. Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.
The macro DE_CONST is used to deal with a handful of very special
places where something is qualified as const but really needs to have
its const qualifier removed.
rdata.c now defines macros for the prototypes of the basic rdata functions,
and all of the lib/dns/rdata/**/*.c files now use them.
Some minor integer-compatibility issues. (IE, ~0x03 is a signed int,
so assigning it to an unsigned int should use a cast. The type of an
enum member is int, so there are some conversion issues there, too.)
A pointers-to-function should not be cast to a pointer-to-object.
Variables should not be named for C reserved identifiers.
One or two set-but-not-used variables removed.
Minor other ISC style cleanups.
the message "in6_addr.s6_addr is *always* an array" (been there, done that)
is actually useful to just rebuild the include/dns/*.h files which
"gen" generates ... if only the rule had a backslash, so that
include/dns/rdatastruct.h was recognized as a dependent rather than
the command to execute. now it does.
isc_buffer_remaininglength of 0. this finds problems like isc_buffer_init
not followed by isc_buffer_add much sooner.
also, enforce the already documented contract requirements of needing
a valid source buffer and either a valid target buffer or a name
with a dedicated buffer.
- Eliminated massive code duplication
- Eliminated code for configuring forward and hint "zones",
as those no longer have zone objects. Left stub zones in
because those probably will have zone objects associated
with them.
- Fixed several bugs:
+ 'allow-transfer' was not obeyed for slave zones or stub zones
+ 'dialup' was not obeyed for stub zones
+ 'transfers-per-ns' was not obeyed for any zones
there are no major fixes in here but couple of bug fixes that
may affect operation in some cases. I updated rename.h to
make sure all symbols with T have dst__openssl prefix.
Any bugs found in this source code should be reported to the
openssl people.
Olafur
