Commit Graph
246 Commits
Author SHA1 Message Date
Witold Kręcicki 929ea7c2c4 - Make isc_mutex_destroy return void
- Make isc_mutexblock_init/destroy return void
- Minor cleanups
2018-11-22 11:52:08 +00:00
Ondřej SurýandWitold Kręcicki 2f3eee5a4f isc_mutex_init returns 'void' 2018-11-22 11:51:49 +00:00
Mark AndrewsandEvan Hunt 333f718dd3 don't use 'typename' as it is reserved in C++ 2018-11-14 13:45:20 -05:00
Ondřej Surý b2b43fd235 Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool 2018-11-08 12:21:53 +07:00
Ondřej Surý fbd2e47f51 Add small tweaks to the code to fix compilation when ISC assertions are disabled
While implementing the new unit testing framework cmocka, it was found that the
BIND 9 code doesn't compile when assertions are disabled or replaced with any
function (such as mock_assert() from cmocka unit testing framework) that's not
directly recognized as assertion by the compiler.

This made the compiler to complain about blocks of code that was recognized as
unreachable before, but now it isn't.

The changes in this commit include:

* assigns default values to couple of local variables,
* moves some return statements around INSIST assertions,
* adds __builtin_unreachable(); annotations after some INSIST assertions,
* fixes one broken assertion (= instead of ==)
2018-11-08 12:21:53 +07:00
Mark Andrews 0fc1b1bffa improve case presevation 2018-10-02 15:09:32 +10:00
Ondřej Surý 994e656977 Replace custom isc_boolean_t with C standard bool type 2018-08-08 09:37:30 +02:00
Ondřej Surý cb6a185c69 Replace custom isc_u?intNN_t types with C99 u?intNN_t types 2018-08-08 09:37:28 +02:00
Mark Andrews cb5802e854 work around cppcheck false positive 2018-05-29 09:28:30 +10:00
Evan Hunt e00eb55cd2 silence warnings about unnecessary comparisons
- these are cases where result has been explicitly set, so
  if (result != ISC_R_SUCCESS) is unnecessary
2018-04-20 19:51:00 -04:00
Michał KępieńandOndřej Surý 4df4a8e731 Use dns_fixedname_initname() where possible
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.

This patch was mostly prepared using Coccinelle and the following
semantic patch:

    @@
    expression fixedname, name;
    @@
    -	dns_fixedname_init(&fixedname);
    	...
    -	name = dns_fixedname_name(&fixedname);
    +	name = dns_fixedname_initname(&fixedname);

The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.

It is likely that more occurrences of this pattern can be refactored in
an identical way.  This commit only takes care of the low-hanging fruit.
2018-04-09 12:14:16 +02:00
Witold Kręcicki e2a06db7f3 libdns refactoring: get rid of multiple versions of dns_master_loadfile, dns_master_loadfileinc, dns_master_dump, dns_master_dumpinc, dns_master_dumptostream, dns_master_stylecreate 2018-04-06 08:04:41 +02:00
Ondřej SurýandMichał Kępień a11e23b5ed Replace all usage of inet_aton() with inet_pton() 2018-02-23 13:57:10 +01:00
Ondřej Surý 843d389661 Update license headers to not include years in copyright in all applicable files 2018-02-23 10:12:02 +01:00
Tinderbox User 3fda67b596 update copyright notice / whitespace 2018-01-22 23:46:02 +00:00
Mukund Sivaraman 8a4ce20172 Don't permit loading meta RR types such as TKEY from master files (#47009) 2018-01-22 14:26:04 +05:30
Mark Andrews 3d905e0533 4817. [cleanup] Use DNS_NAME_INITABSOLUTE and DNS_NAME_INITNONABSOLUTE.
[RT #45433]
2017-11-13 16:58:12 +11:00
Evan Hunt 114f95089c [master] cleanup strcat/strcpy
4722.	[cleanup]	Clean up uses of strcpy() and strcat() in favor of
			strlcpy() and strlcat() for safety. [RT #45981]
2017-09-13 00:14:37 -07:00
Mark Andrews df50751585 4700. [func] Serving of stale answers is now supported. This
allows named to provide stale cached answers when
                        the authoritative server is under attack.
                        See max-stale-ttl, stale-answer-enable,
                        stale-answer-ttl. [RT #44790]
2017-09-06 09:58:29 +10:00
Tinderbox User 9ab5ec1d72 update copyright notice / whitespace 2017-07-21 23:46:06 +00:00
Mark Andrews 4bf32aa587 4654. [cleanup] Don't use C++ keywords delete, new and namespace.
[RT #45538]
2017-07-21 11:52:24 +10:00
Mark Andrews 0c27b3fe77 4401. [misc] Change LICENSE to MPL 2.0. 2016-06-27 14:56:38 +10:00
Mark Andrews 7c52595464 4331. [func] When loading managed signed zones detect if the
RRSIG's inception time is in the future and regenerate
                        the RRSIG immediately. [RT #41808]
2016-03-10 17:01:08 +11:00
Mark Andrews f5e7794860 silence compiler warning
(cherry picked from commit 37a931d774)
2016-03-09 14:43:47 +11:00
Tinderbox User 7d4f45f6bd update copyright notice / whitespace 2016-01-21 23:45:23 +00:00
Mark Andrews 1d383fd4b2 4299. [bug] Check that exactly totallen bytes are read when
reading a RRset from raw files in both single read
                        and incremental modes. [RT #41402]
2016-01-21 15:33:08 +11:00
Mark Andrews 2a12984ce6 4227. [bug] Silence static analysis warnings. [RT #40828 2015-09-30 14:14:47 +10:00
Mark Andrews 705d56b47a 4216. [cleanup] Silence static analysis warnings. [RT #40649] 2015-09-18 23:30:01 +10:00
Mark Andrews 0f2ecf4b5c 4207. [bug] Handle class mismatches with raw zone files.
[RT #40746]
2015-09-16 10:43:22 +10:00
Mark Andrews 5855fd79e3 4191. [protocol] Accept DNS-SD non LDH PTR records in reverse zones
as per RFC 6763. [RT #37889]
2015-08-25 14:46:06 +10:00
Mark Andrews e53e202ef3 4128. [bug] Address issues raised by Coverity 7.6. [RT #39537] 2015-05-28 13:17:07 +10:00
Mark Andrews 29d52c001f 4081. [cleanup] Use dns_rdatalist_init consistently. [RT #38759] 2015-03-03 16:43:42 +11:00
Tinderbox User 651c5a50f4 update copyright notice / whitespace 2015-01-06 23:45:23 +00:00
Mark Andrews b0c18fffd3 4028. [bug] $GENERATE with a zero step was not being caught as a
error.  A $GENERATE with a / but no step was not being
                        caught as a error. [RT #38262]
2015-01-06 11:31:34 +11:00
Mark Andrews 2e98ab2c9d remove non null check 2014-12-09 19:51:32 +11:00
Mark Andrews 6444de08d1 4014. [bug] When including a master file origin_changed was
not being properly set leading to a potentially
                        spurious 'inherited owner' warning. [RT #37919]
2014-12-03 09:42:30 +11:00
Mark Andrews bbec761a67 silence compiler warning 2014-10-08 17:47:46 +11:00
Tinderbox User d1573beb05 update copyright notice 2014-10-04 23:45:22 +00:00
Mark Andrews c81d56c03e 3971. [bug] Reduce the cascasding failures due to a bad $TTL line
in named-checkconf / named-checkzone. [RT #37138]
2014-10-05 08:29:34 +11:00
Mark Andrews ed1c845c1d 3964. [func] nsupdate now performs check-names processing.
[RT #36266]
2014-10-02 09:35:43 +10:00
Mark Andrews 7cce33eb78 place a upper bound on rdcount 2014-06-04 13:20:42 +10:00
Mark Andrews 36e5ac0033 3819. [bug] NSEC3 hashes need to be able to be entered and
displayed without padding.  This is not a issue for
                        currently defined algorithms but may be for future
                        hash algorithms. [RT #27925]
2014-04-24 18:58:03 +10:00
Evan Hunt ffbd79e978 [master] fix possible uninitialized variable 2014-03-10 20:55:26 -07:00
Evan Hunt 7b46a4aa41 [master] fix negative numbers in $GENERATE
3780.	[bug]		$GENERATE handled negative numbers incorrectly.
			[RT #25528]
2014-03-10 11:55:32 -07:00
Mark Andrews e676a59686 update copyrights 2014-02-20 10:53:11 +11:00
Evan Hunt 35f6a21f5f [master] max-zone-ttl
3746.	[func]		New "max-zone-ttl" option enforces maximum
			TTLs for zones. If loading a zone containing a
			higher TTL, the load fails. DDNS updates with
			higher TTLs are accepted but the TTL is truncated.
			(Note: Currently supported for master zones only;
			inline-signing slaves will be added.) [RT #38405]
2014-02-18 23:26:50 -08:00
Mark Andrews c3c8823fed 3681. [port] Update the Windows build system to support feature
selection and WIN64 builds.  This is a work in
                        progress. [RT #34160]
2013-12-04 12:47:23 +11:00
Mark Andrews 0c91911b4d 3642. [func] Allow externally generated DNSKEY to be imported
into the DNSKEY management framework.  A new tool
                        dnssec-importkey is used to this. [RT #34698]
2013-09-04 13:53:02 +10:00
Evan Hunt b7e40659ef [master] rebuild resigning heaps when loading map files
3597.	[bug]		Ensure automatic-resigning heaps are reconstructed
			when loading zones in map format. [RT #33381]
2013-06-14 10:16:10 -07:00
Evan Hunt 03b5d2689d [master] add hash to map files
3562.	[func]		Update map file header format to include a SHA-1 hash
			of the database content, so that corrupted map files
			can be rejected at load time. [RT #32459]
2013-05-01 22:20:02 -07:00