Commit Graph
3008 Commits
Author SHA1 Message Date
Michał KępieńandMark Andrews 580fb63a68 Wait until a cache dump completes instead of waiting for a fixed amount of time
Dumping the cache is an asynchronous operation, so sleeping for a fixed
amount of time after running "rndc dumpdb" is imperfect as dumping cache
contents may take longer than expected on slower machines.  Instead of
always sleeping for 1 second, wait until the "; Dump complete" line
appears in the dump or 10 seconds pass, whichever comes first.

(cherry picked from commit 2bbff06d36)
(cherry picked from commit e617b91527)
2018-02-21 11:28:16 +11:00
Michał KępieńandMark Andrews 44e946e9e9 Do not overwrite cache dumps
Unless configured otherwise in named.conf, "rndc dumpdb" causes a cache
dump to be written to a file called "named_dump.db" in the working
directory of the given named instance.  Repeatedly using this command
throughout different checks in the cacheclean system test causes cache
dumps for older checks to be overwritten, which hinders failure
diagnosis.  Prevent this by moving each cache dump to a check-specific
location after running "rndc dumpdb".

Furthermore, during the "check flushtree clears adb correctly" check,
dump_cache() is called twice without renaming the resulting files.
Prevent the first cache dump from being overwritten by moving it to a
different file before calling "rndc dumpdb" for the second time.

(cherry picked from commit aeea1faf01)
(cherry picked from commit dcd91ab322)
2018-02-21 11:26:58 +11:00
Michał KępieńandMark Andrews 5c0afa76f7 Assign an index to each check in the cacheclean system test
This will enable storing per-check forensic data, which facilitates
troubleshooting test failures.

(cherry picked from commit 01de79b332)
(cherry picked from commit 7679819e15)
2018-02-21 10:52:43 +11:00
Mark Andrews 4404fcb384 return failure count 2018-02-16 18:42:11 +11:00
Mark Andrews 872543eca7 add brackets 2018-02-16 18:37:05 +11:00
Mark Andrews 5de799a1c8 reorder test to silence cppcheck 2018-02-16 18:37:05 +11:00
Mark Andrews 32166fae3b remove event which is only used for sizeof 2018-02-16 18:37:05 +11:00
Mark Andrews b7a4a93b0d use %u instead of %d 2018-02-16 18:17:59 +11:00
Mark Andrews b3d10f1a43 use %u instead of %d 2018-02-16 18:06:58 +11:00
Mark Andrews 62d579f152 use %u instead of %d 2018-02-16 18:05:01 +11:00
Mark Andrews 41ac666f4a use %u instead of %d 2018-02-16 18:04:27 +11:00
Mark Andrews 5c91a79de9 use %u instead of %d 2018-02-16 18:02:21 +11:00
Mark Andrews 3ddd77519d use %u instead of %d 2018-02-16 17:58:39 +11:00
Mark Andrews e3bc8bc293 use %u instead of %d 2018-02-16 17:53:13 +11:00
Mark Andrews 75691e0d90 use %u instead of %d 2018-02-16 17:53:13 +11:00
Mark Andrews 01fd4fcca2 use %u instead of %d 2018-02-16 17:51:07 +11:00
Mark Andrews a365729e6a make declarations consistent 2018-02-16 17:49:02 +11:00
Mark Andrews 5962de0c3e report argument error in human form 2018-02-16 17:49:02 +11:00
Mark Andrews 8498787e55 use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews 2194d8674b use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews faabe3071c use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews 028a719b2f use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews 5c28ae51c5 use %u instead of %d 2018-02-16 17:49:02 +11:00
Evan Hunt 950777feb8 [v9_9] copyrights 2018-02-10 16:32:35 -08:00
Mark Andrews c6cd108838 check warning text 2018-02-09 14:04:35 +11:00
Mark Andrews 8e700f440d get the correct test file
(cherry picked from commit ae09500989)
2018-02-09 13:57:52 +11:00
Evan Hunt e2170a7769 [v9_9] fix test error 2018-02-08 18:46:11 -08:00
Mark Andrews 11221a5504 4889. [func] Warn about the use of old root keys without the new
root key being present.  Warn about dlv.isc.org's
                        key being present. Warn about both managed and
                        trusted root keys being present. [RT #43670]

(cherry picked from commit baef0ca988)
2018-02-09 12:16:30 +11:00
Tinderbox User 0cba4c94d4 update copyright notice / whitespace 2018-02-07 23:52:52 +00:00
Mark Andrews 274b1ae55a 4885. [security] update-policy rules that otherwise ignore the name
field now require that it be set to "." to ensure
                        that any type list present is properly interpreted.
                        [RT #47126]

(cherry picked from commit ec771bbdc8)
2018-02-07 13:51:05 +11:00
Tinderbox User 0478b1d205 update copyright notice / whitespace 2018-01-22 23:49:47 +00:00
Mukund Sivaraman ef838436ef Don't permit loading meta RR types such as TKEY from master files (#47009)
(cherry picked from commit 8a4ce20172)
(cherry picked from commit c8eb726046)
(cherry picked from commit 6fb3db01ac)
(cherry picked from commit 96456c0834)
2018-01-22 15:03:31 +05:30
Tinderbox User 8d5a01a868 update copyright notice / whitespace 2018-01-13 23:50:30 +00:00
Mark Andrews a8b6d87ebe ret was not being set to 1 on dig error. [RT #46990]
(cherry picked from commit 69c4c987f6)
2018-01-13 13:18:15 +11:00
Mark Andrews 7210904eb9 backport support for Windows differences 2017-12-13 17:51:29 +11:00
Mark Andrews 26facb12cb test for key != NULL on error path
(cherry picked from commit 9bad78cbc2)
2017-12-13 15:13:30 +11:00
Mark Andrews 93b42ff4cc 4846. [test] Adjust timing values in runtime system test. Address
named.pid removal races in runtime system test.
                        [RT #46800]

(cherry picked from commit c67180f09b)
(cherry picked from commit 0f14b04132)
(cherry picked from commit 265ba7d08b)
2017-12-13 10:38:48 +11:00
Mark Andrews 60a1305469 increment test number
(cherry picked from commit e5c2cfdbf9)
2017-12-08 14:51:37 +11:00
Tinderbox User 92c1063230 update copyright notice / whitespace 2017-12-06 23:48:04 +00:00
Mark Andrews 4a51a6fd40 4840. [test] Add tests to cover fallback to using ZSK on inactive
KSK. [RT #46787]

(cherry picked from commit 32d09cd7e0)
(cherry picked from commit 0d6328ce5f)
(cherry picked from commit 51f13bcd2f)
2017-12-06 20:50:56 +11:00
Tinderbox User d114b94481 update copyright notice / whitespace 2017-12-05 23:48:43 +00:00
Curtis Blackburn 60b4b5ead3 clarify "stage 1" and "stage 2" in autosign test 2017-12-05 10:05:21 -08:00
Mark Andrews 02324ce60a set the DNSKEY deletion time to now+5 once we got all the zones into their initial state
(cherry picked from commit ecafa2ae50)
(cherry picked from commit 15057131d5)
2017-12-05 21:43:13 +11:00
Mark Andrews 124a44db43 use 9.11 and earlier syntax for dnssec-keygen
(cherry picked from commit 7f31784c52)
2017-12-05 20:44:20 +11:00
Mark Andrews 3666b9bfb6 4839. [bug] zone.c:zone_sign was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46774]

(cherry picked from commit 00f5ea91cf)
2017-12-05 16:12:05 +11:00
Tinderbox User 55da37ecc7 update copyright notice / whitespace 2017-12-04 23:51:02 +00:00
Evan Hunt 36794f5653 [v9_9] fix test descriptions 2017-12-04 15:48:09 -08:00
Mark Andrews 2c0a365200 4838. [bug] zone.c:add_sigs was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46754]

(cherry picked from commit 6fa2a0691e)
(cherry picked from commit 677f507de7)
2017-12-05 09:44:49 +11:00
Tinderbox User bd9577293b update copyright notice / whitespace 2017-12-03 23:47:49 +00:00
Mark Andrews 5ed673c0d2 4837. [bug] dns_update_signatures{inc} (add_sigs) was not
properly determining if there were active KSK and
                        ZSK keys for a algorithm when update-check-ksk is
                        true (default) leaving records unsigned. [RT #46743]

(cherry picked from commit 196e01da5f)
(cherry picked from commit bf459d24a1)
(cherry picked from commit 5623f65cc4)
2017-12-04 10:09:45 +11:00