Commit Graph

7263 Commits

Author SHA1 Message Date
Michał Kępień
580fb63a68 Wait until a cache dump completes instead of waiting for a fixed amount of time
Dumping the cache is an asynchronous operation, so sleeping for a fixed
amount of time after running "rndc dumpdb" is imperfect as dumping cache
contents may take longer than expected on slower machines.  Instead of
always sleeping for 1 second, wait until the "; Dump complete" line
appears in the dump or 10 seconds pass, whichever comes first.

(cherry picked from commit 2bbff06d36)
(cherry picked from commit e617b91527)
2018-02-21 11:28:16 +11:00
Michał Kępień
44e946e9e9 Do not overwrite cache dumps
Unless configured otherwise in named.conf, "rndc dumpdb" causes a cache
dump to be written to a file called "named_dump.db" in the working
directory of the given named instance.  Repeatedly using this command
throughout different checks in the cacheclean system test causes cache
dumps for older checks to be overwritten, which hinders failure
diagnosis.  Prevent this by moving each cache dump to a check-specific
location after running "rndc dumpdb".

Furthermore, during the "check flushtree clears adb correctly" check,
dump_cache() is called twice without renaming the resulting files.
Prevent the first cache dump from being overwritten by moving it to a
different file before calling "rndc dumpdb" for the second time.

(cherry picked from commit aeea1faf01)
(cherry picked from commit dcd91ab322)
2018-02-21 11:26:58 +11:00
Michał Kępień
5c0afa76f7 Assign an index to each check in the cacheclean system test
This will enable storing per-check forensic data, which facilitates
troubleshooting test failures.

(cherry picked from commit 01de79b332)
(cherry picked from commit 7679819e15)
2018-02-21 10:52:43 +11:00
Mark Andrews
4404fcb384 return failure count 2018-02-16 18:42:11 +11:00
Mark Andrews
7245f12d3e conditionally declare strbuf 2018-02-16 18:41:31 +11:00
Mark Andrews
872543eca7 add brackets 2018-02-16 18:37:05 +11:00
Mark Andrews
5de799a1c8 reorder test to silence cppcheck 2018-02-16 18:37:05 +11:00
Mark Andrews
32166fae3b remove event which is only used for sizeof 2018-02-16 18:37:05 +11:00
Mark Andrews
a4d8e7526a reorder test to silence cppcheck 2018-02-16 18:36:17 +11:00
Mark Andrews
f7c7a87cb4 use %u instead of %d 2018-02-16 18:30:18 +11:00
Mark Andrews
b7a4a93b0d use %u instead of %d 2018-02-16 18:17:59 +11:00
Mark Andrews
cc21083141 use %u instead of %d 2018-02-16 18:16:48 +11:00
Mark Andrews
b3d10f1a43 use %u instead of %d 2018-02-16 18:06:58 +11:00
Mark Andrews
62d579f152 use %u instead of %d 2018-02-16 18:05:01 +11:00
Mark Andrews
41ac666f4a use %u instead of %d 2018-02-16 18:04:27 +11:00
Mark Andrews
5c91a79de9 use %u instead of %d 2018-02-16 18:02:21 +11:00
Mark Andrews
3ddd77519d use %u instead of %d 2018-02-16 17:58:39 +11:00
Mark Andrews
e3bc8bc293 use %u instead of %d 2018-02-16 17:53:13 +11:00
Mark Andrews
75691e0d90 use %u instead of %d 2018-02-16 17:53:13 +11:00
Mark Andrews
01fd4fcca2 use %u instead of %d 2018-02-16 17:51:07 +11:00
Mark Andrews
a365729e6a make declarations consistent 2018-02-16 17:49:02 +11:00
Mark Andrews
5962de0c3e report argument error in human form 2018-02-16 17:49:02 +11:00
Mark Andrews
8498787e55 use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews
2194d8674b use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews
faabe3071c use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews
028a719b2f use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews
5c28ae51c5 use %u instead of %d 2018-02-16 17:49:02 +11:00
Mark Andrews
92a93137fc use %u instead of %i 2018-02-16 17:46:46 +11:00
Mark Andrews
abc877a61a use %u rather than %d; pass a unsigned int pointer 2018-02-16 17:44:39 +11:00
Mark Andrews
92eeb710c3 clear *logp 2018-02-16 17:44:39 +11:00
Mark Andrews
8251280d02 use %u instead of %d 2018-02-16 17:44:39 +11:00
Mark Andrews
2b64fa5994 signed vs unsigned fixes 2018-02-16 17:42:57 +11:00
Evan Hunt
950777feb8 [v9_9] copyrights 2018-02-10 16:32:35 -08:00
Mark Andrews
c6cd108838 check warning text 2018-02-09 14:04:35 +11:00
Mark Andrews
8e700f440d get the correct test file
(cherry picked from commit ae09500989)
2018-02-09 13:57:52 +11:00
Evan Hunt
e2170a7769 [v9_9] fix test error 2018-02-08 18:46:11 -08:00
Mark Andrews
f6b7ff7280 fix meger error 2018-02-09 12:20:34 +11:00
Mark Andrews
11221a5504 4889. [func] Warn about the use of old root keys without the new
root key being present.  Warn about dlv.isc.org's
                        key being present. Warn about both managed and
                        trusted root keys being present. [RT #43670]

(cherry picked from commit baef0ca988)
2018-02-09 12:16:30 +11:00
Tinderbox User
0cba4c94d4 update copyright notice / whitespace 2018-02-07 23:52:52 +00:00
Mark Andrews
274b1ae55a 4885. [security] update-policy rules that otherwise ignore the name
field now require that it be set to "." to ensure
                        that any type list present is properly interpreted.
                        [RT #47126]

(cherry picked from commit ec771bbdc8)
2018-02-07 13:51:05 +11:00
Evan Hunt
fd135e541e [v9_9] remove 'ply' requirement, not needed before 9.11
(cherry picked from commit c6a2350fb7)
2018-01-30 09:19:22 -08:00
Tinderbox User
8aad9a803f update copyright notice / whitespace 2018-01-29 23:50:23 +00:00
Mark Andrews
996b041ed4 4878. [bug] List 'ply' as a requirement for the 'isc' python
package. [RT #47065]

(cherry picked from commit 6e08af82ed)
2018-01-29 13:30:59 +11:00
Tinderbox User
135d4c632c update copyright notice / whitespace 2018-01-23 23:49:46 +00:00
Tinderbox User
6650f52fec regen v9_9 2018-01-23 01:24:40 +00:00
Tinderbox User
0478b1d205 update copyright notice / whitespace 2018-01-22 23:49:47 +00:00
Mukund Sivaraman
ef838436ef Don't permit loading meta RR types such as TKEY from master files (#47009)
(cherry picked from commit 8a4ce20172)
(cherry picked from commit c8eb726046)
(cherry picked from commit 6fb3db01ac)
(cherry picked from commit 96456c0834)
2018-01-22 15:03:31 +05:30
Tinderbox User
f305f65ea5 regen v9_9 2018-01-19 01:37:38 +00:00
Tinderbox User
44e1182a87 update copyright notice / whitespace 2018-01-18 23:50:43 +00:00
Evan Hunt
de38f4a19a [v9_9] fix merge error
(cherry picked from commit cdda779d07)
2018-01-18 13:30:03 -08:00