Commit Graph
6301 Commits
Author SHA1 Message Date
Tinderbox User 4c71ca4ae7 update copyright notice / whitespace 2018-01-10 23:57:36 +00:00
Mark Andrews efb95afc6f 4862. [bug] The rdata flags for RRSIG was not being properly set
when constructing a rdataslab. [RT #46978]

(cherry picked from commit 7befb67af4)
2018-01-11 09:55:07 +11:00
Tinderbox User f3e5a44f00 update copyright notice / whitespace 2018-01-04 23:47:43 +00:00
Evan Hunt f6ec7f6b99 [v9_9] block validator deadlock and prevent use-after-free
4859.	[bug]		A loop was possible when attempting to validate
			unsigned CNAME responses from secure zones;
			this caused a delay in returning SERVFAIL and
			also increased the chances of encountering
			CVE-2017-3145. [RT #46839]

4858.	[security]	Addresses could be referenced after being freed
			in resolver.c, causing an assertion failure.
			(CVE-2017-3145) [RT #46839]
2018-01-03 19:19:59 -08:00
Tinderbox User 01dd316a95 update copyright notice / whitespace 2018-01-03 23:47:32 +00:00
Mark Andrews 26be82ee90 missing newline in comment
(cherry picked from commit 7258b852cf)
2018-01-03 17:12:04 +11:00
Tinderbox User 7aeee801e6 regen v9_9 2017-12-29 02:41:20 +00:00
Mark Andrews 9711fe2244 initalize sigsize to zero; ATF_CHECK_EQ(sigsize, tsig.siglen);
(cherry picked from commit 9f61f6b46b)
2017-12-22 08:59:15 +11:00
Mark Andrews 2884abf6a1 don't attempt to call isc_buffer_free(&buf) twice; don't attempt to call dns_message_destroy(&msg) twice; don't test for key != NULL
(cherry picked from commit cb8650d875)
2017-12-12 13:25:12 +11:00
Mark Andrews 4e7801ebfd 4842. [bug] Conditionally compile opensslecdsa_link.c to avoid
warnings about unused function. [RT #46790]

(cherry picked from commit 63459cdc05)
(cherry picked from commit 2d82ed9456)
2017-12-07 13:41:50 +11:00
Mark Andrews 7b34ba54c9 4841. [bug] Address -fsanitize=undefined warnings. [RT #46786]
(cherry picked from commit 9d5a0abe81)
(cherry picked from commit 58c86991ee)
2017-12-06 21:05:34 +11:00
Mark Andrews 3666b9bfb6 4839. [bug] zone.c:zone_sign was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46774]

(cherry picked from commit 00f5ea91cf)
2017-12-05 16:12:05 +11:00
Mark Andrews 2c0a365200 4838. [bug] zone.c:add_sigs was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46754]

(cherry picked from commit 6fa2a0691e)
(cherry picked from commit 677f507de7)
2017-12-05 09:44:49 +11:00
Mark Andrews 5ed673c0d2 4837. [bug] dns_update_signatures{inc} (add_sigs) was not
properly determining if there were active KSK and
                        ZSK keys for a algorithm when update-check-ksk is
                        true (default) leaving records unsigned. [RT #46743]

(cherry picked from commit 196e01da5f)
(cherry picked from commit bf459d24a1)
(cherry picked from commit 5623f65cc4)
2017-12-04 10:09:45 +11:00
Tinderbox User a0c8227d06 update copyright notice / whitespace 2017-11-29 23:47:59 +00:00
Mark Andrews 5e94477563 4833. [bug] isc_event_free should check that the event is not
linked when called. [RT #46725]

4832.   [bug]           Events were not being removed from zone->rss_events.
                        [RT #46725]

(cherry picked from commit 9ddf7d6c4c)
2017-11-30 10:39:29 +11:00
Mark Andrews a267c17a85 4831. [bug] Convert the RRSIG expirytime to 64 bits for
comparisions in diff.c:resign. [RT #46710]

(cherry picked from commit 0579a11658)
2017-11-29 15:31:53 +11:00
Mark Andrews 900560e800 map more entry points to <name>64 2017-11-28 14:16:57 +11:00
Mark Andrews ade2ece256 #define update_recordsandbytes update_recordsandbytes64 2017-11-28 14:16:01 +11:00
Tinderbox User 230916c184 update copyright notice / whitespace 2017-11-27 23:50:30 +00:00
Mark Andrews d5b0589e4c restore setting header->heap_index to zero in setsigningtime
(cherry picked from commit c22b540e4c)
2017-11-28 06:47:49 +11:00
Mark Andrews d42c4a628d More:
4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fails. [RT #46473]

(cherry picked from commit 19f6a63184)
2017-11-27 15:23:16 +11:00
Mark Andrews d049bb62b8 add missing symbols 2017-11-27 15:04:33 +11:00
Mark Andrews abbc4b2c4f 4817. [cleanup] Use DNS_NAME_INITABSOLUTE and DNS_NAME_INITNONABSOLUTE.
[RT #45433]
2017-11-27 13:30:58 +11:00
Mark Andrews c4f2e47fea silence %lu vs size_t warning by casting to (unsigned long)
(cherry picked from commit 1dc8208a89)
2017-11-24 10:26:48 +11:00
Mark Andrews 889cc681eb in rdbdb.c:setsigningtime stop breaking heap invariant property unless we are going to restore the invariant property
(cherry picked from commit 6ead410268)
2017-11-24 08:51:14 +11:00
Michał Kępień bbfa83da40 [v9_9] Refactor reclimit system test
4823.	[test]		Refactor reclimit system test to improve its
			reliability and speed. [RT #46632]

(cherry picked from commit 1fd4803e84)
2017-11-21 10:34:03 +01:00
Tinderbox User a42d1f9000 update copyright notice / whitespace 2017-11-17 23:47:28 +00:00
Mark Andrews ae7cb54fe0 remove out of date comment
(cherry picked from commit a197094d76)
2017-11-18 08:52:10 +11:00
Mark Andrews cae44b160b 4821. [bug] When resigning ensure that the SOA's expire time is
always later that the resigning time of other records.
                        [RT #46473]

4820.   [bug]           dns_db_subtractrdataset should transfer the resigning
                        information to the new header. [RT #46473]

4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fail. [RT #46473]

(cherry picked from commit 656eed7c9b)
2017-11-18 07:32:10 +11:00
Michał Kępień c799c10ffe [v9_9] Minor improvements to code handling managed keys
4812.	[bug]		Minor improvements to stability and consistency of code
			handling managed keys. [RT #46468]

(cherry picked from commit 54c1627c6f)
2017-11-09 15:21:04 +01:00
Michał Kępień dbda79e4ec [v9_9] Prevent junk from being logged when using "also-notify { <ip> key <keyname>; };"
(cherry picked from commit 4034b098d8)
2017-11-08 09:22:34 +01:00
Michał Kępień 7e6fe17488 [v9_9] Backport fix for RT #46055
4803.   [bug]		Backport fix for RT #46055 from RT #46267. [RT #46430]

(cherry picked from commit 406caf7b9c)
2017-10-31 06:13:16 +01:00
Mark Andrews b746de8891 tmp should be a (struct in_addr) not (struct in_addr *)
(cherry picked from commit 6e02359034)
2017-10-31 10:36:14 +11:00
Evan Hunt b783e3dfc7 [v9_9] clean up DNS_MESSAGETEXTFLAG comments
(cherry picked from commit 89d1777560)
2017-10-25 21:34:58 -07:00
Tinderbox User f46bfe0899 update copyright notice / whitespace 2017-10-25 23:55:13 +00:00
Evan Hunt dcaf355f00 [v9_9] log when update-policy local gets a key match from a remote host
4788.	[cleanup]	When using "update-policy local", log a warning
			when an update matching the session key is received
			from a remote host. [RT #46213]

- this completes change #4762.
2017-10-25 01:09:41 -07:00
Michał Kępień c6753bad79 [v9_9] Rename nsec3param_salt_totext() to dns_nsec3param_salttotext(), make it public, add unit tests
4786.	[cleanup]	Turn nsec3param_salt_totext() into a public function,
			dns_nsec3param_salttotext(), and add unit tests for it.
			[RT #46289]

(cherry picked from commit 54a43e9bf1)
2017-10-25 09:51:06 +02:00
Michał Kępień eba17e0581 [v9_9] Remove REQUIRE preventing change 4592 from working
Change 4592 was supposed to replace a REQUIRE with a conditional return.
While the latter was added, the former was not removed.  Remove the
relevant REQUIRE to fix RT #43822 for good.

(cherry picked from commit a94d68ce43)
2017-10-24 21:11:56 +02:00
Evan Hunt 9c1540b207 [v9_9] update B.ROOT-SERVERS.NET 2017-10-24 09:17:36 -07:00
Tinderbox User 2f5154f3b1 update copyright notice / whitespace 2017-10-19 23:49:30 +00:00
Mark Andrews 54eb949c35 s/REQUIRE/ISC_REQUIRE/; include <isc/assertions.h> if ISC_REQUIRE is used; include <isc/likely.h> if ISC_{UN}LIKELY is used
(cherry picked from commit 0fab171196)
2017-10-19 17:00:13 +11:00
Evan Hunt dd6b511f26 [v9_9] remove reference to ht.h 2017-10-18 19:54:22 -07:00
Mark Andrews 40e08f66a8 4774. [bug] <isc/util.h> was incorrectly included in several
header files. [RT #46311]
2017-10-19 12:54:44 +11:00
Tinderbox User b17ca7e7f1 update copyright notice / whitespace 2017-10-17 23:53:44 +00:00
Michał Kępień eb2c3bdfae [v9_9] Doxygen fixes and cleanups
4773.	[doc]		Fixed generating Doxygen documentation for functions
			annotated using certain macros.  Miscellaneous
			Doxygen-related cleanups. [RT #46276]

(cherry picked from commit 5e6d28e1b7)
2017-10-17 08:13:40 +02:00
Tinderbox User 0f155d79a0 update copyright notice / whitespace 2017-10-11 23:48:25 +00:00
Mark Andrews 6568dded83 reserve subscription flags
(cherry picked from commit a9a983781e)
2017-10-12 09:20:31 +11:00
Evan Hunt c7a13bf188 [v9_9] ignore cache when sending 5011 refresh queries
4771.	[bug]		When sending RFC 5011 refresh queries, disregard
			cached DNSKEY rrsets. [RT #46251]

(cherry picked from commit b2597ce86b)
(cherry picked from commit b8d1e3cd5d)
2017-10-11 14:37:30 -07:00
Evan Hunt ccad706f63 [v9_9] reduce unnecessary priming queries
4770.	[bug]		Cache additional data from priming queries as glue.
			Previously they were ignored as unsigned
			non-answer data from a secure zone, and never
			actually got added to the cache, causing hints
			to be used frequently for root-server
			addresses, which triggered re-priming. [RT #45241]

(cherry picked from commit 5de02a075b)
(cherry picked from commit 6216df5ccd)
(cherry picked from commit 07e25984b8)
2017-10-11 09:21:21 -07:00