Commit Graph

274 Commits

Author SHA1 Message Date
Brian Wellington
8732b497cf formatting changes during code review 2000-03-16 23:40:50 +00:00
Andreas Gustafsson
691b60f24e return zero-length signature/other data as zero-sized
isc_mem_get() blocks, not NULL pointers
2000-03-16 23:13:02 +00:00
Bob Halley
1db2e6b81a rdata code review 2000-03-16 22:42:32 +00:00
Andreas Gustafsson
76e9eb5ba6 document relevant RFC number 2000-03-16 22:42:31 +00:00
Andreas Gustafsson
1c497c6e34 in fromwire_opt, the option field was used as both
option and length; stylistic changes from code review
2000-03-16 22:42:10 +00:00
Michael Graff
940e4ef72b add reviewed, minor formatting changes 2000-03-16 22:07:28 +00:00
Michael Graff
325f2a0960 add reviewed by, and minor formatting nits 2000-03-16 21:58:58 +00:00
Andreas Gustafsson
954f31569c code review 2000-03-16 21:50:14 +00:00
Brian Wellington
763340ccb3 Rewrote handling of the NULL record to match RFC 1035 2000-03-16 21:49:42 +00:00
David Lawrence
659c68b446 Reviewed.
use UNUSED() macros.
2000-03-16 02:31:14 +00:00
James Brister
ecd3b66f8c code review changes 2000-03-16 02:23:17 +00:00
Michael Graff
923d996a97 no local, comment NONE or GLOBAL14 2000-03-16 02:20:19 +00:00
Michael Graff
f4b24db598 mostly UNUSED() changes, minor formatting things 2000-03-16 02:18:16 +00:00
Brian Wellington
5fe1a9797c code review 2000-03-16 02:16:16 +00:00
David Lawrence
8cb85014a7 added Reviewed comment 2000-03-16 02:15:52 +00:00
Brian Wellington
c363150ad5 more code review 2000-03-16 02:08:51 +00:00
James Brister
96805adfc9 code review changes 2000-03-16 02:07:06 +00:00
James Brister
ce8b84ce64 more code review changes. 2000-03-16 02:00:37 +00:00
Brian Wellington
c2bb855911 code review 2000-03-16 01:44:08 +00:00
David Lawrence
926234e867 In fromtext_cert:
.	removed strtol which was irrelevant (its results were not checked,
	and dns_cert_fromtext did the real parsing).
      . removed redundant range checking (uint16_tobuffer did the same
	checking.
Use UNUSED() macro.
draft-ietf-dnssec-certs-04.txt -> RFC 2538
2000-03-16 01:43:42 +00:00
James Brister
3b811bd920 code review changes 2000-03-16 01:40:27 +00:00
James Brister
ee7cac1c6e code review changes. 2000-03-16 01:37:14 +00:00
James Brister
4f64d3ae93 code review changes 2000-03-16 01:31:03 +00:00
Brian Wellington
d5c518af63 code review 2000-03-16 01:26:49 +00:00
James Brister
ec04f989ea code review changes 2000-03-16 01:15:36 +00:00
Brian Wellington
d0fe07af9c code review 2000-03-16 00:54:24 +00:00
Michael Graff
f72fbb5d0b formatting changes, and addition of UNUSED() where needed 2000-03-16 00:53:01 +00:00
Michael Graff
5d3cca55eb s/reviewed:/Reviewed:/ 2000-03-16 00:48:08 +00:00
Michael Graff
e1cc8e9a08 changes after code review 2000-03-16 00:18:29 +00:00
Bob Halley
7d32c065c7 update copyright 2000-02-03 23:50:32 +00:00
Mark Andrews
2e8215dda9 checkpoint to/from struct support 2000-01-17 03:21:53 +00:00
Bob Halley
1871fef050 implement NAPTR additional data 2000-01-07 02:44:27 +00:00
Michael Graff
3ddd814a97 dns_result_t is no more. s/dns_result_t/isc_result_t/ -- more later, when I need a break. 1999-12-23 00:09:04 +00:00
Mark Andrews
19c5c23ef6 fix compiler warning: While loop condition is always non-zero.
nxt_30.c enforce type range to 1..127. DNS_R_RANGE otherwise.
1999-11-03 01:07:02 +00:00
Mark Andrews
9088094680 Add read support for BIND 8 TTL / counter format to soa.
Move bind_ttl to ttl.c and rename dns_ttl_fromtext and dns_counter_fromtext,
fix bug in handling of seconds (x 1 not x 60), can also handle raw number.
1999-11-02 13:07:53 +00:00
Mark Andrews
db725ebe2b Add initial class HS support. 1999-10-13 01:24:49 +00:00
David Lawrence
ea86510592 cast token as_ulong to unsigned char rather than use token as_char
because the latter will give the wrong value on big-endian systems.
1999-10-08 23:54:40 +00:00
David Lawrence
d2d1163f55 um, ignore that last change. using token.value.as_char will not be
correct on big-endian systems.  use as_ulong but cast to unsigned char.
1999-10-08 23:52:39 +00:00
David Lawrence
65f7626dff cast int arguments to isc_buffer_putuint{16,32} to appropriate size.
they are already masked out of a 64 bit int to the correct size, but
NT's CL is Unaware.
1999-10-08 22:48:13 +00:00
David Lawrence
793213e886 assign char prefixlen from token.value.as_char, not token.value_.as_ulong.
it has already been checked for range.
1999-10-08 22:46:28 +00:00
David Lawrence
63430de345 Check the rdata type for range before uint16_tobuffer, because by the time
uint16_tobuffer is called the loss of data from strtol() already occurred
and uint16_tobuffer would not be able to detect a range error.

delint: integral size mismatch in call to dns_rcode_totext with a 32 bit
int passed where a 16 bit is expected.  since the variable was retrieved
via uint16_fromregion immediately prior to dns_rcode_totext, casting
the 32 bit to 16 bit (to dns_rcode_t) is sufficient.
1999-10-08 21:45:01 +00:00
David Lawrence
0bd044c2af Check the rdata type for range before uint16_tobuffer, because by the time
uint16_tobuffer is called the loss of data from strtol() already occurred
and uint16_tobuffer would not be able to detect a range error.

also, use token.value.as_char when assigning to char c, which is already
checked to be < 256.
1999-10-08 21:42:23 +00:00
David Lawrence
6e482e595d fromtext_nxt(): check the range of 'dns_rdatatype_t covered' from the long int
that is read via strtol() rather than assigning covered directly from strtol(),
so that a value greater than the width of dns_rdatatype_t can be detected.
1999-10-08 21:26:42 +00:00
David Lawrence
722cc17289 delint: integral size mismatch in call to dns_cert_totext with a 32 bit
int passed where a 16 bit is expected.  since the variable was retrieved
via uint16_fromregion immediately prior to dns_cert_totext, casting
the 32 bit to 16 bit (to dns_cert_t) is sufficient.
1999-10-08 21:22:27 +00:00
Brian Wellington
cf3f14106d Changed 'dns_name_t *' in structs to 'dns_name_t' 1999-10-07 21:49:39 +00:00
Brian Wellington
be51993531 added key to/from/free struct 1999-10-07 21:48:52 +00:00
Andreas Gustafsson
3ddd92da66 improved support for mnemonics in DNSSEC RR types 1999-09-17 09:25:21 +00:00
Michael Graff
5f0e2c8913 update copyright text 1999-09-16 00:02:20 +00:00
Michael Graff
2f072c2982 Update copyrights 1999-09-15 23:03:43 +00:00
Mark Andrews
05f90cac85 Adjust / add stucture definitions for NS/SOA/A/AAAA/A6 records. 1999-09-02 06:40:15 +00:00