Commit Graph
252 Commits
Author SHA1 Message Date
Tony FinchandMark Andrews 660c9af77b cleanup: use dns_secalg_t and dns_dsdigest_t where appropriate
Use them in structs for various rdata types where they are missing.
This doesn't change the structs since we are replacing explicit
uint8_t field types with aliases for uint8_t.

Use dns_dsdigest_t in library function arguments.

(cherry picked from commit 0f219714e1)
2019-03-08 22:25:27 +11:00
Mark AndrewsandEvan Hunt ccf915f7e4 don't use 'typename' as it is reserved in C++ 2018-11-14 11:13:21 -08:00
Ondřej Surý 2f8b28efad Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached
(cherry picked from commit 23fff6c569)
(cherry picked from commit 4568669807)
2018-11-08 22:42:52 +07:00
Ondřej Surý 1084b40b44 Replace custom isc_boolean_t with C standard bool type
(cherry picked from commit 994e656977)
(cherry picked from commit 884929400c)
2018-08-10 15:20:57 +02:00
Ondřej Surý aaa76dc654 Replace custom isc_u?intNN_t types with C99 u?intNN_t types
(cherry picked from commit cb6a185c69)
(cherry picked from commit d61e6a3111)
2018-08-10 15:20:57 +02:00
Michał KępieńandEvan Hunt ecea678dac Use dns_fixedname_initname() where possible
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.

This patch was mostly prepared using Coccinelle and the following
semantic patch:

    @@
    expression fixedname, name;
    @@
    -	dns_fixedname_init(&fixedname);
    	...
    -	name = dns_fixedname_name(&fixedname);
    +	name = dns_fixedname_initname(&fixedname);

The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.

It is likely that more occurrences of this pattern can be refactored in
an identical way.  This commit only takes care of the low-hanging fruit.

(cherry picked from commit 4df4a8e731)
(cherry picked from commit 0041aeb751)
2018-04-10 13:26:23 -07:00
Evan Hunt 8b205089b7 update file headers to remove copyright years 2018-03-14 16:40:20 -07:00
Evan Hunt 95c01ddde2 temporarily revert change #4859
(cherry picked from commit 84ec07999f)
2018-03-02 12:02:49 -08:00
Tinderbox User dc2a85bed7 update copyright notice / whitespace 2018-01-04 23:46:19 +00:00
Evan Hunt 7ff28f5bef [v9_11] block validator deadlock and prevent use-after-free
4859.	[bug]		A loop was possible when attempting to validate
			unsigned CNAME responses from secure zones;
			this caused a delay in returning SERVFAIL and
			also increased the chances of encountering
			CVE-2017-3145. [RT #46839]

4858.	[security]	Addresses could be referenced after being freed
			in resolver.c, causing an assertion failure.
			(CVE-2017-3145) [RT #46839]
2018-01-03 19:19:46 -08:00
Evan Hunt 1ca2cf0243 [v9_11] update copyrights that had been missed recently 2017-04-23 17:07:59 -07:00
Mukund Sivaraman 9540b42695 Ignore SHA-1 DS digest type when SHA-384 DS digest type is present (#45017)
(cherry picked from commit 5d01eab088)
2017-04-21 16:20:57 +05:30
Mark Andrews 0c27b3fe77 4401. [misc] Change LICENSE to MPL 2.0. 2016-06-27 14:56:38 +10:00
Mark Andrews a85c6b35af 4138. [bug] A uninitialized value in validator.c could result
in a assertion failure. (CVE-2015-4620) [RT #39795]
2015-06-17 09:13:03 +10:00
Tinderbox User c110d61b17 update copyright notice / whitespace 2015-01-20 23:45:26 +00:00
Evan Hunt 59c489552d [master] remove a potentially misleading log message 2015-01-19 20:15:01 -08:00
Mark Andrews 2fa1fc5332 3945. [bug] Invalid wildcard expansions could be incorrectly
accepted by the validator. [RT #37093]
2014-09-05 12:10:55 +10:00
Mark Andrews fec7998314 3942. [bug] Wildcard responses from a optout range should be
marked as insecure. [RT #37072]
2014-09-04 13:57:50 +10:00
Mark Andrews 5d63868ad0 DNS_VALIDATOR_NONTA needs passed to sub validator 2014-07-02 14:12:15 +10:00
Evan Hunt b8a9632333 [master] complete NTA work
3882.	[func]		By default, negative trust anchors will be tested
			periodically to see whether data below them can be
			validated, and if so, they will be allowed to
			expire early. The "rndc nta -force" option
			overrides this behvaior.  The default NTA lifetime
			and the recheck frequency can be configured by the
			"nta-lifetime" and "nta-recheck" options. [RT #36146]
2014-06-18 16:50:38 -07:00
Evan Hunt 0cfb247368 [master] rndc nta
3867.	[func]		"rndc nta" can now be used to set a temporary
			negative trust anchor, which disables DNSSEC
			validation below a specified name for a specified
			period of time (not exceeding 24 hours).  This
			can be used when validation for a domain is known
			to be failing due to a configuration error on
			the part of the domain owner rather than a
			spoofing attack. [RT #29358]
2014-05-29 22:22:53 -07:00
Mark Andrews 36e5ac0033 3819. [bug] NSEC3 hashes need to be able to be entered and
displayed without padding.  This is not a issue for
                        currently defined algorithms but may be for future
                        hash algorithms. [RT #27925]
2014-04-24 18:58:03 +10:00
Tinderbox User 72141595cf update copyright notice 2014-02-16 23:46:32 +00:00
Evan Hunt 1d761cb453 [master] delve
3741.	[func]		"delve" (domain entity lookup and validation engine):
			A new tool with dig-like semantics for performing DNS
			lookups, with internal DNSSEC validation, using the
			same resolver and validator logic as named. This
			allows easy validation of DNSSEC data in environments
			with untrustworthy resolvers, and assists with
			troubleshooting of DNSSEC problems. (Note: not yet
			available on win32.) [RT #32406]
2014-02-16 13:03:17 -08:00
Mark Andrews ff8ab6befe redo: 3576. [bug] Address a shutdown race when validating. [RT #33573] 2013-06-04 11:27:26 +10:00
Mark Andrews c611465739 address memory in dns_view_getsecroots failure 2013-05-31 12:31:01 +10:00
Mark Andrews 2cd3c8856c 3576. [bug] Address a shutdown race when validating. [RT #33573] 2013-05-29 18:02:24 +10:00
Mark Andrews 8013077aa7 3541. [bug] The parts if libdns was not being properly initialized
in when built in libexport mode. [RT #33028]
2013-04-03 17:27:40 +11:00
Tinderbox User 5c6b95ba1b update copyright notice 2013-01-10 23:46:00 +00:00
Mark Andrews 4801931443 3461. [bug] Negative responses could incorrectly have AD=1
set. [RT #32237]
2013-01-10 23:09:08 +11:00
Tinderbox User b16174507d update copyright notice 2012-12-18 23:45:50 +00:00
Mark Andrews 8462dfb880 3443. [bug] The NOQNAME proof was not being returned from cached
insecure responses. [RT #21409]
2012-12-19 09:55:02 +11:00
Mark Andrews 39bfdc2ff9 3419. [bug] Memory leak on validation cancel. [RT #31869]
Squashed commit of the following:

commit 452b07ec7cb31784d90d9c2e45ca708df306302e
Author: Mark Andrews <marka@isc.org>
Date:   Wed Nov 14 23:36:36 2012 +1100

    destroy fetch when canceling validator
2012-11-15 11:16:28 +11:00
Mark Andrews d8fc410cf8 Redo
3415.   [bug]           named could die with a REQUIRE failure if a valdation
                        was canceled. [RT #31804]
2012-11-14 07:41:32 +11:00
Mark Andrews 1a09fefa59 3415. [bug] named could die with a REQUIRE failure id a valdation
was canceled. [RT #31804]

Squashed commit of the following:

commit d414d3cb4244daeca4159ac1f8a82322e4a20e5a
Author: Mark Andrews <marka@isc.org>
Date:   Wed Nov 7 14:19:28 2012 +1100

    check that val->fetch != NULL before calling dns_resolver_destroyfetch
2012-11-09 09:09:52 +11:00
Evan Hunt 47c5b8af92 [master] silence coverity warnings
3401.	[bug]		Addressed Coverity warnings. [RT #31484]
2012-10-23 22:04:06 -07:00
Mark Andrews dbf693fdfd 3391. [bug] DNSKEY that encountered a CNAME failed. [RT #31262] 2012-10-06 14:56:33 +10:00
Evan Hunt 41bbb34bc2 fix coverity issues
3388.	[bug]		Fixed several Coverity warnings. [RT #30996]
2012-10-02 23:44:03 -07:00
Mark Andrews 058e44186b 3387. [func] Support for a DS digest can be disabled at
runtime with disable-ds-digests. [RT #21581]
2012-10-03 12:38:43 +10:00
ckb e7857b5ee0 3356. [bug] Cap the TTL of signed RRsets when RRSIGs are
approaching their expiry, so they don't remain
			in caches after expiry. [RT #26429]
2012-07-25 17:06:34 -05:00
Mark Andrews 7865ea9545 3339. [func] Allow the maximum supported rsa exponent size to be specified: "max-rsa-exponent-size <value>;" [RT #29228] 2012-06-14 15:44:20 +10:00
Mark Andrews 28a8f5b0de set $Id$ 2012-03-08 00:21:15 +11:00
Automatic Updater 5fec28507a update copyright notice 2012-02-15 21:19:59 +00:00
Mark Andrews 6d386978b3 3285. [bug] val-frdataset was incorrectly disassociated in
proveunsecure after calling startfinddlvsep.
                        [RT #27928]
2012-02-15 20:59:40 +00:00
Evan Hunt 25845da41a 3203. [bug] Increase log level to 'info' for validation failures
from expired or not-yet-valid RRSIGs. [RT #21796]
2011-11-04 05:36:28 +00:00
Automatic Updater dfc015bc7e update copyright notice 2011-10-20 23:46:51 +00:00
Mark Andrews ada40193c8 3175. [bug] Fix how DNSSEC positive wildcard responses from a
NSEC3 signed zone are validated.  Stop sending a
                        unnecessary NSEC3 record when generating such
                        responses. [RT #26200]
2011-10-20 21:42:11 +00:00
Mark Andrews 020c4484fe 3173. [port] Correctly validate root DS responses. [RT #25726] 2011-10-15 05:00:15 +00:00
Evan Hunt 6de9744cf9 3124. [bug] Use an rdataset attribute flag to indicate
negative-cache records rather than using rrtype 0;
			this will prevent problems when that rrtype is
			used in actual DNS packets. [RT #24777]

3123.	[security]	Change #2912 exposed a latent flaw in
			dns_rdataset_totext() that could cause named to
			crash with an assertion failure. [RT #24777]
2011-06-08 22:13:51 +00:00
Mark Andrews ea82782532 3120. [bug] Named could fail to validate zones list in a DLV
that validated insecure without using DLV and had
                        DS records in the parent zone. [RT #24631]
2011-05-26 04:35:02 +00:00