From fd5167dd705a18a8e52b46e4ec3d63aba4b50eb7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 15 Apr 2020 12:50:28 +0200 Subject: [PATCH] Fix the discrepancy between cfg_pluginlist_foreach declaration and definition There was a missing indirection for the pluginlist_cb_t *callback in the declaration of the cfg_pluginlist_foreach function. Reported by MSVC as: lib\isccfg\parser.c(4057): warning C4028: formal parameter 4 different from declaration (cherry picked from commit 4ffe7255853b8332bb585d96a25efb9e56bdcfa7) --- lib/isccfg/include/isccfg/cfg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/isccfg/include/isccfg/cfg.h b/lib/isccfg/include/isccfg/cfg.h index 3123a9b39f..eda5b46a69 100644 --- a/lib/isccfg/include/isccfg/cfg.h +++ b/lib/isccfg/include/isccfg/cfg.h @@ -597,7 +597,7 @@ typedef isc_result_t(pluginlist_cb_t)(const cfg_obj_t *config, isc_result_t cfg_pluginlist_foreach(const cfg_obj_t *config, const cfg_obj_t *list, - isc_log_t *lctx, pluginlist_cb_t callback, + isc_log_t *lctx, pluginlist_cb_t *callback, void *callback_data); /*%< * For every "plugin" stanza present in 'list' (which in turn is a part of