From f7986c8d1a35f8552b60e454403832dc776a9fc0 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Sun, 5 Aug 2018 07:23:07 +0200 Subject: [PATCH] Only get one random number per response when order == random --- lib/dns/rdataset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/dns/rdataset.c b/lib/dns/rdataset.c index aad094ef49..afe76e16dd 100644 --- a/lib/dns/rdataset.c +++ b/lib/dns/rdataset.c @@ -409,9 +409,8 @@ towiresorted(dns_rdataset_t *rdataset, const dns_name_t *owner_name, /* * 'Random' order. */ + isc_uint32_t val = isc_random32(); for (i = 0; i < count; i++) { - isc_uint32_t val = isc_random32(); - choice = i + val % (count - i); rdata = in[i]; in[i] = in[choice];