From f3e647a4c1e4ae99ca33063871e0ec093a0ca14d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 18 Jul 2022 14:39:02 +0200 Subject: [PATCH] Run a short respdiff test for all merge requests Running a respdiff test for every merge request would be useful for catching protocol-breaking changes before they are applied to the source code. However, the existing respdiff-based tests take a while to complete (about half an hour with our current CI infrastructure), which does not make them a good fit for this purpose. Add a new GitLab CI job, "respdiff-short", which uses a smaller query set that gets processed within a couple of minutes on our current CI infrastructure. Rename the existing respdiff-based jobs to make distinguishing them easier. (cherry picked from commit 31ee43a314f17b433909a049fafa01200bac14ca) --- .gitlab-ci.yml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index b7fd4ed725..de15bfc767 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1243,7 +1243,17 @@ coverity: # Respdiff tests -respdiff: +respdiff-short: + <<: *respdiff_job + <<: *default_triggering_rules + variables: + CC: gcc + CFLAGS: "${CFLAGS_COMMON} -Og" + MAX_DISAGREEMENTS_PERCENTAGE: "0.5" + script: + - bash respdiff.sh -s named -q "${PWD}/10k_a.txt" -c 3 -w "${PWD}/rspworkdir" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" + +respdiff-long: <<: *respdiff_job <<: *api_schedules_tags_triggers_web_triggering_rules variables: @@ -1253,7 +1263,7 @@ respdiff: script: - bash respdiff.sh -s named -q "${PWD}/100k_mixed.txt" -c 3 -w "${PWD}/rspworkdir" "${CI_PROJECT_DIR}" "/usr/local/respdiff-reference-bind/sbin/named" -respdiff-third-party: +respdiff-long-third-party: <<: *respdiff_job <<: *api_schedules_tags_triggers_web_triggering_rules variables: