From f21d2ee372125a7d0648387581a6712e05feeb52 Mon Sep 17 00:00:00 2001 From: Evan Hunt Date: Wed, 9 Dec 2015 08:54:04 -0800 Subject: [PATCH] [master] comments --- lib/dns/name.c | 5 ++++- lib/dns/rbt.c | 3 ++- lib/isc/include/isc/hash.h | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/dns/name.c b/lib/dns/name.c index 80ebe5a767..fc886e020b 100644 --- a/lib/dns/name.c +++ b/lib/dns/name.c @@ -635,6 +635,7 @@ dns_name_fullcompare(const dns_name_t *name1, const dns_name_t *name2, else count = count2; + /* Loop unrolled for performance */ while (count > 3) { chdiff = (int)maptolower[label1[0]] - (int)maptolower[label2[0]]; @@ -665,7 +666,8 @@ dns_name_fullcompare(const dns_name_t *name1, const dns_name_t *name2, label2 += 4; } while (count-- > 0) { - chdiff = (int)maptolower[*label1++] - (int)maptolower[*label2++]; + chdiff = (int)maptolower[*label1++] - + (int)maptolower[*label2++]; if (chdiff != 0) { *orderp = chdiff; goto done; @@ -759,6 +761,7 @@ dns_name_equal(const dns_name_t *name1, const dns_name_t *name2) { INSIST(count <= 63); /* no bitstring support */ + /* Loop unrolled for performance */ while (count > 3) { c = maptolower[label1[0]]; if (c != maptolower[label2[0]]) diff --git a/lib/dns/rbt.c b/lib/dns/rbt.c index a414e678bf..015dcdbc9d 100644 --- a/lib/dns/rbt.c +++ b/lib/dns/rbt.c @@ -350,7 +350,8 @@ hexdump(const char *desc, unsigned char *data, size_t size) { #ifdef DNS_RBT_USEHASH -/* Upper node is the parent of the root of the passed node's +/* + * Upper node is the parent of the root of the passed node's * subtree. The passed node must not be NULL. */ static inline dns_rbtnode_t * diff --git a/lib/isc/include/isc/hash.h b/lib/isc/include/isc/hash.h index fe344a0159..8904e597a4 100644 --- a/lib/isc/include/isc/hash.h +++ b/lib/isc/include/isc/hash.h @@ -218,7 +218,8 @@ isc_hash_function_reverse(const void *data, size_t length, * isc_hash_function() calculates the hash from start to end over the * input data. isc_hash_function_reverse() calculates the hash from the * end to the start over the input data. The difference in order is - * useful in incremental hashing. + * useful in incremental hashing; for example, a previously hashed + * value for 'com' can be used as input when hashing 'example.com'. * * This is a new variant of isc_hash_calc() and will supercede * isc_hash_calc() eventually.