From efb95afc6fbc3ec7c7f3ee4e3ed6d8b9523df75f Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Thu, 11 Jan 2018 09:51:52 +1100 Subject: [PATCH] 4862. [bug] The rdata flags for RRSIG was not being properly set when constructing a rdataslab. [RT #46978] (cherry picked from commit 7befb67af42a6e6088d91229ab5fcb8d64db0a3a) --- CHANGES | 3 +++ lib/dns/rdataslab.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 71528b1c08..f8376b4c7e 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +4862. [bug] The rdata flags for RRSIG was not being properly set + when constructing a rdataslab. [RT #46978] + 4860. [bug] isc_int8_t should be signed char. [RT #46973] 4859. [bug] A loop was possible when attempting to validate diff --git a/lib/dns/rdataslab.c b/lib/dns/rdataslab.c index 941a30127b..ace3aef07e 100644 --- a/lib/dns/rdataslab.c +++ b/lib/dns/rdataslab.c @@ -329,7 +329,7 @@ dns_rdataslab_fromrdataset(dns_rdataset_t *rdataset, isc_mem_t *mctx, * Store the per RR meta data. */ if (rdataset->type == dns_rdatatype_rrsig) { - *rawbuf++ |= (x[i].rdata.flags & DNS_RDATA_OFFLINE) ? + *rawbuf++ = (x[i].rdata.flags & DNS_RDATA_OFFLINE) ? DNS_RDATASLAB_OFFLINE : 0; } memmove(rawbuf, x[i].rdata.data, x[i].rdata.length);