From e9f30fc2115524fdef638bc33beaf00a56d27b70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Fri, 27 Sep 2019 11:53:49 +0200 Subject: [PATCH] lib/isc/buffer.c: Fix invalid order of DbC checks that could cause dereference before NULL check --- lib/isc/buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/isc/buffer.c b/lib/isc/buffer.c index 219a5493ab..66defe8bbb 100644 --- a/lib/isc/buffer.c +++ b/lib/isc/buffer.c @@ -550,10 +550,11 @@ isc_buffer_allocate(isc_mem_t *mctx, isc_buffer_t **dynbuffer, bdata = isc_mem_get(mctx, length); isc_buffer_init(dbuf, bdata, length); - dbuf->mctx = mctx; ENSURE(ISC_BUFFER_VALID(dbuf)); + dbuf->mctx = mctx; + *dynbuffer = dbuf; return (ISC_R_SUCCESS);