3934. [bug] Catch bad 'sit-secret' in named-checkconf. Improve

sit-secrets documentation. [RT #36980]

(cherry picked from commit 7c73ac5e13)

bin/tests/system/sit/bad-sit-badhex.conf

@@ -0,0 +1,3 @@
+options {
+	sit-secret "012345678901234567890123456789012345678901234567890123456789012";
+};

bin/tests/system/sit/bad-sit-toolong.conf

@@ -0,0 +1,3 @@
+options {
+	sit-secret "01234567890123456789012345678901234567890123456789012345678901234567890";
+};

bin/tests/system/sit/tests.sh

@@ -32,6 +32,15 @@ havetc() {
 	grep 'flags:.* tc[^;]*;' $1 > /dev/null
 }
 
+for bad in bad*.conf
+do
+        ret=0
+        echo "I:checking that named-checkconf detects error in $bad"
+        $CHECKCONF $bad > /dev/null 2>&1
+        if [ $? != 1 ]; then echo "I:failed"; ret=1; fi
+        status=`expr $status + $ret`
+done
+
 n=`expr $n + 1`
 echo "I:checking SIT token returned to empty SIT option ($n)"
 ret=0