From 66ba2fdad583d962a1f4971c85d58381f0849e4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 25 Apr 2018 14:04:31 +0200 Subject: [PATCH 1/3] Replace isc_safe routines with their OpenSSL counter parts --- lib/isc/Makefile.in | 8 +-- lib/isc/include/isc/safe.h | 15 +++-- lib/isc/safe.c | 81 ------------------------- lib/isc/win32/libisc.def.in | 3 - lib/isc/win32/libisc.vcxproj.filters.in | 3 - lib/isc/win32/libisc.vcxproj.in | 1 - 6 files changed, 9 insertions(+), 102 deletions(-) delete mode 100644 lib/isc/safe.c diff --git a/lib/isc/Makefile.in b/lib/isc/Makefile.in index 7fcc405760..eede04eaf1 100644 --- a/lib/isc/Makefile.in +++ b/lib/isc/Makefile.in @@ -58,7 +58,7 @@ OBJS = @ISC_EXTRA_OBJS@ pk11.@O@ pk11_result.@O@ \ parseint.@O@ portset.@O@ quota.@O@ radix.@O@ random.@O@ \ ratelimiter.@O@ refcount.@O@ region.@O@ regex.@O@ result.@O@ \ rwlock.@O@ \ - safe.@O@ serial.@O@ sha1.@O@ sha2.@O@ sockaddr.@O@ stats.@O@ \ + serial.@O@ sha1.@O@ sha2.@O@ sockaddr.@O@ stats.@O@ \ string.@O@ strtoul.@O@ symtab.@O@ task.@O@ taskpool.@O@ \ tm.@O@ timer.@O@ version.@O@ \ ${UNIXOBJS} ${NLSOBJS} ${THREADOBJS} @@ -75,7 +75,7 @@ SRCS = @ISC_EXTRA_SRCS@ pk11.c pk11_result.c \ netaddr.c netscope.c nonce.c openssl_shim.c pool.c \ parseint.c portset.c quota.c radix.c random.c \ ratelimiter.c refcount.c region.c regex.c result.c rwlock.c \ - safe.c serial.c sha1.c sha2.c sockaddr.c stats.c string.c \ + serial.c sha1.c sha2.c sockaddr.c stats.c string.c \ strtoul.c symtab.c task.c taskpool.c timer.c \ tm.c version.c @@ -91,10 +91,6 @@ TESTDIRS = @UNITTESTS@ @BIND9_MAKE_RULES@ -safe.@O@: safe.c - ${LIBTOOL_MODE_COMPILE} ${CC} ${ALL_CFLAGS} @CCNOOPT@ \ - -c ${srcdir}/safe.c - version.@O@: version.c ${LIBTOOL_MODE_COMPILE} ${CC} ${ALL_CFLAGS} \ -DVERSION=\"${VERSION}\" \ diff --git a/lib/isc/include/isc/safe.h b/lib/isc/include/isc/safe.h index f29f00bac6..cba570fdf5 100644 --- a/lib/isc/include/isc/safe.h +++ b/lib/isc/include/isc/safe.h @@ -15,27 +15,26 @@ /*! \file isc/safe.h */ -#include -#include +#include +#include + +#include ISC_LANG_BEGINDECLS -isc_boolean_t -isc_safe_memequal(const void *s1, const void *s2, size_t n); +#define isc_safe_memequal(s1, s2, n) ISC_TF(!CRYPTO_memcmp(s1, s2, n)) /*%< * Returns ISC_TRUE iff. two blocks of memory are equal, otherwise * ISC_FALSE. * */ -int -isc_safe_memcompare(const void *b1, const void *b2, size_t len); +#define isc_safe_memcompare(b1, b2, n) CRYPTO_memcmp(b1, b2, n) /*%< * Clone of libc memcmp() which is safe to differential timing attacks. */ -void -isc_safe_memwipe(void *ptr, size_t len); +#define isc_safe_memwipe(ptr, len) OPENSSL_cleanse(ptr, len) /*%< * Clear the memory of length `len` pointed to by `ptr`. * diff --git a/lib/isc/safe.c b/lib/isc/safe.c deleted file mode 100644 index 5c9e1e2d13..0000000000 --- a/lib/isc/safe.c +++ /dev/null @@ -1,81 +0,0 @@ -/* - * Copyright (C) Internet Systems Consortium, Inc. ("ISC") - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * See the COPYRIGHT file distributed with this work for additional - * information regarding copyright ownership. - */ - -/*! \file */ - -#include - -#include -#include -#include - -#ifdef WIN32 -#include -#endif - -#ifdef _MSC_VER -#pragma optimize("", off) -#endif - -isc_boolean_t -isc_safe_memequal(const void *s1, const void *s2, size_t n) { - isc_uint8_t acc = 0; - - if (n != 0U) { - const isc_uint8_t *p1 = s1, *p2 = s2; - - do { - acc |= *p1++ ^ *p2++; - } while (--n != 0U); - } - return (ISC_TF(acc == 0)); -} - - -int -isc_safe_memcompare(const void *b1, const void *b2, size_t len) { - const unsigned char *p1 = b1, *p2 = b2; - size_t i; - int res = 0, done = 0; - - for (i = 0; i < len; i++) { - /* lt is -1 if p1[i] < p2[i]; else 0. */ - int lt = (p1[i] - p2[i]) >> CHAR_BIT; - - /* gt is -1 if p1[i] > p2[i]; else 0. */ - int gt = (p2[i] - p1[i]) >> CHAR_BIT; - - /* cmp is 1 if p1[i] > p2[i]; -1 if p1[i] < p2[i]; else 0. */ - int cmp = lt - gt; - - /* set res = cmp if !done. */ - res |= cmp & ~done; - - /* set done if p1[i] != p2[i]. */ - done |= lt | gt; - } - - return (res); -} - -void -isc_safe_memwipe(void *ptr, size_t len) { - if (ISC_UNLIKELY(ptr == NULL || len == 0)) - return; - -#ifdef WIN32 - SecureZeroMemory(ptr, len); -#elif HAVE_EXPLICIT_BZERO - explicit_bzero(ptr, len); -#else - memset(ptr, 0, len); -#endif -} diff --git a/lib/isc/win32/libisc.def.in b/lib/isc/win32/libisc.def.in index 6f61d6b13e..1e112fa93d 100644 --- a/lib/isc/win32/libisc.def.in +++ b/lib/isc/win32/libisc.def.in @@ -538,9 +538,6 @@ isc_rwlock_lock isc_rwlock_trylock isc_rwlock_tryupgrade isc_rwlock_unlock -isc_safe_memcompare -isc_safe_memequal -isc_safe_memwipe isc_serial_eq isc_serial_ge isc_serial_gt diff --git a/lib/isc/win32/libisc.vcxproj.filters.in b/lib/isc/win32/libisc.vcxproj.filters.in index f27963d40e..75c578da12 100644 --- a/lib/isc/win32/libisc.vcxproj.filters.in +++ b/lib/isc/win32/libisc.vcxproj.filters.in @@ -626,9 +626,6 @@ Library Source Files - - Library Source Files - Library Source Files diff --git a/lib/isc/win32/libisc.vcxproj.in b/lib/isc/win32/libisc.vcxproj.in index e824ccd768..c0a8fd1c64 100644 --- a/lib/isc/win32/libisc.vcxproj.in +++ b/lib/isc/win32/libisc.vcxproj.in @@ -468,7 +468,6 @@ copy InstallFiles ..\Build\Release\ - From b105ccee68ccc3c18e6ea530063b3c8e5a42571c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Fri, 20 Jul 2018 10:06:14 -0400 Subject: [PATCH 2/3] Remove isc_safe_memcompare, it's not needed anywhere and can't be replaced with CRYPTO_memcmp() --- bin/dnssec/dnssec-signzone.c | 2 +- lib/dns/nsec3.c | 4 ++-- lib/dns/spnego.c | 4 ++-- lib/isc/include/isc/safe.h | 5 ----- lib/isc/tests/safe_test.c | 19 ------------------- 5 files changed, 5 insertions(+), 29 deletions(-) diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c index 05993430ee..7887147b6d 100644 --- a/bin/dnssec/dnssec-signzone.c +++ b/bin/dnssec/dnssec-signzone.c @@ -789,7 +789,7 @@ hashlist_add_dns_name(hashlist_t *l, /*const*/ dns_name_t *name, static int hashlist_comp(const void *a, const void *b) { - return (isc_safe_memcompare(a, b, hash_length + 1)); + return (memcmp(a, b, hash_length + 1)); } static void diff --git a/lib/dns/nsec3.c b/lib/dns/nsec3.c index 2e90bf5f7c..473933c334 100644 --- a/lib/dns/nsec3.c +++ b/lib/dns/nsec3.c @@ -1955,7 +1955,7 @@ dns_nsec3_noexistnodata(dns_rdatatype_t type, const dns_name_t *name, * Work out what this NSEC3 covers. * Inside (<0) or outside (>=0). */ - scope = isc_safe_memcompare(owner, nsec3.next, nsec3.next_length); + scope = memcmp(owner, nsec3.next, nsec3.next_length); /* * Prepare to compute all the hashes. @@ -1979,7 +1979,7 @@ dns_nsec3_noexistnodata(dns_rdatatype_t type, const dns_name_t *name, return (ISC_R_IGNORE); } - order = isc_safe_memcompare(hash, owner, length); + order = memcmp(hash, owner, length); if (first && order == 0) { /* * The hashes are the same. diff --git a/lib/dns/spnego.c b/lib/dns/spnego.c index 227fab54cd..64d576b9d9 100644 --- a/lib/dns/spnego.c +++ b/lib/dns/spnego.c @@ -368,7 +368,7 @@ gssapi_spnego_decapsulate(OM_uint32 *, /* mod_auth_kerb.c */ -static int +static isc_boolean_t cmp_gss_type(gss_buffer_t token, gss_OID gssoid) { unsigned char *p; @@ -392,7 +392,7 @@ cmp_gss_type(gss_buffer_t token, gss_OID gssoid) if (((OM_uint32) *p++) != gssoid->length) return (GSS_S_DEFECTIVE_TOKEN); - return (isc_safe_memcompare(p, gssoid->elements, gssoid->length)); + return (!isc_safe_memequal(p, gssoid->elements, gssoid->length)); } /* accept_sec_context.c */ diff --git a/lib/isc/include/isc/safe.h b/lib/isc/include/isc/safe.h index cba570fdf5..b8a0b2290c 100644 --- a/lib/isc/include/isc/safe.h +++ b/lib/isc/include/isc/safe.h @@ -29,11 +29,6 @@ ISC_LANG_BEGINDECLS * */ -#define isc_safe_memcompare(b1, b2, n) CRYPTO_memcmp(b1, b2, n) -/*%< - * Clone of libc memcmp() which is safe to differential timing attacks. - */ - #define isc_safe_memwipe(ptr, len) OPENSSL_cleanse(ptr, len) /*%< * Clear the memory of length `len` pointed to by `ptr`. diff --git a/lib/isc/tests/safe_test.c b/lib/isc/tests/safe_test.c index f721cd1096..5204c80e1a 100644 --- a/lib/isc/tests/safe_test.c +++ b/lib/isc/tests/safe_test.c @@ -39,24 +39,6 @@ ATF_TC_BODY(isc_safe_memequal, tc) { "\x00\x00\x00\x00", 4)); } -ATF_TC(isc_safe_memcompare); -ATF_TC_HEAD(isc_safe_memcompare, tc) { - atf_tc_set_md_var(tc, "descr", "safe memcompare()"); -} -ATF_TC_BODY(isc_safe_memcompare, tc) { - UNUSED(tc); - - ATF_CHECK(isc_safe_memcompare("test", "test", 4) == 0); - ATF_CHECK(isc_safe_memcompare("test", "tesc", 4) > 0); - ATF_CHECK(isc_safe_memcompare("test", "tesy", 4) < 0); - ATF_CHECK(isc_safe_memcompare("\x00\x00\x00\x00", - "\x00\x00\x00\x00", 4) == 0); - ATF_CHECK(isc_safe_memcompare("\x00\x00\x00\x00", - "\x00\x00\x00\x01", 4) < 0); - ATF_CHECK(isc_safe_memcompare("\x00\x00\x00\x02", - "\x00\x00\x00\x00", 4) > 0); -} - ATF_TC(isc_safe_memwipe); ATF_TC_HEAD(isc_safe_memwipe, tc) { atf_tc_set_md_var(tc, "descr", "isc_safe_memwipe()"); @@ -106,7 +88,6 @@ ATF_TC_BODY(isc_safe_memwipe, tc) { */ ATF_TP_ADD_TCS(tp) { ATF_TP_ADD_TC(tp, isc_safe_memequal); - ATF_TP_ADD_TC(tp, isc_safe_memcompare); ATF_TP_ADD_TC(tp, isc_safe_memwipe); return (atf_no_error()); } From 083461d3329ff6f2410745848a926090586a9846 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Fri, 20 Jul 2018 10:08:24 -0400 Subject: [PATCH 3/3] Fix the isc_safe_memwipe() usage with (NULL, >0) --- lib/isc/tests/safe_test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/isc/tests/safe_test.c b/lib/isc/tests/safe_test.c index 5204c80e1a..ea3e61f98d 100644 --- a/lib/isc/tests/safe_test.c +++ b/lib/isc/tests/safe_test.c @@ -49,7 +49,6 @@ ATF_TC_BODY(isc_safe_memwipe, tc) { /* These should pass. */ isc_safe_memwipe(NULL, 0); isc_safe_memwipe((void *) -1, 0); - isc_safe_memwipe(NULL, 42); /* * isc_safe_memwipe(ptr, size) should function same as