From 89c000f356277e7fc27ca3d86ca804da0249e38d Mon Sep 17 00:00:00 2001 From: Matthijs Mekking Date: Mon, 27 Mar 2023 11:54:00 +0200 Subject: [PATCH 1/2] Fix scan-build issue: initialized value never read Value stored to 'source' during its initialization is never read. (cherry picked from commit 4c33277446704381300920db50a88c56c17e29a9) --- lib/dns/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dns/master.c b/lib/dns/master.c index 36f6305293..fc561076c5 100644 --- a/lib/dns/master.c +++ b/lib/dns/master.c @@ -1101,7 +1101,7 @@ load_text(dns_loadctx_t *lctx) { char *lhs = NULL; char *gtype = NULL; char *rhs = NULL; - const char *source = ""; + const char *source; unsigned long line = 0; bool explicit_ttl; char classname1[DNS_RDATACLASS_FORMATSIZE]; From 56a7daf334c391eb036e6c2a90043a7bec5cc6f3 Mon Sep 17 00:00:00 2001 From: Matthijs Mekking Date: Mon, 27 Mar 2023 11:56:39 +0200 Subject: [PATCH 2/2] Add CHANGES entry for #3965 (cherry picked from commit 357b27b04f5ccc66637277427daa506a01d48f45) --- CHANGES | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGES b/CHANGES index 8382c44c66..adbdf9258c 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +6129. [cleanup] Value stored to 'source' during its initialization is + never read. [GL #3965] + 6124. [bug] When changing from a NSEC3 capable DNSSEC algorithm to an NSEC3 incapable DNSSEC algorithm using KASP the zone could sometimes be incompletely signed. [GL #3937]