From d8402e191abf34e33ca07aba044d62e68e27653b Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Thu, 14 Sep 2017 09:29:28 +1000 Subject: [PATCH] fix filenamelen so it has the buffer length rather than buffer length - 1 (cherry picked from commit 21c12d0107a3c261ae211021791dc58c96f46203) --- bin/dnssec/dnssec-signzone.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c index 6304aa22ee..f4d8e99779 100644 --- a/bin/dnssec/dnssec-signzone.c +++ b/bin/dnssec/dnssec-signzone.c @@ -2806,10 +2806,10 @@ writeset(const char *prefix, dns_rdatatype_t type) { result = dns_name_tofilenametext(gorigin, ISC_FALSE, &namebuf); check_result(result, "dns_name_tofilenametext"); isc_buffer_putuint8(&namebuf, 0); - filenamelen = strlen(prefix) + strlen(namestr); + filenamelen = strlen(prefix) + strlen(namestr) + 1; if (dsdir != NULL) filenamelen += strlen(dsdir) + 1; - filename = isc_mem_get(mctx, filenamelen + 1); + filename = isc_mem_get(mctx, filenamelen); if (filename == NULL) fatal("out of memory"); if (dsdir != NULL) @@ -2916,7 +2916,7 @@ writeset(const char *prefix, dns_rdatatype_t type) { result = dns_master_dump(mctx, db, dbversion, style, filename); check_result(result, "dns_master_dump"); - isc_mem_put(mctx, filename, filenamelen + 1); + isc_mem_put(mctx, filename, filenamelen); dns_db_closeversion(db, &dbversion, ISC_FALSE); dns_db_detach(&db);