From d2debaa4944a4ecb86813738f695c331f6df949c Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Mon, 4 Jul 2005 23:14:21 +0000 Subject: [PATCH] 1895. [bug] fctx_create() could return success even though it failed. [RT #14993] --- CHANGES | 3 +++ lib/dns/resolver.c | 8 +++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGES b/CHANGES index 1497726f51..dc8db84d32 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +1895. [bug] fctx_create() could return success even though it + failed. [RT #14993] + 1894. [func] dig: report the number of extra bytes still left in the packet after processing all the records. diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c index 82c5f2f533..b1bf5455d1 100644 --- a/lib/dns/resolver.c +++ b/lib/dns/resolver.c @@ -15,7 +15,7 @@ * PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: resolver.c,v 1.284.18.30 2005/06/27 00:20:00 marka Exp $ */ +/* $Id: resolver.c,v 1.284.18.31 2005/07/04 23:14:21 marka Exp $ */ /*! \file */ @@ -2698,7 +2698,7 @@ fctx_create(dns_resolver_t *res, dns_name_t *name, dns_rdatatype_t type, unsigned int options, unsigned int bucketnum, fetchctx_t **fctxp) { fetchctx_t *fctx; - isc_result_t result = ISC_R_SUCCESS; + isc_result_t result; isc_result_t iresult; isc_interval_t interval; dns_fixedname_t fixed; @@ -2720,8 +2720,10 @@ fctx_create(dns_resolver_t *res, dns_name_t *name, dns_rdatatype_t type, strcat(buf, "/"); /* checked */ strcat(buf, typebuf); /* checked */ fctx->info = isc_mem_strdup(res->buckets[bucketnum].mctx, buf); - if (fctx->info == NULL) + if (fctx->info == NULL) { + result = ISC_R_NOMEMORY; goto cleanup_fetch; + } FCTXTRACE("create"); dns_name_init(&fctx->name, NULL); result = dns_name_dup(name, res->buckets[bucketnum].mctx, &fctx->name);