ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Move random number re-seeding out of the hot path

Browse Source 
Instead of checking if we need to re-seed for every isc_random call,
seed the random number generator in the libisc global initializer
and the per-thread initializer.
This commit is contained in:
Tony Finch
2022-04-22 14:35:36 +01:00
committed by Ondřej Surý
parent de75595575
commit bd251de035
5 changed files with 51 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/isc/random_test.c
View File

@@ -640,6 +640,13 @@ binarymatrixrank(uint16_t *values, size_t length) {
*** Tests for isc_random32() function
***/
/* Ensure the RNG has been automatically seeded. */
ISC_RUN_TEST_IMPL(isc_random32_initialized) {
UNUSED(state);
assert_int_not_equal(isc_random32(), 0);
}
/* Monobit test for the RANDOM */
ISC_RUN_TEST_IMPL(isc_random32_monobit) {
UNUSED(state);
@@ -764,6 +771,7 @@ ISC_RUN_TEST_IMPL(isc_nonce_bytes_binarymatrixrank) {
ISC_TEST_LIST_START
ISC_TEST_ENTRY(isc_random32_initialized)
ISC_TEST_ENTRY(isc_random32_monobit)
ISC_TEST_ENTRY(isc_random32_runs)
ISC_TEST_ENTRY(isc_random32_blockfrequency)