From bcaa5957ce46da7583d00d6b5461c915eb5f700d Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Tue, 24 Aug 2004 00:33:35 +0000 Subject: [PATCH] pullup: 1679. [bug] A bad length check was introduced by change #1661 in dns_ho.c. --- lib/bind/irs/dns_ho.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bind/irs/dns_ho.c b/lib/bind/irs/dns_ho.c index cac33b9ddf..2e19f1a927 100644 --- a/lib/bind/irs/dns_ho.c +++ b/lib/bind/irs/dns_ho.c @@ -52,7 +52,7 @@ /* BIND Id: gethnamaddr.c,v 8.15 1996/05/22 04:56:30 vixie Exp $ */ #if defined(LIBC_SCCS) && !defined(lint) -static const char rcsid[] = "$Id: dns_ho.c,v 1.15 2004/05/17 07:52:46 marka Exp $"; +static const char rcsid[] = "$Id: dns_ho.c,v 1.16 2004/08/24 00:33:35 marka Exp $"; #endif /* LIBC_SCCS and not lint */ /* Imports. */ @@ -444,8 +444,8 @@ ho_byaddr(struct irs_ho *this, const void *addr, int len, int af) abort(); qp += i; } - if ((qp - q->qname) + strlen(nibsuff2) + 1 > - sizeof q->qname){ + if (strlen(q2->qname) + strlen(nibsuff2) + 1 > + sizeof q2->qname) { errno = ENAMETOOLONG; RES_SET_H_ERRNO(pvt->res, NETDB_INTERNAL); hp = NULL;