From b12606cebe700ce65cd245d2991a4c06eb5260ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20=C5=A0pa=C4=8Dek?= <pspacek@isc.org>
Date: Tue, 10 May 2022 11:09:23 +0200
Subject: [PATCH] Extend .. statement:: directive with optional values

New and currently unused values can be provided using this syntax:

.. statement:: max-cache-size
   :tags: resolver, cache
   :short: Short description

The domain stores them in its internal structures for further use.
---
 doc/arm/_ext/iscconf.py | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/doc/arm/_ext/iscconf.py b/doc/arm/_ext/iscconf.py
index 8608e03cea..c1ce46783a 100644
--- a/doc/arm/_ext/iscconf.py
+++ b/doc/arm/_ext/iscconf.py
@@ -53,7 +53,12 @@ def domain_factory(domainname, domainlabel):
 
             has_content = True
             required_arguments = 1
-            option_spec = {}
+            # currently both options are unused
+            option_spec = {
+                "tags": directives.unchanged_required,
+                # one-sentece description for use in summary tables, in the future
+                "short": directives.unchanged_required,
+            }
 
             def handle_signature(self, sig, signode):
                 signode += addnodes.desc_name(text=sig)
@@ -61,9 +66,11 @@ def domain_factory(domainname, domainlabel):
 
             def add_target_and_index(self, _name_cls, sig, signode):
                 signode["ids"].append(domainname + "-statement-" + sig)
+                tags = [x.strip() for x in self.options.get("tags", "").split(",")]
+                short = self.options.get("short")
 
                 iscconf = self.env.get_domain(domainname)
-                iscconf.add_statement(sig)
+                iscconf.add_statement(sig, tags, short)
 
         name = domainname
         label = domainlabel
@@ -75,6 +82,8 @@ def domain_factory(domainname, domainlabel):
         roles = {"ref": XRefRole(warn_dangling=True)}
         initial_data = {
             "statements": [],  # object list for Sphinx API
+            # our own metadata: name -> {"tags": [list of tags], "short": "short desc"}
+            "statements_extra": {},
         }
 
         indices = {}  # no custom indicies
@@ -113,7 +122,7 @@ def domain_factory(domainname, domainlabel):
             """
             raise NotImplementedError
 
-        def add_statement(self, signature):
+        def add_statement(self, signature, tags, short):
             """
             Add a new statement to the domain data structures.
             No visible effect.
@@ -121,6 +130,7 @@ def domain_factory(domainname, domainlabel):
             name = "{}.{}.{}".format(domainname, "statement", signature)
             anchor = "{}-statement-{}".format(domainname, signature)
 
+            self.data["statements_extra"][name] = {"tags": tags, "short": short}
             # Sphinx API: name, dispname, type, docname, anchor, priority
             self.data["statements"].append(
                 (
@@ -139,6 +149,11 @@ def domain_factory(domainname, domainlabel):
 
             Remove traces of a document in the domain-specific inventories.
             """
+            # use name->doc mapping from Sphinx metadata
+            for name, _, _, cur_docname, _, _ in self.data["statements"]:
+                if cur_docname == docname:
+                    if name in self.data["statements_extra"]:
+                        del self.data["statements_extra"][name]
             self.data["statements"] = list(
                 obj for obj in self.data["statements"] if obj[3] != docname
             )
@@ -157,6 +172,7 @@ def domain_factory(domainname, domainlabel):
             self.data["statements"] = list(
                 set(self.data["statements"] + otherdata["statements"])
             )
+            self.data["statements_extra"].update(otherdata["statements_extra"])
 
     return ISCConfDomain