From b10d28d1e026f1bb8bfff10d9053cff51f20d136 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Tue, 30 Jul 2019 21:08:40 +0200 Subject: [PATCH] Extend prerequisites for the "xfer" system test The Net::DNS Perl module needs the Digest::HMAC module to support TSIG. However, since the latter is not a hard requirement for the former, some packagers do not make Net::DNS depend on Digest::HMAC. If Net::DNS is installed on a host but Digest::HMAC is not, the "xfer" system test breaks in a very hard-to-debug way (ans5 returns TSIG RRs with empty RDATA, which prevents TSIG-signed SOA queries and transfers from working). Prevent this from happening by making the "xfer" system test explicitly require Digest::HMAC apart from Net::DNS. --- bin/tests/system/xfer/prereq.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/bin/tests/system/xfer/prereq.sh b/bin/tests/system/xfer/prereq.sh index b8982d610c..75cd53ad49 100644 --- a/bin/tests/system/xfer/prereq.sh +++ b/bin/tests/system/xfer/prereq.sh @@ -25,3 +25,9 @@ else echo_i "This test requires the Net::DNS library." >&2 exit 1 fi + +if ! $PERL -e 'use Digest::HMAC;' 2>/dev/null +then + echo_i "This test requires the Digest::HMAC Perl module." >&2 + exit 1 +fi