dns_difftuple_create() cannot fail

dns_difftuple_create() could only return success, so change
its type to void and clean up all the calls to it.

other functions that only returned a result value because of it
have been cleaned up in the same way.
This commit is contained in:
Evan Hunt
2024-07-11 17:00:38 -07:00
committed by Ondřej Surý
parent 6573276bad
commit a68a77ca86
12 changed files with 155 additions and 247 deletions

View File

@@ -487,11 +487,8 @@ dns_test_difffromchanges(dns_diff_t *diff, const zonechange_t *changes,
* Create a diff tuple for the parsed change and append it to
* the diff.
*/
result = dns_difftuple_create(mctx, changes[i].op, name,
changes[i].ttl, &rdata, &tuple);
if (result != ISC_R_SUCCESS) {
break;
}
dns_difftuple_create(mctx, changes[i].op, name, changes[i].ttl,
&rdata, &tuple);
dns_diff_append(diff, &tuple);
}