ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Make isc_ht_init() and isc_ht_iter_create() return void

Browse Source 
Previously, the function(s) in the commit subject could fail for various
reasons - mostly allocation failures, or other functions returning
different return code than ISC_R_SUCCESS.  Now, the aforementioned
function(s) cannot ever fail and they would always return ISC_R_SUCCESS.

Change the function(s) to return void and remove the extra checks in
the code that uses them.
This commit is contained in:
Ondřej Surý
2022-03-08 11:22:55 +01:00
parent 3db335bca0
commit 8fa27365ec
9 changed files with 40 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/isc/tests/ht_test.c
View File

@@ -61,8 +61,7 @@ test_ht_full(int bits, uintptr_t count) {
isc_result_t result;
uintptr_t i;
result = isc_ht_init(&ht, test_mctx, bits);
assert_int_equal(result, ISC_R_SUCCESS);
isc_ht_init(&ht, test_mctx, bits);
assert_non_null(ht);
for (i = 1; i < count; i++) {
@@ -207,8 +206,7 @@ test_ht_iterator(void) {
unsigned char key[16];
size_t tksize;
result = isc_ht_init(&ht, test_mctx, 16);
assert_int_equal(result, ISC_R_SUCCESS);
isc_ht_init(&ht, test_mctx, 16);
assert_non_null(ht);
for (i = 1; i <= count; i++) {
/*
@@ -222,8 +220,7 @@ test_ht_iterator(void) {
}
walked = 0;
result = isc_ht_iter_create(ht, &iter);
assert_int_equal(result, ISC_R_SUCCESS);
isc_ht_iter_create(ht, &iter);
for (result = isc_ht_iter_first(iter); result == ISC_R_SUCCESS;
result = isc_ht_iter_next(iter))