ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Make isc_ht_init() and isc_ht_iter_create() return void

Browse Source 
Previously, the function(s) in the commit subject could fail for various
reasons - mostly allocation failures, or other functions returning
different return code than ISC_R_SUCCESS.  Now, the aforementioned
function(s) cannot ever fail and they would always return ISC_R_SUCCESS.

Change the function(s) to return void and remove the extra checks in
the code that uses them.
This commit is contained in:
Ondřej Surý
2022-03-08 11:22:55 +01:00
parent 3db335bca0
commit 8fa27365ec
9 changed files with 40 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bin/plugins/filter-a.c
View File

@@ -330,7 +330,7 @@ plugin_register(const char *parameters, const void *cfg, const char *cfg_file,
unsigned long cfg_line, isc_mem_t *mctx, isc_log_t *lctx,
void *actx, ns_hooktable_t *hooktable, void **instp) {
filter_instance_t *inst = NULL;
isc_result_t result;
isc_result_t result = ISC_R_SUCCESS;
isc_log_write(lctx, NS_LOGCATEGORY_GENERAL, NS_LOGMODULE_HOOKS,
ISC_LOG_INFO,
@@ -347,7 +347,7 @@ plugin_register(const char *parameters, const void *cfg, const char *cfg_file,
cfg_line, mctx, lctx, actx));
}
CHECK(isc_ht_init(&inst->ht, mctx, 16));
isc_ht_init(&inst->ht, mctx, 16);
isc_mutex_init(&inst->hlock);
/*

4
bin/plugins/filter-aaaa.c
View File

@@ -333,7 +333,7 @@ plugin_register(const char *parameters, const void *cfg, const char *cfg_file,
unsigned long cfg_line, isc_mem_t *mctx, isc_log_t *lctx,
void *actx, ns_hooktable_t *hooktable, void **instp) {
filter_instance_t *inst = NULL;
isc_result_t result;
isc_result_t result = ISC_R_SUCCESS;
isc_log_write(lctx, NS_LOGCATEGORY_GENERAL, NS_LOGMODULE_HOOKS,
ISC_LOG_INFO,
@@ -350,7 +350,7 @@ plugin_register(const char *parameters, const void *cfg, const char *cfg_file,
cfg_line, mctx, lctx, actx));
}
CHECK(isc_ht_init(&inst->ht, mctx, 16));
isc_ht_init(&inst->ht, mctx, 16);
isc_mutex_init(&inst->hlock);
/*