From 8b866ba8a0bd79addbeebb74919b63b8dbc21737 Mon Sep 17 00:00:00 2001 From: Aram Sargsyan Date: Tue, 24 Sep 2024 08:53:47 +0000 Subject: [PATCH] Do not ignore named_server_dumpdb() result code The named_server_dumpdb() function, which is called when a 'rndc dumpdb' command is issued, returns a 'isc_result_t' result code and it has been always ignored since its introduction in eb8713ed947fdf22a41dad673d561896dd6fe4a2, where it was still called ns_server_dumpdb(). The orignal reasoning is not preserved, but it could have been also a simple copy-paste mistake, as there are commands, which return 'void' and require manually setting 'result = ISC_R_SUCCESS;', as it was done here. Anyway, named will now return the actual result, and 'rndc' will report an error, when the 'dumpdb' command fails. --- bin/named/control.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bin/named/control.c b/bin/named/control.c index a1a66a4eb3..a99ce1b850 100644 --- a/bin/named/control.c +++ b/bin/named/control.c @@ -214,8 +214,7 @@ named_control_docommand(isccc_sexpr_t *message, bool readonly, { result = named_server_dnstap(named_g_server, lex, text); } else if (command_compare(command, NAMED_COMMAND_DUMPDB)) { - named_server_dumpdb(named_g_server, lex, text); - result = ISC_R_SUCCESS; + result = named_server_dumpdb(named_g_server, lex, text); } else if (command_compare(command, NAMED_COMMAND_DUMPSTATS)) { result = named_server_dumpstats(named_g_server); } else if (command_compare(command, NAMED_COMMAND_FETCHLIMIT)) {