From ec3d830bc50e43858c7982df9b9db95aa8cffca0 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Mon, 18 Feb 2019 16:36:59 +1100 Subject: [PATCH 1/2] explicitly convert byte to string --- bin/python/isc/checkds.py.in | 4 ++++ bin/python/isc/keyzone.py.in | 2 ++ 2 files changed, 6 insertions(+) diff --git a/bin/python/isc/checkds.py.in b/bin/python/isc/checkds.py.in index cac226ee4d..b5cbe3fd05 100644 --- a/bin/python/isc/checkds.py.in +++ b/bin/python/isc/checkds.py.in @@ -107,6 +107,8 @@ def check(zone, args): fp, _ = Popen(cmd, stdout=PIPE).communicate() for line in fp.splitlines(): + if type(line) is not str: + line = line.decode('ascii') rrlist.append(SECRR(line, args.lookaside)) rrlist = sorted(rrlist, key=lambda rr: (rr.keyid, rr.keyalg, rr.hashalg)) @@ -128,6 +130,8 @@ def check(zone, args): fp, _ = Popen(cmd, stdin=PIPE, stdout=PIPE).communicate(intods) for line in fp.splitlines(): + if type(line) is not str: + line = line.decode('ascii') klist.append(SECRR(line, args.lookaside)) if len(klist) < 1: diff --git a/bin/python/isc/keyzone.py.in b/bin/python/isc/keyzone.py.in index 2451d439e4..bc8c51d72f 100644 --- a/bin/python/isc/keyzone.py.in +++ b/bin/python/isc/keyzone.py.in @@ -43,6 +43,8 @@ class keyzone: fp, _ = Popen([czpath, "-o", "-", name, filename], stdout=PIPE, stderr=PIPE).communicate() for line in fp.splitlines(): + if type(line) is not str: + line = line.decode('ascii') if re.search('^[:space:]*;', line): continue fields = line.split() From 57e44efc735832976363a8d5b01290c3da0a5ce7 Mon Sep 17 00:00:00 2001 From: Evan Hunt Date: Wed, 6 Mar 2019 14:22:58 -0800 Subject: [PATCH 2/2] add CHANGES --- CHANGES | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGES b/CHANGES index 99cc52244f..9650ceec9f 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,7 @@ +5175. [bug] Fixed a problem with file input in dnssec-keymgr, + dnssec-coverage and dnssec-checkds when using + python3. [GL #882] + 5174. [doc] Tidy dnssec-keygen manual. [GL !1557] 5173. [bug] Fixed a race in socket code that could occur when