ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Fixed a race condition in the new request retransmission code:

Browse Source 
if a machine is slow or busy enough, the retransmission timer could theoretically fire
again before the first transmission has finished.  This could cause us to lose track
of whether a send is in progress or not, since that information is stored in a boolean
flag (DNS_REQUEST_F_SENDING), not a counter
This commit is contained in:
Andreas Gustafsson
2001-10-23 23:10:14 +00:00
parent 1a32d316dd
commit 897f762e3c
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/dns/request.c
View File

@@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: request.c,v 1.67 2001/10/18 06:09:37 marka Exp $ */
/* $Id: request.c,v 1.68 2001/10/23 23:10:14 gson Exp $ */
#include <config.h>
@@ -1288,10 +1288,12 @@ req_timeout(isc_task_t *task, isc_event_t *event) {
UNUSED(task);
LOCK(&request->requestmgr->locks[request->hash]);
if (event->ev_type == ISC_TIMEREVENT_TICK) {
result = req_send(request, task, &request->destaddr);
if (result != ISC_R_SUCCESS) {
req_cancel(request);
send_if_done(request, result);
if (! DNS_REQUEST_SENDING(request)) {
result = req_send(request, task, &request->destaddr);
if (result != ISC_R_SUCCESS) {
req_cancel(request);
send_if_done(request, result);
}
}
} else {
request->flags |= DNS_REQUEST_F_TIMEDOUT;