Megacommit of many files.

Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const.  Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.

The macro DE_CONST was added to isc/util.h to deal with a handful of very
special places where something is qualified as const but really needs to have
its const qualifier removed.

Also cleaned up a few places where variable names clashed with reserved
identifiers.  (Which mostly works fine, but strictly speaking is undefined
by the standard.)

Minor other ISC style cleanups.
This commit is contained in:
David Lawrence
2000-06-01 17:20:56 +00:00
parent fd6de7af32
commit 87cafc5e70
33 changed files with 685 additions and 516 deletions

View File

@@ -23,10 +23,10 @@
#include <isc/error.h>
static void
default_unexpected_callback(char *, int, char *, va_list);
default_unexpected_callback(const char *, int, const char *, va_list);
static void
default_fatal_callback(char *, int, char *, va_list);
default_fatal_callback(const char *, int, const char *, va_list);
static isc_errorcallback_t unexpected_callback = default_unexpected_callback;
static isc_errorcallback_t fatal_callback = default_fatal_callback;
@@ -48,7 +48,7 @@ isc_error_setfatal(isc_errorcallback_t cb) {
}
void
isc_error_unexpected(char *file, int line, char *format, ...) {
isc_error_unexpected(const char *file, int line, const char *format, ...) {
va_list args;
va_start(args, format);
@@ -57,7 +57,7 @@ isc_error_unexpected(char *file, int line, char *format, ...) {
}
void
isc_error_fatal(char *file, int line, char *format, ...) {
isc_error_fatal(const char *file, int line, const char *format, ...) {
va_list args;
va_start(args, format);
@@ -67,12 +67,14 @@ isc_error_fatal(char *file, int line, char *format, ...) {
}
void
isc_error_runtimecheck(char *file, int line, char *expression) {
isc_error_runtimecheck(const char *file, int line, const char *expression) {
isc_error_fatal(file, line, "RUNTIME_CHECK(%s) failed", expression);
}
static void
default_unexpected_callback(char *file, int line, char *format, va_list args) {
default_unexpected_callback(const char *file, int line, const char *format,
va_list args)
{
fprintf(stderr, "%s:%d: ", file, line);
vfprintf(stderr, format, args);
fprintf(stderr, "\n");
@@ -80,7 +82,9 @@ default_unexpected_callback(char *file, int line, char *format, va_list args) {
}
static void
default_fatal_callback(char *file, int line, char *format, va_list args) {
default_fatal_callback(const char *file, int line, const char *format,
va_list args)
{
fprintf(stderr, "%s:%d: fatal error: ", file, line);
vfprintf(stderr, format, args);
fprintf(stderr, "\n");