From 7ee20d7d108069f189bc6b4a578155ec0086472d Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Mon, 4 Dec 2023 12:23:18 +1100 Subject: [PATCH] Destroy the message before detaching the view With shared name memory pools (f5af981831ea8a707090c1b09a47c25b75d86b5a) the message needs to be destroyed before the view is detached which in turn detaches the resolver which checks that all resources have been returned. --- lib/dns/validator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dns/validator.c b/lib/dns/validator.c index 3b9c8fc5db..b679392c49 100644 --- a/lib/dns/validator.c +++ b/lib/dns/validator.c @@ -3119,10 +3119,10 @@ destroy_validator(dns_validator_t *val) { if (val->siginfo != NULL) { isc_mem_put(mctx, val->siginfo, sizeof(*val->siginfo)); } - dns_view_detach(&val->view); if (val->message != NULL) { dns_message_detach(&val->message); } + dns_view_detach(&val->view); isc_mem_put(mctx, val, sizeof(*val)); }