From 6cabbdae976a14c8b56eb9cbc381f91fcf2a0abc Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Thu, 13 Aug 2020 12:30:04 +1000 Subject: [PATCH] TLSA: fix fromwire length checks (cherry picked from commit 3429c35f52be9dfea69b96fda7d5b7fe804614a5) --- lib/dns/rdata/generic/tlsa_52.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/dns/rdata/generic/tlsa_52.c b/lib/dns/rdata/generic/tlsa_52.c index cb8b57a742..0d5e3f909c 100644 --- a/lib/dns/rdata/generic/tlsa_52.c +++ b/lib/dns/rdata/generic/tlsa_52.c @@ -122,8 +122,10 @@ generic_fromwire_tlsa(ARGS_FROMWIRE) { isc_buffer_activeregion(source, &sr); - if (sr.length < 3) + /* Usage(1), Selector(1), Type(1), Data(1+) */ + if (sr.length < 4) { return (ISC_R_UNEXPECTEDEND); + } isc_buffer_forward(source, sr.length); return (mem_tobuffer(target, sr.base, sr.length));