ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

convert TSIG keyring storage from RBT to hash table

Browse Source 
since it is not necessary to find partial matches when looking
up names in a TSIG keyring, we can use a hash table instead of
an RBT to store them.

the tsigkey object now stores the key name as a dns_fixedname
rather than allocating memory for it.

the `name` parameter to dns_tsigkeyring_add() has been removed;
it was unneeded since the tsigkey object already contains a copy
of the name.

the opportunistic cleanup_ring() function has been removed;
it was only slowing down lookups.
This commit is contained in:
Evan Hunt
2023-04-12 00:14:04 -07:00
parent e64b44a5cb
commit 6105a7d360
15 changed files with 104 additions and 210 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/dns/tsig_test.c
View File

@@ -148,7 +148,7 @@ add_tsig(dst_context_t *tsigctx, dns_tsigkey_t *key, isc_buffer_t *target) {
ISC_LIST_APPEND(rdatalist.rdata, &rdata, link);
dns_rdataset_init(&rdataset);
dns_rdatalist_tordataset(&rdatalist, &rdataset);
CHECK(dns_rdataset_towire(&rdataset, &key->name, &cctx, target, 0,
CHECK(dns_rdataset_towire(&rdataset, key->name, &cctx, target, 0,
&count));
/*
@@ -290,13 +290,13 @@ ISC_RUN_TEST_IMPL(tsig_tcp) {
result = dns_name_fromstring(keyname, "test", 0, NULL);
assert_int_equal(result, ISC_R_SUCCESS);
result = dns_tsigkeyring_create(mctx, &ring);
assert_int_equal(result, ISC_R_SUCCESS);
dns_tsigkeyring_create(mctx, &ring);
assert_non_null(ring);
result = dns_tsigkey_create(keyname, DST_ALG_HMACSHA256, secret,
sizeof(secret), mctx, &key);
assert_int_equal(result, ISC_R_SUCCESS);
result = dns_tsigkeyring_add(ring, keyname, key);
result = dns_tsigkeyring_add(ring, key);
assert_int_equal(result, ISC_R_SUCCESS);
assert_non_null(key);