ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Check for proper file size output in dnstap test

Browse Source 
Previously, the first check silently failed, as 454 is apparently (in my
local setup) the minimum output size for the dnstap output, rather than
470 which the test was expecting. Effectively, the check served as a 5
second sleep rather than waiting for the proper file size.

Additionally, check the expected file sizes and fail if expectations
aren't met.
This commit is contained in:
Tom Krizek
2023-06-22 18:08:17 +02:00
parent 1dd4c2b9e2
commit 5f809e50b6
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
bin/tests/system/dnstap/tests.sh
View File

@@ -562,7 +562,12 @@ EOF
echo_i "checking unix socket message counts"
sleep 2
retry_quiet 5 dnstap_data_ready $fstrm_capture_pid dnstap.out 470
retry_quiet 5 dnstap_data_ready $fstrm_capture_pid dnstap.out 454 || {
echo_i "dnstap output file smaller than expected"
ret=1
}
if [ $ret != 0 ]; then echo_i "failed"; fi
status=$((status + ret))
kill $fstrm_capture_pid
wait
udp4=`$DNSTAPREAD dnstap.out | grep "UDP " | wc -l`
@@ -675,7 +680,12 @@ EOF
echo_i "checking reopened unix socket message counts"
sleep 2
retry_quiet 5 dnstap_data_ready $fstrm_capture_pid dnstap.out 270
retry_quiet 5 dnstap_data_ready $fstrm_capture_pid dnstap.out 270 || {
echo_i "dnstap output file smaller than expected"
ret=1
}
if [ $ret != 0 ]; then echo_i "failed"; fi
status=$((status + ret))
kill $fstrm_capture_pid
wait
udp4=`$DNSTAPREAD dnstap.out | grep "UDP " | wc -l`