From 035cf4edddc6f5eeaa93e40fc94c094ee487a9ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Fri, 3 Jul 2020 11:10:39 +0200 Subject: [PATCH 1/9] Tweak and reword recent CHANGES entries --- CHANGES | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/CHANGES b/CHANGES index 5b1d96973f..d597e20940 100644 --- a/CHANGES +++ b/CHANGES @@ -27,19 +27,18 @@ by a data race between zone_maintenance() and dns_zone_setview_helper(). [GL #1627] -5455. [bug] `named` could crash when cleaning dead nodes - in lib/dns/rbtdb.c that have been reused meanwhile. - [GL #1968] +5455. [bug] named could crash when cleaning dead nodes in + lib/dns/rbtdb.c that were being reused. [GL #1968] -5454. [bug] Address a startup crash happening when server is - under load and root zone is not yet loaded. [GL #1862] +5454. [bug] Address a startup crash that occurred when the server + was under load and the root zone had not yet been + loaded. [GL #1862] -5453. [bug] `named` would crash on shutdown when new `rndc` - connection is received at the same time as - shutting down. [GL #1747] +5453. [bug] named crashed on shutdown when a new rndc connection was + received during shutdown. [GL #1747] -5452. [bug] The "blackhole" ACL was accidentally disabled with - respect to client queries. [GL #1936] +5452. [bug] The "blackhole" ACL was accidentally disabled for client + queries. [GL #1936] 5451. [func] Add 'rndc dnssec -status' command. [GL #1612] @@ -55,24 +54,24 @@ 5446. [bug] The validator could fail to accept a properly signed RRset if an unsupported algorithm appeared earlier in - the DNSKEY RRset than a supported algorithm. It could + the DNSKEY RRset than a supported algorithm. It could also stop if it detected a malformed public key. [GL #1689] -5444. [bug] 'rndc dnstap -roll ' was not limiting the - number of saved files to . [GL !3728] +5444. [bug] 'rndc dnstap -roll ' did not limit the number of + saved files to . [GL !3728] 5443. [bug] The "primary" and "secondary" keywords, when used as parameters for "check-names", were not processed correctly and were being ignored. [GL #1949] -5441. [bug] ${LMDB_CFLAGS} missing from make/includes.in +5441. [bug] ${LMDB_CFLAGS} was missing from make/includes.in. [GL #1955] 5440. [test] Properly handle missing kyua. [GL #1950] -5439. [bug] The dsset returned by dns_keynode_dsset() was not - thread safe. [GL #1926] +5439. [bug] The DS RRset returned by dns_keynode_dsset() was used in + a non-thread-safe manner. [GL #1926] --- 9.16.4 released --- From a67bdd4d1da928e9d4f9f3886037b914f1d597e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Fri, 3 Jul 2020 11:10:39 +0200 Subject: [PATCH 2/9] Prepare release notes for BIND 9.16.5 --- doc/arm/notes.rst | 2 +- doc/notes/{notes-current.rst => notes-9.16.5.rst} | 15 --------------- util/copyrights | 2 +- 3 files changed, 2 insertions(+), 17 deletions(-) rename doc/notes/{notes-current.rst => notes-9.16.5.rst} (95%) diff --git a/doc/arm/notes.rst b/doc/arm/notes.rst index cc85d4ccbe..d9b499970f 100644 --- a/doc/arm/notes.rst +++ b/doc/arm/notes.rst @@ -59,7 +59,7 @@ https://www.isc.org/download/. There you will find additional information about each release, source code, and pre-compiled versions for Microsoft Windows operating systems. -.. include:: ../notes/notes-current.rst +.. include:: ../notes/notes-9.16.5.rst .. include:: ../notes/notes-9.16.4.rst .. include:: ../notes/notes-9.16.3.rst .. include:: ../notes/notes-9.16.2.rst diff --git a/doc/notes/notes-current.rst b/doc/notes/notes-9.16.5.rst similarity index 95% rename from doc/notes/notes-current.rst rename to doc/notes/notes-9.16.5.rst index 52d1ff16cd..004f9cb5ec 100644 --- a/doc/notes/notes-current.rst +++ b/doc/notes/notes-9.16.5.rst @@ -11,21 +11,6 @@ Notes for BIND 9.16.5 --------------------- -Security Fixes -~~~~~~~~~~~~~~ - -- None. - -Known Issues -~~~~~~~~~~~~ - -- None. - -New Features -~~~~~~~~~~~~ - -- None. - Feature Changes ~~~~~~~~~~~~~~~ diff --git a/util/copyrights b/util/copyrights index 82276dd1cb..2b62a70b66 100644 --- a/util/copyrights +++ b/util/copyrights @@ -1449,7 +1449,7 @@ ./doc/notes/notes-9.16.2.rst RST 2020 ./doc/notes/notes-9.16.3.rst RST 2020 ./doc/notes/notes-9.16.4.rst RST 2020 -./doc/notes/notes-current.rst RST 2020 +./doc/notes/notes-9.16.5.rst RST 2020 ./docutil/HTML_COPYRIGHT X 2001,2004,2016,2018,2019,2020 ./docutil/MAN_COPYRIGHT X 2001,2004,2016,2018,2019,2020 ./docutil/patch-db2latex-duplicate-template-bug X 2007,2018,2019,2020 From ea6e64f7d06f6c601392e459c6a98c1cb6d0665a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Fri, 3 Jul 2020 11:10:39 +0200 Subject: [PATCH 3/9] Tweak and reword release notes --- doc/notes/notes-9.16.5.rst | 48 +++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/doc/notes/notes-9.16.5.rst b/doc/notes/notes-9.16.5.rst index 004f9cb5ec..87a619b341 100644 --- a/doc/notes/notes-9.16.5.rst +++ b/doc/notes/notes-9.16.5.rst @@ -11,49 +11,45 @@ Notes for BIND 9.16.5 --------------------- -Feature Changes -~~~~~~~~~~~~~~~ +New Features +~~~~~~~~~~~~ -- New ``rndc`` command ``rndc dnssec -status`` that shows the current - DNSSEC policy and keys in use, the key states and rollover status. +- New ``rndc`` command ``rndc dnssec -status`` shows the current DNSSEC + policy and keys in use, the key states, and rollover status. [GL #1612] Bug Fixes ~~~~~~~~~ -- The DS set returned by ``dns_keynode_dsset()`` was not thread-safe. - This could result in an INSIST being triggered. [GL #1926] +- The DS RRset returned by ``dns_keynode_dsset()`` was used in a + non-thread-safe manner. This could result in an INSIST being + triggered. [GL #1926] - Properly handle missing ``kyua`` command so that ``make check`` does not fail unexpectedly when CMocka is installed, but Kyua is not. [GL #1950] -- The ``primary`` and ``secondary`` keywords, when used as parameters for - ``check-names``, were not processed correctly and were being ignored. - [GL #1949] +- The ``primary`` and ``secondary`` keywords, when used as parameters + for ``check-names``, were not processed correctly and were being + ignored. [GL #1949] -- 'rndc dnstap -roll ' was not limiting the number of saved - files to . [GL !3728] +- ``rndc dnstap -roll `` did not limit the number of saved files + to ````. [GL !3728] - The validator could fail to accept a properly signed RRset if an unsupported algorithm appeared earlier in the DNSKEY RRset than a - supported algorithm. It could also stop if it detected a malformed + supported algorithm. It could also stop if it detected a malformed public key. [GL #1689] -- The ``blackhole`` ACL was inadvertently disabled with respect to - client queries. Blocked IP addresses were not used for upstream - queries but queries from those addresses could still be answered. - [GL #1936] +- The ``blackhole`` ACL was inadvertently disabled for client queries. + Blocked IP addresses were not used for upstream queries but queries + from those addresses could still be answered. [GL #1936] -- ``named`` would crash on shutdown when new ``rndc`` connection is received at - the same time as shutting down. [GL #1747] +- ``named`` crashed on shutdown when a new ``rndc`` connection was + received during shutdown. This has been fixed. [GL #1747] -- Fix assertion failure when server is under load and root zone is not yet - loaded. [GL #1862] +- Fix assertion failure when server was under load and root zone had not + yet been loaded. [GL #1862] -- ``named`` could crash when cleaning dead nodes in ``lib/dns/rbtdb.c`` that - have been reused meanwhile. [GL #1968] - -- The introduction of KASP support broke whether the second field - of sig-validity-interval was treated as days or hours. (Thanks to - Tony Finch.) [GL !3735] +- ``named`` could crash when cleaning dead nodes in ``lib/dns/rbtdb.c`` + that were being reused. [GL #1968] From f97cf92fdad4caf42a2c88961da41725ed990a2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Fri, 3 Jul 2020 11:10:39 +0200 Subject: [PATCH 4/9] Add release note for #1937 --- doc/notes/notes-9.16.5.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/notes/notes-9.16.5.rst b/doc/notes/notes-9.16.5.rst index 87a619b341..5fe8c43cf0 100644 --- a/doc/notes/notes-9.16.5.rst +++ b/doc/notes/notes-9.16.5.rst @@ -21,6 +21,11 @@ New Features Bug Fixes ~~~~~~~~~ +- A race condition could occur if a TCP socket connection was closed + while ``named`` was waiting for a recursive response. The attempt to + send a response over the closing connection triggered an assertion + failure in the function ``isc__nm_tcpdns_send()``. [GL #1937] + - The DS RRset returned by ``dns_keynode_dsset()`` was used in a non-thread-safe manner. This could result in an INSIST being triggered. [GL #1926] From 560c7c245294b76aa10d723d34833ee38a09d6c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Fri, 3 Jul 2020 11:10:39 +0200 Subject: [PATCH 5/9] Add release note for #1938 --- doc/notes/notes-9.16.5.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/notes/notes-9.16.5.rst b/doc/notes/notes-9.16.5.rst index 5fe8c43cf0..61add01989 100644 --- a/doc/notes/notes-9.16.5.rst +++ b/doc/notes/notes-9.16.5.rst @@ -26,6 +26,10 @@ Bug Fixes send a response over the closing connection triggered an assertion failure in the function ``isc__nm_tcpdns_send()``. [GL #1937] +- A race condition could occur when ``named`` attempted to use a UDP + interface that was shutting down. This triggered an assertion failure + in ``uv__udp_finish_close()``. [GL #1938] + - The DS RRset returned by ``dns_keynode_dsset()`` was used in a non-thread-safe manner. This could result in an INSIST being triggered. [GL #1926] From 03995ef2d0fbd494225a2f66d92a4c1a1029345f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Fri, 3 Jul 2020 11:10:39 +0200 Subject: [PATCH 6/9] Reorder release notes --- doc/notes/notes-9.16.5.rst | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/notes/notes-9.16.5.rst b/doc/notes/notes-9.16.5.rst index 61add01989..757053a3af 100644 --- a/doc/notes/notes-9.16.5.rst +++ b/doc/notes/notes-9.16.5.rst @@ -30,6 +30,15 @@ Bug Fixes interface that was shutting down. This triggered an assertion failure in ``uv__udp_finish_close()``. [GL #1938] +- Fix assertion failure when server was under load and root zone had not + yet been loaded. [GL #1862] + +- ``named`` could crash when cleaning dead nodes in ``lib/dns/rbtdb.c`` + that were being reused. [GL #1968] + +- ``named`` crashed on shutdown when a new ``rndc`` connection was + received during shutdown. This has been fixed. [GL #1747] + - The DS RRset returned by ``dns_keynode_dsset()`` was used in a non-thread-safe manner. This could result in an INSIST being triggered. [GL #1926] @@ -53,12 +62,3 @@ Bug Fixes - The ``blackhole`` ACL was inadvertently disabled for client queries. Blocked IP addresses were not used for upstream queries but queries from those addresses could still be answered. [GL #1936] - -- ``named`` crashed on shutdown when a new ``rndc`` connection was - received during shutdown. This has been fixed. [GL #1747] - -- Fix assertion failure when server was under load and root zone had not - yet been loaded. [GL #1862] - -- ``named`` could crash when cleaning dead nodes in ``lib/dns/rbtdb.c`` - that were being reused. [GL #1968] From b03a635f6866ef5376a4a9e138e73356275d57d8 Mon Sep 17 00:00:00 2001 From: Tinderbox User Date: Fri, 3 Jul 2020 10:37:08 +0000 Subject: [PATCH 7/9] prep 9.16.5 --- CHANGES | 2 ++ configure | 2 ++ lib/bind9/api | 2 +- lib/dns/api | 4 ++-- lib/isc/api | 4 ++-- lib/ns/api | 4 ++-- version | 2 +- 7 files changed, 12 insertions(+), 8 deletions(-) diff --git a/CHANGES b/CHANGES index d597e20940..eb27375ad7 100644 --- a/CHANGES +++ b/CHANGES @@ -23,6 +23,8 @@ statistics. Convert the header attributes to use atomic operations. [GL #1475] + --- 9.16.5 released --- + 5458. [bug] Prevent a theoretically possible NULL dereference caused by a data race between zone_maintenance() and dns_zone_setview_helper(). [GL #1627] diff --git a/configure b/configure index 009d600292..bf98339e2f 100755 --- a/configure +++ b/configure @@ -17993,6 +17993,7 @@ fi + # # was --with-libxml2 specified? # @@ -20863,6 +20864,7 @@ fi + # # The following sets up how non-blocking i/o is established. # cygwin and solaris 2.x (x<5) require special handling. diff --git a/lib/bind9/api b/lib/bind9/api index 425e431aad..0b1062a755 100644 --- a/lib/bind9/api +++ b/lib/bind9/api @@ -11,5 +11,5 @@ # 9.13/9.14: 1300-1499 # 9.15/9.16: 1500-1699 LIBINTERFACE = 1600 -LIBREVISION = 3 +LIBREVISION = 4 LIBAGE = 0 diff --git a/lib/dns/api b/lib/dns/api index 96ab741028..8207cc3240 100644 --- a/lib/dns/api +++ b/lib/dns/api @@ -10,6 +10,6 @@ # 9.12: 1200-1299 # 9.13/9.14: 1300-1499 # 9.15/9.16: 1500-1699 -LIBINTERFACE = 1604 +LIBINTERFACE = 1605 LIBREVISION = 0 -LIBAGE = 1 +LIBAGE = 0 diff --git a/lib/isc/api b/lib/isc/api index 96ab741028..8207cc3240 100644 --- a/lib/isc/api +++ b/lib/isc/api @@ -10,6 +10,6 @@ # 9.12: 1200-1299 # 9.13/9.14: 1300-1499 # 9.15/9.16: 1500-1699 -LIBINTERFACE = 1604 +LIBINTERFACE = 1605 LIBREVISION = 0 -LIBAGE = 1 +LIBAGE = 0 diff --git a/lib/ns/api b/lib/ns/api index 1c9bb8b38e..ea448d1898 100644 --- a/lib/ns/api +++ b/lib/ns/api @@ -10,6 +10,6 @@ # 9.12: 1200-1299 # 9.13/9.14: 1300-1499 # 9.15/9.16: 1500-1699 -LIBINTERFACE = 1603 -LIBREVISION = 1 +LIBINTERFACE = 1604 +LIBREVISION = 0 LIBAGE = 0 diff --git a/version b/version index cf0fa36955..c8e1985b84 100644 --- a/version +++ b/version @@ -5,7 +5,7 @@ PRODUCT=BIND DESCRIPTION="(Stable Release)" MAJORVER=9 MINORVER=16 -PATCHVER=4 +PATCHVER=5 RELEASETYPE= RELEASEVER= EXTENSIONS= From 84f16aaca9de3f4469c604dcb50e1eab7c77df94 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Wed, 15 Jul 2020 23:19:58 +0200 Subject: [PATCH 8/9] Bump BIND_BASELINE_VERSION for ABI checks --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d611f86caa..7d74349056 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1388,7 +1388,7 @@ abi-check: variables: CC: gcc CFLAGS: "${CFLAGS_COMMON} -Og" - BIND_BASELINE_VERSION: v9_16_4 + BIND_BASELINE_VERSION: v9_16_5 script: - *configure - make -j${BUILD_PARALLEL_JOBS:-1} V=1 From 0fbe13bc65da026dadccb5ffeeef4bebdc6b0da8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Wed, 15 Jul 2020 23:19:58 +0200 Subject: [PATCH 9/9] Set up release notes for BIND 9.16.6 --- doc/arm/notes.rst | 1 + doc/notes/notes-current.rst | 39 +++++++++++++++++++++++++++++++++++++ util/copyrights | 1 + 3 files changed, 41 insertions(+) create mode 100644 doc/notes/notes-current.rst diff --git a/doc/arm/notes.rst b/doc/arm/notes.rst index d9b499970f..15b341dd2e 100644 --- a/doc/arm/notes.rst +++ b/doc/arm/notes.rst @@ -59,6 +59,7 @@ https://www.isc.org/download/. There you will find additional information about each release, source code, and pre-compiled versions for Microsoft Windows operating systems. +.. include:: ../notes/notes-current.rst .. include:: ../notes/notes-9.16.5.rst .. include:: ../notes/notes-9.16.4.rst .. include:: ../notes/notes-9.16.3.rst diff --git a/doc/notes/notes-current.rst b/doc/notes/notes-current.rst new file mode 100644 index 0000000000..345079b266 --- /dev/null +++ b/doc/notes/notes-current.rst @@ -0,0 +1,39 @@ +.. + Copyright (C) Internet Systems Consortium, Inc. ("ISC") + + This Source Code Form is subject to the terms of the Mozilla Public + License, v. 2.0. If a copy of the MPL was not distributed with this + file, You can obtain one at http://mozilla.org/MPL/2.0/. + + See the COPYRIGHT file distributed with this work for additional + information regarding copyright ownership. + +Notes for BIND 9.16.6 +--------------------- + +Security Fixes +~~~~~~~~~~~~~~ + +- None. + +Known Issues +~~~~~~~~~~~~ + +- None. + +New Features +~~~~~~~~~~~~ + +- None. + +Feature Changes +~~~~~~~~~~~~~~~ + +- None. + +Bug Fixes +~~~~~~~~~ + +- The introduction of KASP support broke whether the second field + of sig-validity-interval was treated as days or hours. (Thanks to + Tony Finch.) [GL !3735] diff --git a/util/copyrights b/util/copyrights index 2b62a70b66..c2e5080167 100644 --- a/util/copyrights +++ b/util/copyrights @@ -1450,6 +1450,7 @@ ./doc/notes/notes-9.16.3.rst RST 2020 ./doc/notes/notes-9.16.4.rst RST 2020 ./doc/notes/notes-9.16.5.rst RST 2020 +./doc/notes/notes-current.rst RST 2020 ./docutil/HTML_COPYRIGHT X 2001,2004,2016,2018,2019,2020 ./docutil/MAN_COPYRIGHT X 2001,2004,2016,2018,2019,2020 ./docutil/patch-db2latex-duplicate-template-bug X 2007,2018,2019,2020