From 4e282e97bef322ba1d47cbc09b9ea02cf269ab7e Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Wed, 13 Oct 2004 22:28:31 +0000 Subject: [PATCH] 1744. [bug] If tuple2msgname() failed to convert a tuple to a name a REQUIRE could be triggered. [RT #12796] --- CHANGES | 3 +++ lib/dns/xfrin.c | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index d2dd788a72..14b84871ec 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +1744. [bug] If tuple2msgname() failed to convert a tuple to + a name a REQUIRE could be triggered. [RT #12796] + 1741. [bug] Deleting all records at a node in a secure zone using a update-policy grant failed. [RT #12787] diff --git a/lib/dns/xfrin.c b/lib/dns/xfrin.c index 0a49795f0f..2565bbf203 100644 --- a/lib/dns/xfrin.c +++ b/lib/dns/xfrin.c @@ -15,7 +15,7 @@ * PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: xfrin.c,v 1.135.18.1 2004/09/16 04:56:02 marka Exp $ */ +/* $Id: xfrin.c,v 1.135.18.2 2004/10/13 22:28:31 marka Exp $ */ #include @@ -923,9 +923,10 @@ tuple2msgname(dns_difftuple_t *tuple, dns_message_t *msg, dns_name_t **target) failure: - if (rds != NULL) + if (rds != NULL) { dns_rdataset_disassociate(rds); dns_message_puttemprdataset(msg, &rds); + } if (rdl != NULL) { ISC_LIST_UNLINK(rdl->rdata, rdata, link); dns_message_puttemprdatalist(msg, &rdl);