From 389ec663f262cc219e986d6600eec9707ef2cb24 Mon Sep 17 00:00:00 2001 From: Brian Wellington Date: Thu, 28 Sep 2000 16:39:49 +0000 Subject: [PATCH] 495. [bug] nsupdate was unable to handle large records [RT #368] --- CHANGES | 2 ++ bin/nsupdate/nsupdate.c | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/CHANGES b/CHANGES index 0e770f4ccc..27aef8321c 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,5 @@ + 495. [bug] nsupdate was unable to handle large records [RT #368] + 494. [func] Do not cache NXDOMAIN responses for SOA queries. 493. [func] Return non-cachable (ttl = 0) NXDOMAIN responses diff --git a/bin/nsupdate/nsupdate.c b/bin/nsupdate/nsupdate.c index bcbc4018df..b6785ffdaa 100644 --- a/bin/nsupdate/nsupdate.c +++ b/bin/nsupdate/nsupdate.c @@ -15,7 +15,7 @@ * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: nsupdate.c,v 1.50 2000/09/18 23:23:12 gson Exp $ */ +/* $Id: nsupdate.c,v 1.51 2000/09/28 16:39:47 bwelling Exp $ */ #include @@ -68,12 +68,12 @@ extern int h_errno; #include #include -#define MXNAME 256 -#define MAXCMD 1024 +#define MAXCMD (4 * 1024) +#define MAXDATA (4 * 1024) #define NAMEBUF 512 #define WORDLEN 512 -#define PACKETSIZE 2048 -#define MSGTEXT 4096 +#define PACKETSIZE (16 * 1024) +#define MSGTEXT (16 * 1024) #define FIND_TIMEOUT 5 #define TTL_MAX 2147483647 /* Maximum signed 32 bit integer. */ @@ -602,7 +602,7 @@ parse_rdata(char **cmdlinep, dns_rdataclass_t rdataclass, result = isc_lex_openbuffer(lex, &source); check_result(result, "isc_lex_openbuffer"); - result = isc_buffer_allocate(mctx, &buf, MXNAME); + result = isc_buffer_allocate(mctx, &buf, MAXDATA); check_result(result, "isc_buffer_allocate"); dns_rdatacallbacks_init_stdio(&callbacks); if (userzone != NULL) @@ -1261,7 +1261,7 @@ recvsoa(isc_task_t *task, isc_event_t *event) { if (userserver != NULL) serveraddr = userserver; else { - char serverstr[MXNAME]; + char serverstr[DNS_NAME_MAXTEXT+1]; isc_buffer_t buf; isc_buffer_init(&buf, serverstr, sizeof(serverstr));