ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Before signing with a key, make sure that it's not the public-only part.

Browse Source 
A sane crypto toolkit would catch this and return an error, but openssl
unceremoniously seg faults.
This commit is contained in:
Brian Wellington
2001-11-30 02:11:04 +00:00
parent fdba3257ce
commit 2e4bec457d
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/dns/sec/dst/dst_api.c
View File

@@ -19,7 +19,7 @@
/*
* Principal Author: Brian Wellington
* $Id: dst_api.c,v 1.97 2001/11/30 01:59:29 gson Exp $
* $Id: dst_api.c,v 1.98 2001/11/30 02:11:04 bwelling Exp $
*/
#include <config.h>
@@ -237,16 +237,22 @@ dst_context_adddata(dst_context_t *dctx, const isc_region_t *data) {
isc_result_t
dst_context_sign(dst_context_t *dctx, isc_buffer_t *sig) {
dst_key_t *key;
REQUIRE(VALID_CTX(dctx));
REQUIRE(sig != NULL);
CHECKALG(dctx->key->key_alg);
if (dctx->key->opaque == NULL)
key = dctx->key;
CHECKALG(key->key_alg);
if (key->opaque == NULL)
return (DST_R_NULLKEY);
if (dctx->key->func->sign == NULL)
if (key->func->sign == NULL)
return (DST_R_NOTPRIVATEKEY);
if (key->func->isprivate == NULL ||
key->func->isprivate(key) == ISC_FALSE)
return (DST_R_NOTPRIVATEKEY);
return (dctx->key->func->sign(dctx, sig));
return (key->func->sign(dctx, sig));
}
isc_result_t