From 0d3693f08f19675b1fe852c8877f3adefc884169 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Tue, 20 Jun 2023 11:31:55 +1000 Subject: [PATCH] Remove unnecessary REQUIRE in dns_resolver_attach There is no harm in aquiring an additional reference to the resolver after it has started shutting down. All the REQUIRE was doing was introducing a point of failure when shutting down the server. --- lib/dns/resolver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c index f2c2e1cace..b5a78ab52b 100644 --- a/lib/dns/resolver.c +++ b/lib/dns/resolver.c @@ -10616,7 +10616,6 @@ dns_resolver_attach(dns_resolver_t *source, dns_resolver_t **targetp) { RRTRACE(source, "attach"); - REQUIRE(!atomic_load_acquire(&source->exiting)); isc_refcount_increment(&source->references); *targetp = source;