ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Refactor the isc_log API so it cannot fail on memory failures

Browse Source 
The isc_mem API now crashes on memory allocation failure, and this is
the next commit in series to cleanup the code that could fail before,
but cannot fail now, e.g. isc_result_t return type has been changed to
void for the isc_log API functions that could only return ISC_R_SUCCESS.
This commit is contained in:
Mark Andrews
2020-03-18 14:17:55 +11:00
committed by Ondřej Surý
parent e6deefd03f
commit 0b793166d0
35 changed files with 217 additions and 399 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
doc/dev/dev.md
View File

@@ -1066,9 +1066,7 @@ the following steps need to be taken to initialize it.
isc_logconfig_t *lcfg;
isc_mem_create(&mctx);
if (isc_log_create(mctx, &lctx, &lcfg) != ISC_R_SUCCESS)) {
oops_it_didnt_work();
}
isc_log_create(mctx, &lctx, &lcfg) != ISC_R_SUCCESS);
1. Initialize any additional libraries. The convention for the name of
the initialization function is `{library}_log_init()`, with a pointer to
@@ -1091,24 +1089,16 @@ the following steps need to be taken to initialize it.
destination.file.name = "/var/log/example";
destination.file.maximum_size = 0; /* No byte limit. */
destination.file.versions = ISC_LOG_ROLLNEVER; /* External rolling. */
result = isc_log_createchannel(lcfg, "sample1", ISC_LOG_TOFILE,
ISC_LOG_DYNAMIC, &destination,
ISC_LOG_PRINTTIME);
if (result != ISC_R_SUCCESS)
oops_it_didnt_work();
isc_log_createchannel(lcfg, "sample1", ISC_LOG_TOFILE, ISC_LOG_DYNAMIC,
&destination, ISC_LOG_PRINTTIME);
destination.file.stream = stdout;
result = isc_log_createchannel(lcfg, "sample2", ISC_LOG_TOFILEDESC,
ISC_LOG_INFO, &destination,
ISC_LOG_PRINTTIME);
if (result != ISC_R_SUCCESS)
oops_it_didnt_work();
isc_log_createchannel(lcfg, "sample2", ISC_LOG_TOFILEDESC,
ISC_LOG_INFO, &destination, ISC_LOG_PRINTTIME);
destination.facility = LOG_ERR;
result = isc_log_createchannel(lcfg, "sample3", ISC_LOG_SYSLOG,
ISC_LOG_ERROR, &destination, 0);
if (result != ISC_R_SUCCESS)
oops_it_didnt_work();
isc_log_createchannel(lcfg, "sample3", ISC_LOG_SYSLOG, ISC_LOG_ERROR,
&destination, 0);
`ISC_LOG_DYNAMIC` is used to define a channel that wants any of the
messages up to the current debugging level of the program.