From 70ae48e5cb56c7df23647bc511951d758e57ec88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Tue, 26 Feb 2019 12:33:19 +0100 Subject: [PATCH] Fix IP regex used in the "resolver" system test If dots are not escaped in the "1.2.3.4" regular expressions used for checking whether IP address 1.2.3.4 is present in the tested resolver's answers, a COOKIE that matches such a regular expression will trigger a false positive for the "resolver" system test. Properly escape dots in the aforementioned regular expressions to prevent that from happening. --- bin/tests/system/resolver/tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/tests/system/resolver/tests.sh b/bin/tests/system/resolver/tests.sh index 89e74cd1d0..7b3c27531b 100755 --- a/bin/tests/system/resolver/tests.sh +++ b/bin/tests/system/resolver/tests.sh @@ -773,7 +773,7 @@ ret=0 $DIG $DIGOPTS @10.53.0.5 truncated.no-questions. a > dig.ns5.out.${n} || ret=1 grep "status: NOERROR" dig.ns5.out.${n} > /dev/null || ret=1 grep "ANSWER: 1," dig.ns5.out.${n} > /dev/null || ret=1 -grep "1.2.3.4" dig.ns5.out.${n} > /dev/null || ret=1 +grep "1\.2\.3\.4" dig.ns5.out.${n} > /dev/null || ret=1 if [ $ret != 0 ]; then echo_i "failed"; fi status=`expr $status + $ret` @@ -783,7 +783,7 @@ ret=0 $DIG $DIGOPTS @10.53.0.5 not-truncated.no-questions. a > dig.ns5.out.${n} || ret=1 grep "status: NOERROR" dig.ns5.out.${n} > /dev/null && ret=1 grep "ANSWER: 1," dig.ns5.out.${n} > /dev/null && ret=1 -grep "1.2.3.4" dig.ns5.out.${n} > /dev/null && ret=1 +grep "1\.2\.3\.4" dig.ns5.out.${n} > /dev/null && ret=1 if [ $ret != 0 ]; then echo_i "failed"; fi status=`expr $status + $ret`